Received-SPF: pass (google.com: domain of linux-kernel+bounces-211234-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 12 Jun 2024 14:41:27 +0530
From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Roger Quadros <rogerq@kernel.org>
CC: Vignesh Raghavendra <vigneshr@ti.com>,
        Siddharth Vadapalli
	<s-vadapalli@ti.com>, <nm@ti.com>, <afd@ti.com>,
        <kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
        <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <u-kumar1@ti.com>, <danishanwar@ti.com>, <srk@ti.com>
Subject: Re: [PATCH v5 1/7] arm64: dts: ti: am62p: Rename am62p-{}.dtsi to
 am62p-j722s-common-{}.dtsi
Message-ID: <2f1aa07a-5a51-49aa-8829-c616cb9431bc@ti.com>
References: <20240604085252.3686037-1-s-vadapalli@ti.com>
 <20240604085252.3686037-2-s-vadapalli@ti.com>
 <92af5f36-0c21-4b6e-adde-fcf21b540291@kernel.org>
 <902f024a-b0a1-4a0a-94e2-7cec064a91c6@ti.com>
 <6959494a-98ba-4ccf-973c-14d079b76f27@kernel.org>
 <975c90b1-6657-40c6-a336-7f1f58acf531@ti.com>
 <9e7d3f9b-c762-40cd-9d0d-2f071aa3c371@ti.com>
 <efcb16cd-83de-403c-885d-cf9d819e5da7@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <efcb16cd-83de-403c-885d-cf9d819e5da7@kernel.org>

On Tue, Jun 11, 2024 at 08:18:34PM +0300, Roger Quadros wrote:
> 
> 
> On 11/06/2024 12:10, Vignesh Raghavendra wrote:
> > 
> > 
> > On 11/06/24 14:24, Siddharth Vadapalli wrote:
> >> On Mon, Jun 10, 2024 at 10:31:07PM +0300, Roger Quadros wrote:

[...]

> >>>
> >>> What is the equivalent of k3-am62p5.dtsi here?
> >>> That should contain k3-j722s.dtsi + CPU and OPP stuff.
> >>>
> >>> I suppose it should be named specific to the SoC variant part number?
> >>
> >> AM62P (https://www.ti.com/product/AM62P) has two variants:
> >> 1. 2 Arm Cortex-A53 => AM62P3
> >> 2. 4 Arm Cortex-A53 => AM62P5
> >> Both variants will share the common k3-am62p.dtsi
> >>
> >> J722S (https://www.ti.com/product/TDA4VEN-Q1) has only one variant:
> >> 4 Arm Cortex-A53 => J722S
> >> Which is currently identical to AM62P5 w.r.t. the number of A53s.
> >>
> >> So there isn't an equivalent of AM62P5/k3-am62p5.dtsi for J722S.
> >> k3-j722s.dtsi is a combination of k3-am62p.dtsi and k3-am62p5.dtsi.
> >>
> > 
> > 
> > Historically AM6xx devices have had CPUs in separte file as there are OPNs with different number of CPU cores Hence, how about
> > k3-am62p5.dtsi => k3-am62p.dtsi + k3-am62p-j722s-common-{main,mcu,wakeup}.dtsi + k3-am62p-main.dtsi (USB2 and other deltas specific to AM62P)
> > 
> > and since J722s has no variants with less than 4 cores (and along the lines of rest of J7xx devices):
> > 
> > k3-j722s.dtsi => k3-am62p-j722s-common-{main,mcu,wakeup}.dtsi + k3-j722s-main.dtsi (USB3, C7x and other deltas specific to J722s;
> > 
> > 
> 
> Seems OK to me.

Vignesh, Roger,

I will implement the above in the v6 series.

Regards,
Siddharth.