Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp320904lqp; Wed, 12 Jun 2024 02:36:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUGW4z1sBEy8+2VgHBopyF9FuCLXLqFQdH0QrvgrNLCLnDWNutc4NruT/PSzdvAqmrbV14NdSMlJnBEr9ylgsZxHBDsmJtKqvyfPLdCqg== X-Google-Smtp-Source: AGHT+IFug1Zbjg0XRE/srw3ft3qNFKEjZnRvggj4p2GD0G6MGcLUSp/jo010K9IxhVLX0pjdugr0 X-Received: by 2002:a17:906:8307:b0:a6f:1c0e:6776 with SMTP id a640c23a62f3a-a6f4680084cmr91289566b.16.1718185008831; Wed, 12 Jun 2024 02:36:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718185008; cv=pass; d=google.com; s=arc-20160816; b=Fejdxxl0JNs6qA9iuvjkMlsR3gFC+ZBZ8VvrRLpv+dpQJkfThZYczvJ2iRKmUf2spo jwROE6JDMNlTNpOFJdnvYT8bntqgjSjIFbDQDylneiFy4zO+hmuJ25erToQVg2CqioSB iF7ILgbKnk5ZUoFfjRKruHp9jhagpMvZWbOv+93e17LH9jWtkQiFGhx9a8nHd0HwlYYY GhGactGj54wf2zKfcDJXTtAE4U7GEpJ8GrtMWTV1ExZpTgTohB+tOy9UA5KloUIUBP1F vjjlR1dfz9+tI79IU0AMPl0UR8beYHYUtCJfC/sKXsMkcOFaA+lo93kopyUhnYZZczRk aJ7Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=Zls2PjeN96MBj/tRd+drvu+9AaG+9o/48mGsjcvAGWw=; fh=KT/RgCfca34cYfkAIavEZTr5lzVvRRUnhlYLqa4znYs=; b=Cv7IBikBsK/p4KMTjQzWvFpZ1pq278LEabz3mHHAI268dY+yH8ZeD2Rxsxsvp49rBU VikQ0csWOVsmZfA7Mcdj31RdlXGMINn4CCwY27j9IeJ8e1pq4V1iTP2gIDI2rANulRkX DYzwQfB+mKlRGlo2xnccc6wtgKkDVmxjvUeb5KKSixMKT5SMr+hwQBbMuE6ab8nFn8SY Ct13YuEG6PtD8PATVE/Zzv073P0bKjrCiY1UhoVFu3wptMM8D7p9pXzhGeclCGHBCqoa Jurr5adlv8YDV72EQnP+B/WinGDWWBQ9pJsvLggyYljmWRXoc0hnc6lWowd/46aDt1Bi tNzw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kFirGuZb; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-211277-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211277-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f0d822702si414703266b.236.2024.06.12.02.36.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 02:36:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-211277-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kFirGuZb; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-211277-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211277-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8844E1F2162A for ; Wed, 12 Jun 2024 09:36:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 958CE16DEC9; Wed, 12 Jun 2024 09:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kFirGuZb" Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6977F16DEA9 for ; Wed, 12 Jun 2024 09:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718184999; cv=none; b=qUTmjf9QEkXXYOse1tOr84MQuHMx/+fkGGCEXMLs+tq4aqi2nxalITaN+ldUL6BgHzlec+s4JGB56+YahNG5xfL9KDHE2uptPrrrlPvnlSaaKEA+YF4k53rbazfEOHikLmd8+rsPfHuyE+oXPchcqUzqg74u7A8pSjFCMU5DvMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718184999; c=relaxed/simple; bh=1DBKN6+Dh1Qa+D6idOan20UzNrMjKS7NMiz55q78mDk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=olV4laoghnZGCIXe/8JXt9h/a4e+UihgAkybd0eXbWq6HWfD/oSFt7UK0qWgCgw6oOsh8jcNPt75/8NOa+v9qJF4YckXkUah6J/RotUgKgZkDfHdMaaOk28MQNspUBTZlBNKZ6R9XKKig6RGC9ZPzUCSHZIj3SuI0mV43tskN+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kFirGuZb; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5ba70a0ed75so1069094eaf.1 for ; Wed, 12 Jun 2024 02:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718184997; x=1718789797; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zls2PjeN96MBj/tRd+drvu+9AaG+9o/48mGsjcvAGWw=; b=kFirGuZbjujrg7Fksp0/wPZcE/6pjfgfw62j/0dE4c9rS2xG50O7L6e2UQHTL7SBNL Qu/FXbO3KtnpltMSnY4d/77N8zMZi9E2aRPsgONZ03X9jLh748eet/r9F4x7WJdUkvyY Wuem/N1aWtmI1HdOBFJdd31xA27NIAqvpBUoA/hrhMpy4EWyMrk47WOTP3CmtFpgrS40 qhTgnHLbXbLPyWfSUBSbhBD/8A4AH4hIo4qf/6+7A+9FAPE0gtPEad94yHwIOwsw1Yv+ wyyMIZ4bEJhmJhw8paR2LL+T/qYVx+VIxTIU6hoEJYVRuX8WQ5SmjaSX0XfUhzYWD/Uj kg8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718184997; x=1718789797; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zls2PjeN96MBj/tRd+drvu+9AaG+9o/48mGsjcvAGWw=; b=ij58/uhJKkADXRfAIB6hSWsLWI65Zk60pt/nL+gYrUXuMcutTN1SxBYNlgh6fFQNDs MNxQxO9sxUMXByadJgLOOuhOALNlFk/tZFS329Lp7cM1KGY/X/yT4EF3bnoWHr1QSA+3 mkmz5Lgxmqn40k5vLWwNkCJfdGPcAPc8fO2tzHEiry78aPVe6W07QkjKjfrPF5Xx5Ff/ pZZIVRLJKkNFpqefc2QgQEWdXZDriYPuVD36kbGHVBalUvP5JoU9Lk8dZOywilPoNjIh EbbgNexiyb+kLgO/eYoMR2kC99EOvncb9irt/E5GfmHxE2zWXEkFvHfFs/3epe1wibQO +XcA== X-Forwarded-Encrypted: i=1; AJvYcCXSvaOGuVNctWq7zoeTHv9yAyruNlhP6rN/R8s7DgAcSHJIBa7kMOoyxZ4jpFWUfOoqMeYQQT+vUeZaBjcqZhQfTP1MfD33xMXEFWbY X-Gm-Message-State: AOJu0YxAyoqdH7FaGSdx+U/yeT3AR/6AVvENt01TEGBlr8h8+Cmj2RPf OyRrEgPmeOJGzcf4SuLaIOVmsDSKMRKPA/AksPEs1V7o2rv2A5BeeX+raS9AveC2Arr9Odts8v+ 2+I5v40Dy1/MFiX7M/TxYMVDFfsz/8Hx8UitPNg== X-Received: by 2002:a05:6820:612:b0:5ba:bb77:bf51 with SMTP id 006d021491bc7-5bb3b9410a1mr1738733eaf.2.1718184996962; Wed, 12 Jun 2024 02:36:36 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240507-samsung-usb-phy-fixes-v1-0-4ccba5afa7cc@linaro.org> <20240507-samsung-usb-phy-fixes-v1-4-4ccba5afa7cc@linaro.org> In-Reply-To: <20240507-samsung-usb-phy-fixes-v1-4-4ccba5afa7cc@linaro.org> From: Peter Griffin Date: Wed, 12 Jun 2024 10:36:25 +0100 Message-ID: Subject: Re: [PATCH 4/5] phy: exynos5-usbdrd: fix definition of EXYNOS5_FSEL_26MHZ To: =?UTF-8?Q?Andr=C3=A9_Draszik?= Cc: Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Alim Akhtar , Sam Protsenko , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andr=C3=A9, On Tue, 7 May 2024 at 15:14, Andr=C3=A9 Draszik = wrote: > > Using 0x82 seems odd, where everything else is just a sequence. > > On E850, this macro isn't used (as a register value), only to assign > its value to the 'extrefclk' variable, which is otherwise unused on > that platform. Older platforms don't appear to support 26MHz in the > first place (since this macro was added for E850). > > Furthermore, the downstream driver uses 0x82 to denote > USBPHY_REFCLK_DIFF_26MHZ (whatever that means exactly), but for all the > other values we match downstream's non-DIFF macros. > > Update to avoid confusion. No functional change intended. > > Signed-off-by: Andr=C3=A9 Draszik > --- Reviewed-by: Peter Griffin regards, Peter [..]