Received-SPF: pass (google.com: domain of linux-kernel+bounces-211318-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 12 Jun 2024 12:00:40 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>, Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH] nvdimm: make nd_class constant
Message-ID: <2024061206-unleveled-seduce-9861@gregkh>
References: <2024061041-grandkid-coherence-19b0@gregkh>
 <66673b8a1ec86_12552029457@dwillia2-xfh.jf.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <66673b8a1ec86_12552029457@dwillia2-xfh.jf.intel.com.notmuch>

On Mon, Jun 10, 2024 at 10:44:42AM -0700, Dan Williams wrote:
> Greg Kroah-Hartman wrote:
> > Now that the driver core allows for struct class to be in read-only
> > memory, we should make all 'class' structures declared at build time
> > placing them into read-only memory, instead of having to be dynamically
> > allocated at runtime.
> 
> Change looks good to me,
> 
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> 
> ...changelog grammar tripped me up though, how about:
> 
> "Now that the driver core allows for struct class to be in read-only
> memory, it is possible to make all 'class' structures be declared at
> build time. Move the class to a 'static const' declaration and register
> it rather than dynamically create it."

That works too, want me to resubmit with this, or can I update it when I
commit it to my tree?

thanks,

greg "the changelog is the hardest part" k-h