Received-SPF: pass (google.com: domain of linux-kernel+bounces-211339-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 12 Jun 2024 11:19:01 +0100
From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.cirrus.com,
	alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs35l56: Disconnect ASP1 TX sources when ASP1 DAI
 is hooked up
Message-ID: <Zml2FfjbO4Vgk0jy@finisterre.sirena.org.uk>
References: <20240611145746.1454663-1-rf@opensource.cirrus.com>
 <Zmh3VmRfGEU6pGps@finisterre.sirena.org.uk>
 <36219997-397b-4a26-96ee-7527fb6eb024@opensource.cirrus.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ZyARGDXRBReq3B2w"
Content-Disposition: inline
In-Reply-To: <36219997-397b-4a26-96ee-7527fb6eb024@opensource.cirrus.com>


--ZyARGDXRBReq3B2w
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 12, 2024 at 10:19:06AM +0100, Richard Fitzgerald wrote:
> On 11/06/2024 17:12, Mark Brown wrote:

> > This doesn't seem particularly different to any other unhelpful chip
> > default, I'm not sure why it'd be so urgent that we'd hard code a

> I'm not sure I understand the objection here. Are you objecting to the
> patch itself, or that I marked it as a Fixes?

Both I guess, but mainly the patch itself - we generally have an
extremely high bar for setting defaults different to the chip defaults
to avoid issues with differing use cases.

--ZyARGDXRBReq3B2w
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZpdhIACgkQJNaLcl1U
h9Dpngf+J2Jih6an19izkqDx/DWBL+NSyvVWEBmPw/+20KHVMdXPbMmyFH0ncfiI
nVtt2Ojsf3LSykVxbutLUD7GfB3xrSICPfwEbgVuPuW9RQ7bxSz7y3YkIjSl6TpM
69xpoWaTLRbfN8UuXiDT7wcjGFhGLHPAgSlet+K1uJmSaSVZE5eR5ELfhjLrszsv
ic47Dn+txdqx2zfr+XKqBfJPk00mqGfRyOcsm7HMIi8L8tz1jIU32uagmgzEd61r
qVE0RB0DwCREK+AYukDi4+aVsaYHZRhpjLI+R5c/JKpoLRigvlr5UJ0pd9+GtUB6
PHV59zLfLQEvU+SyaON1qUDB+aN/bw==
=+MLc
-----END PGP SIGNATURE-----

--ZyARGDXRBReq3B2w--