Received-SPF: pass (google.com: domain of linux-kernel+bounces-211341-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240507133103.15052-1-wei.w.wang@intel.com> <171805499012.3417292.16148545321570928307.b4-ty@google.com>
In-Reply-To: <171805499012.3417292.16148545321570928307.b4-ty@google.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Wed, 12 Jun 2024 12:19:43 +0200
Message-ID: <CABgObfZCNN4AdzGavqzFANCLq4E5pi+h2+mr9-cysZrFk6bUzw@mail.gmail.com>
Subject: Re: [PATCH v4 0/3] KVM/x86: Enhancements to static calls
To: Sean Christopherson <seanjc@google.com>
Cc: Wei Wang <wei.w.wang@intel.com>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 12, 2024 at 3:23=E2=80=AFAM Sean Christopherson <seanjc@google.=
com> wrote:
>
> On Tue, 07 May 2024 21:31:00 +0800, Wei Wang wrote:
> > This patchset introduces the kvm_x86_call() and kvm_pmu_call() macros t=
o
> > streamline the usage of static calls of kvm_x86_ops and kvm_pmu_ops. Th=
e
> > current static_call() usage is a bit verbose and can lead to code
> > alignment challenges, and the addition of kvm_x86_ prefix to hooks at t=
he
> > static_call() sites hinders code readability and navigation. The use of
> > static_call_cond() is essentially the same as static_call() on x86, so =
it
> > is replaced by static_call() to simplify the code. The changes have gon=
e
> > through my tests (guest launch, a few vPMU tests, live migration tests)
> > without an issue.
> >
> > [...]
>
> Applied to kvm-x86 static_calls.  I may or may not rebase these commits
> depending on what all gets queued for 6.10.  There are already three conf=
licts
> that I know of, but they aren't _that_ annoying.  Yet.  :-)

I think it's best if we apply them directly (i.e. not through a pull
request), on top of everything else in 6.11.

Paolo