Received-SPF: pass (google.com: domain of linux-kernel+bounces-211351-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 12 Jun 2024 11:35:45 +0100
From: Mark Brown <broonie@kernel.org>
To: Witold Sadowski <wsadowski@marvell.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"pthombar@cadence.com" <pthombar@cadence.com>,
	Piyush Malgujar <pmalgujar@marvell.com>
Subject: Re: [EXTERNAL] Re: [PATCH v8 3/4] spi: cadence: Allow to read basic
 xSPI configuration from ACPI
Message-ID: <Zml6ARdI3ek6sVF1@finisterre.sirena.org.uk>
References: <20240607151831.3858304-1-wsadowski@marvell.com>
 <20240607151831.3858304-4-wsadowski@marvell.com>
 <ZmclB2CMhhkasiBw@finisterre.sirena.org.uk>
 <CO6PR18MB4098CD7676AA96B680FBC068B0C72@CO6PR18MB4098.namprd18.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Llmhg3KkfjprADEB"
Content-Disposition: inline
In-Reply-To: <CO6PR18MB4098CD7676AA96B680FBC068B0C72@CO6PR18MB4098.namprd18.prod.outlook.com>


--Llmhg3KkfjprADEB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 11, 2024 at 09:57:09PM +0000, Witold Sadowski wrote:
> > > These changes enable reading the configurations from ACPI tables as
> > > required for successful probing in an ACPI UEFI environment. In the
> > > case of an ACPI-disabled or DTS-based environment, it will continue to
> > > read configurations from DTS as before.

> > This doesn't describe what the ACPI tables are supposed to look like or
> > anything, it's hard to review this...

> There should be an example of ACPI table in commit message?

No sign of one in the patch that got sent, nor in the cover letter.

> > > +#ifdef CONFIG_ACPI
> > > +static bool cdns_xspi_supports_op(struct spi_mem *mem,
> > > +				  const struct spi_mem_op *op)
> > > +{

> > > +	if (!acpi_dev_get_property(adev, "spi-tx-bus-width",
> > ACPI_TYPE_INTEGER,
> > > +				   &obj)) {

> > > +	if (!acpi_dev_get_property(adev, "spi-rx-bus-width",
> > ACPI_TYPE_INTEGER,
> > > +				   &obj)) {

> > Why is this Cadence specific?

> So that part should do to generic spi? I think right now it is not
> Supported to read tx/rx bus width from acpi.

I think I meant to say Marvell there rather than Cadence.

> > > -	cdns_xspi->iobase =3D devm_platform_ioremap_resource_byname(pdev,
> > "io");
> > > +	cdns_xspi->iobase =3D devm_platform_ioremap_resource(pdev, 0);
> >=20
> > > -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "sdma");
> > > +	res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1);
> >=20
> > > -	cdns_xspi->auxbase =3D devm_platform_ioremap_resource_byname(pdev,
> > "aux");
> > > +	cdns_xspi->auxbase =3D devm_platform_ioremap_resource(pdev, 2);

> > This causes us to ignore naming on resources, that's an ABI break for
> > other systems.

> In that case acpi tables are not able to find resource by name. Or at
> least I wasn't able to find a way to handle that in different way.
> Is there better solution for that part?

Try by name and then fall back on numbers?

--Llmhg3KkfjprADEB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZpegAACgkQJNaLcl1U
h9Dhsgf+JGMmyMkLPPtsh9gB5SjSbo5EYx+U4yVYqbC/tIANoDeej74YxpaOYQvv
zmzu9dPxmcKMKlg4cqmonr0YGSt5HK1EnraoQlPTxKdW9ASi0MOweH3hhJZAv0HE
Jy8kPOTbN2FRtKicXyJVU3iaFIRNukZdgBSnqprHd+Ccm+BjMbCJHaewEAPGbr+l
jP+GqH81ZUu4oV2Fl/vWsSjJC4Pcc8YPyeYTKr2UZUf8KxiguTnmZJ2JxB24JDpe
IeedhN7NsbE+kwnCKMYdZc2NGY4SuDBpw2XbcBmSMrgma9rxqZ1nYVr9tktvPzIi
cNdxhE//NCF2xH2gON2twMd5jRQPXw==
=Z3zK
-----END PGP SIGNATURE-----

--Llmhg3KkfjprADEB--