Received-SPF: pass (google.com: domain of linux-kernel+bounces-211361-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 12 Jun 2024 11:43:24 +0100
From: Mark Brown <broonie@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Shuah Khan <shuah@kernel.org>,
	Muhammad Usama Anjum <usama.anjum@collabora.com>,
	Ryan Roberts <ryan.roberts@arm.com>, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: mm: Make map_fixed_noreplace test names stable
Message-ID: <Zml7zMzgBLEpMm8J@finisterre.sirena.org.uk>
References: <20240605-kselftest-mm-fixed-noreplace-v1-1-a235db8b9be9@kernel.org>
 <20240611152317.8e72edb3a545a685a2a0b395@linux-foundation.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="taj9yIMJlp9FRGvc"
Content-Disposition: inline
In-Reply-To: <20240611152317.8e72edb3a545a685a2a0b395@linux-foundation.org>


--taj9yIMJlp9FRGvc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 11, 2024 at 03:23:17PM -0700, Andrew Morton wrote:
> On Wed, 05 Jun 2024 23:36:12 +0100 Mark Brown <broonie@kernel.org> wrote:

> > KTAP parsers interpret the output of ksft_test_result_*() as being the
> > name of the test.  The map_fixed_noreplace test uses a dynamically
> > allocated base address for the mmap()s that it tests and currently
> > includes this in the test names that it logs so the test names that are
> > logged are not stable between runs.  It also uses multiples of PAGE_SIZE
> > which mean that runs for kernels with different PAGE_SIZE configurations
> > can't be directly compared.  Both these factors cause issues for CI
> > systems when interpreting and displaying results.

> > Fix this by replacing the current test names with fixed strings
> > describing the intent of the mappings that are logged, the existing
> > messages with the actual addresses and sizes are retained as diagnostic
> > prints to aid in debugging.

> This sounds fairly annoying and I'm inclined to backport the fix into
> -stable kernels(?).

It's annoying but more of a UI issue than anything too serious - for my
setup it just translates into not validating those individual tests and
instead only paying attention to the overall result of the program.
Personally I'd say that it reaches the severity where it might be worth
sending for v6.10 but not to stable.

--taj9yIMJlp9FRGvc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZpe8sACgkQJNaLcl1U
h9A3rQf/X65fpQaBQdsPSyX4tv50iov2KxXIBmL++mft/PrqcYvGNIQAtxXjeXQZ
Q5f7YQ4YcCHlUCjw3ic7zLPox1YNobi7ZBSCU/QvZ9YeWhA3/Ud8Q9CdYPKwx3ZS
xhK9NZpQ5WO2QOmtRfSLkdMCTnYV36oM4K4gb9duQOJtEZfh769/AmbVzLLnCoab
WIlqmwoMrkfMieNk+H8z/1i2jFWVTxHRiM73dMv6SiWCIjQbMixCXlOMvsf9bCYc
6Eol5gIsfEHmL7qbVi+d+MLC4uypLuA35Mtqvez3EGl1spWKsjV9NsxA2kD7hyVm
CE/qEsbVD4KHawxWtsoSbAT4PyHPfw==
=/+tZ
-----END PGP SIGNATURE-----

--taj9yIMJlp9FRGvc--