Received-SPF: pass (google.com: domain of linux-kernel+bounces-211459-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240611124405.63427-1-animeshagarwal28@gmail.com> <20240611200048.GA2966276-robh@kernel.org>
In-Reply-To: <20240611200048.GA2966276-robh@kernel.org>
From: Animesh Agarwal <animeshagarwal28@gmail.com>
Date: Wed, 12 Jun 2024 17:29:34 +0530
Message-ID: <CAE3Oz81AP-5RGK0Xef72XT3x4Je1tu223BMwk7-mzKrJWKqTbA@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: wlf,wm8782: Convert to dtschema
To: Rob Herring <robh@kernel.org>
Cc: Daniel Baluta <daniel.baluta@nxp.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, 
	Conor Dooley <conor+dt@kernel.org>, patches@opensource.cirrus.com, 
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 12, 2024 at 1:30=E2=80=AFAM Rob Herring <robh@kernel.org> wrote=
:
>
> On Tue, Jun 11, 2024 at 06:14:00PM +0530, Animesh Agarwal wrote:
> > Convert the WM8782 audio codec bindings to DT schema.
>
> Missing "ASoC" on the subject. Mark may not see it.
>
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> >  .../devicetree/bindings/sound/wlf,wm8782.yaml | 47 +++++++++++++++++++
> >  .../devicetree/bindings/sound/wm8782.txt      | 24 ----------
> >  2 files changed, 47 insertions(+), 24 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8782.=
yaml
> >  delete mode 100644 Documentation/devicetree/bindings/sound/wm8782.txt
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>
>
> This is yet another binding with no in tree DTS user. That's fine, but
> not what I would prioritize converting. There are several ways I would
> prioritize what to work on.

I'll resend this patch adding "ASOC" in the subject, thanks for the
advice I'll not prioritize bindings that do not have their DTS in the
tree.

> - There's a list maintained in CI of number of occurrences of
> undocumented (by schema) compatibles[1]. Start at the top (most
> occurrences).
> - Pick a platform (or family of platform) and get the warnings down to
> 0 or close. There's a grouping of warnings and undocumented
> compatibles by platform family at the same link. Pick something that's
> widely used like RPi or RK3399.
> - Prioritize newer platforms over older (arm64 rather than
> arm32(though there's still new arm32 stuff)).
> - Fix warnings treewide from common schemas (i.e. from dtschema).
> That's not conversions, but related.

Thanks for the tips. I'll work accordingly.

Animesh