Received-SPF: pass (google.com: domain of linux-kernel+bounces-211493-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 12 Jun 2024 14:38:05 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Zenghui Yu <yuzenghui@huawei.com>
Cc: Sasha Levin <sashal@kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Haimin Zhang <tcs_kernel@tencent.com>,
	TCS Robot <tcs_robot@tencent.com>, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, x86@kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH MANUALSEL 4.19 1/2] KVM: x86: Handle SRCU initialization
 failure during page track init
Message-ID: <2024061239-tinfoil-cryptic-e638@gregkh>
References: <20211006111259.264427-1-sashal@kernel.org>
 <0fd9f7e5-697f-6ad0-b1e3-40bd48a8efae@redhat.com>
 <9acccdfe-b7d8-b59d-7b00-d5a266b84d36@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9acccdfe-b7d8-b59d-7b00-d5a266b84d36@huawei.com>

On Wed, May 29, 2024 at 04:29:32PM +0800, Zenghui Yu wrote:
> On 2021/10/6 19:23, Paolo Bonzini wrote:
> > On 06/10/21 13:12, Sasha Levin wrote:
> > > From: Haimin Zhang <tcs_kernel@tencent.com>
> > >
> > > [ Upstream commit eb7511bf9182292ef1df1082d23039e856d1ddfb ]
> > >
> > > Check the return of init_srcu_struct(), which can fail due to OOM, when
> > > initializing the page track mechanism.? Lack of checking leads to a NULL
> > > pointer deref found by a modified syzkaller.
> > >
> > > Reported-by: TCS Robot <tcs_robot@tencent.com>
> > > Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
> > > Message-Id: <1630636626-12262-1-git-send-email-tcs_kernel@tencent.com>
> > > [Move the call towards the beginning of kvm_arch_init_vm. - Paolo]
> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > 
> > Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Sasha, will this patch be applied for 4.19?
> 
> The same question for the 5.4 backport [*]. It looks like both of them
> are missed for unknown reasons.
> 
> [*] https://lore.kernel.org/stable/20211006111250.264294-1-sashal@kernel.org

This was from 2021, quite a while ago.

Can you please send them in backported form if you feel they should be
applied?

thanks,

greg k-h