Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp423610lqp; Wed, 12 Jun 2024 06:02:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW6PmKDmYSq43kb3IuFfSJ70oxLvYe6NT9LRuMIx2yXQQMycqsp5VeV3OjVAQYxd/fXye3dSDSkz31kR5stuO+W6iJZuye7SUG6Je1bvw== X-Google-Smtp-Source: AGHT+IFst8l+Qy6ioW1gjn3E0ICuLZKvEl42U7GaaM4FziNU6C5RWilvqpcO3LCT3freS3v2z7PD X-Received: by 2002:a05:6808:2390:b0:3d2:1bbf:5b5c with SMTP id 5614622812f47-3d23e11d6b7mr1893513b6e.52.1718197369129; Wed, 12 Jun 2024 06:02:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718197369; cv=pass; d=google.com; s=arc-20160816; b=fOBoymEC6guovKGLP7q/qpLZ68uAzsqw5RiFciK73b4g2V1GzqJSjyFDKsqfTqD1Bp PnCf8LLBmMFMfiYLMjHKUfS27cBef1OnukYvIOv5ddQRcgMHCR2CA9TBV52GBI3fnos8 zcoy6OCpY5wE+F56ZVj4mBXNSlenMGswW+yy+e8oXvsIUaeemkAO8DEMsp56RlAG809K A78zu/v5RkyqyJLDgBnV8Ak/u5GhQbVKiSXrIwF1gwiq1X9qQVAdg05OqP+8nAh3wUEa m8OAujNyl1Ie6omiuhFXKoVDNZOrAtzQGea7qI63PCkOVJ3LaGnFaDKm1lKwQpZJJEwm yx3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=BwY4nSRSiX50ju27Za2AyFCW3MElQCLsQ6xaBJsijxc=; fh=/Vo4AQewFLa8PogH68B9jgTyNCMaUnwYCmCw7UncurI=; b=h08EkWdxYkQzqgcMxTz0gu+bJThYQ72OdFCzwsnaEY/UkYIKuniLWcYDYhbOhwsA9F 2cw+hLuwh7FRD19DJQAy3lhWS5k77y8bHPLOR7vwWaCIRrmUUyl2K4PhbTb8MrMoEp0T CDYS8I9OcB2UFB0oSBvqfGDjoCg4Mva0XsgH5DgcXju/nHYCMXrX3IFCQ5PtmPw0VG44 VelkJFrP9O68jTvcxMz6HZo8MKkJ+Hs+Wxp4DYV41cx0iG8uCz4Ji96Gs66RLIJbtcJq tZzyl+TrFU09jOWlGjUTvC2HrIloNSUiWjg2HfNHF45VwBprnaIfOmSvdb5cbI4+Q/uQ VXrQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=JPrjh55L; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-211526-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211526-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 5614622812f47-3d22aa143cesi2322697b6e.179.2024.06.12.06.02.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 06:02:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-211526-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=JPrjh55L; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-211526-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211526-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 482D8281618 for ; Wed, 12 Jun 2024 13:01:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B134917799B; Wed, 12 Jun 2024 13:01:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="JPrjh55L" Received: from mout.web.de (mout.web.de [217.72.192.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99BF51D54B; Wed, 12 Jun 2024 13:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.72.192.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718197296; cv=none; b=LSagSaK23LoISOVq+k6fOLMegbx8/3vrl5NRi8Un5mA4Yvo325dAmNqTjAcENt5RIir+V0kCeO4PCSVA5HU9yNWzE4Tkv32BflLIK+UvyQvSm5MDIrNmd1UbCACZPIdnORfeDboNvymDR7Iu9owmw16V32tdQ+4+0Tog2K+PFbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718197296; c=relaxed/simple; bh=zvAIszmpcFoCCqGgeL8SEkY+l0lBODeG5GimiUkldMo=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=B6JSFXi5m+Ydkalf1E/e0law1VDceLVnRNDmwLchVr8cHlUVpBpD62zFQF7aaFK2pKRt/DrZx6QTxFmoPwO1hDwrIKouXcrCET2sp9ofvEXDLKe29ndj/bmYJAeFJidPB9cbBvwsAxiOuWNgSkJhXdVagXSguJaucfG6lGb9ld0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=JPrjh55L; arc=none smtp.client-ip=217.72.192.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1718197276; x=1718802076; i=markus.elfring@web.de; bh=BwY4nSRSiX50ju27Za2AyFCW3MElQCLsQ6xaBJsijxc=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=JPrjh55LO+dxTZjj21wMYg3xiu9w7RBOaSXLfnU8bIPCA0VqTfIQ185bYvtM1iol mZFUzLMC3cDGVHI5dqYYgMkcYSnW3kD/kq31g6gXL07VsgZwuMEoGmmKs63YDPVZN uo677SeOwfawn5f2neNjn7pfG0DeBxlkZ0CfaO+I5irzZDMyXFk3gCcn6rckDoQCA 2taw6N8uPZEJZuseOrLOS+qI774N5Stk3RNiRiwygX1mvoU8S9WMhoxIuKHAYCkql 7j2QucVAs/0yb/qXI+1YcNhvbPw7SROVkxIb8ilT93Pkp90WTJdCk9TAc5wcMxbjZ 8yqcHFOB+VOkQg+H0Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MrOdp-1snQpn1h8Z-00hTcV; Wed, 12 Jun 2024 15:01:16 +0200 Message-ID: Date: Wed, 12 Jun 2024 15:01:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Dmitry Baryshkov , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Daniel Vetter , David Airlie , Marijn Suijten , Rob Clark , Sean Paul Cc: LKML , Jessica Zhang References: <20240522-fd-hdmi-hpd-v2-13-c30bdb7c5c7e@linaro.org> Subject: Re: [PATCH v2 13/14] drm/msm/hdmi: ensure that HDMI is one if HPD is requested Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240522-fd-hdmi-hpd-v2-13-c30bdb7c5c7e@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:JRdxdNTKqwkPpdYHwCiY6ep2u1eBuqO1NgxxppYIp17AjPPBzuw cvqSW4biK6afYfDJpAkcryzdJtThijQ/JmvKbJRmezyhqvnUcIjpJSh8Awvl64YzN/R/3da waq4hkAI1Xf2TglE8x/iW6MjZZWDv66lVCbSXpS2wDBXJbbEJG494ssoeZElM/tVoWisAoN 6tosNrlDwndP8zHuhDfLA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:AJCm5eap5Ig=;9lGpNi+gbaFG6EiXvJ3wkCk7JXB T2+R0qkNEqqg81INQJBDAzc9TSAO47fxhO0vnWNfYf19zyHQqgdtTRlEaUQGtYhq1CSzAkxU6 WZzQEjLw8gkTnWmIGF8/Ypg8NPoG3TdQACVMeTlCCbtcNc2ip+QmfZ7rku4gFtkaZOyiny54+ UxdxASOVNoXDesCEb14JpxDU2Idfyo3NSjIeB6uA9AKV8n90ffJM3CH3yuRsfRQ5NT29zg4EQ EyLWgTQ425+W7OkoXa3TSgtUBcYFylHCkyKH4ApXmZmaXz3ArSqOUFMHbbMI6SlXq1YcZjzXG ThzCIf1wUAyhqjHJA5jEqE3MkOVhvK2mmyVh8J2n21NCZFL1ArJd0txyow8OUibdDe8Ww9aF/ UZut3GM9bUzmMnGThnHy/A2LkGdttUdrCL6uwJPoz23Mr+RqZqsfzI9cvBG3yccr371vPMziF /GBbX0xRP7zlkIx41ARhf3+3VhRg2+sLIq3offXuFE/GZitTT00q0FCRjNUsmRPj2mxICQ9sh 8vngs5FfbP7V9PMthLyu0d7bZFFlalsYq9Wijda/1nA5UTKF9j5onWyhnLF9/Gt7fpbj1zHCm Th7j5l+u22XxNJ0f/VovXpt6P0YndPYKUEiOshlwSRzJrTZ14TEanxpGcm//h2K3djxGDSrA+ TkTyu4xswONWjFNlCyJTpQUt+qcjrmK8tlPJSQCOSjjPQtcX0CWZARFEtH98pR+icUTNsMZvg lgXIvCvMe7oZzl+9584Rr8pdQvHNawvukYTyXPNmGO8czg3pv7Z6L/vDp+ea9xV7f8zLJFX85 PdP124xy8JCE/ujW1BYwiXaevsFJknGRTVsEG6GEyk3As= =E2=80=A6 > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c > @@ -117,11 +117,13 @@ static void msm_hdmi_bridge_atomic_pre_enable(stru= ct drm_bridge *bridge, > > DBG("power up"); > > + mutex_lock(&hdmi->state_mutex); > if (!hdmi->power_on) { =E2=80=A6 > } > + mutex_unlock(&hdmi->state_mutex); > > if (hdmi->hdmi_mode) { > msm_hdmi_config_avi_infoframe(hdmi); =E2=80=A6 Would you become interested to apply a statement like =E2=80=9Cguard(mutex= )(&hdmi->state_mutex);=E2=80=9D? https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L1= 96 Regards, Markus