Received-SPF: pass (google.com: domain of linux-kernel+bounces-211546-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240611-dev-mule-i2c-mux-v3-0-08d26a28e001@cherry.de>
 <20240611-dev-mule-i2c-mux-v3-2-08d26a28e001@cherry.de> <171811272875.1782775.2673232019553624734.robh@kernel.org>
In-Reply-To: <171811272875.1782775.2673232019553624734.robh@kernel.org>
From: Rob Herring <robh@kernel.org>
Date: Wed, 12 Jun 2024 07:17:51 -0600
Message-ID: <CAL_JsqJ83sz5-MZN+Cv6=AbLXWxAaYayw=k0_X=F2AAxU1j2Gg@mail.gmail.com>
Subject: Re: [PATCH v3 2/7] dt-bindings: i2c: mux: mule: add dt-bindings for
 mule i2c multiplexer
To: Farouk Bouabid <farouk.bouabid@cherry.de>
Cc: Heiko Stuebner <heiko@sntech.de>, Andi Shyti <andi.shyti@kernel.org>, 
	Conor Dooley <conor+dt@kernel.org>, Quentin Schulz <quentin.schulz@cherry.de>, 
	linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org, 
	devicetree@vger.kernel.org, Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org, Peter Rosin <peda@axentia.se>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 11, 2024 at 7:32=E2=80=AFAM Rob Herring (Arm) <robh@kernel.org>=
 wrote:
>
>
> On Tue, 11 Jun 2024 13:43:53 +0200, Farouk Bouabid wrote:
> > Mule is an MCU that emulates a set of I2C devices which are reachable
> > through an I2C-mux.
> >
> > The emulated devices share a single I2C address with the mux itself
> > where the requested register is what determines which logic is executed
> > (mux logic or device logic).
> >
> > Add support for the Mule I2C multiplexer bindings.
> >
> > Signed-off-by: Farouk Bouabid <farouk.bouabid@cherry.de>
> > ---
> >  .../devicetree/bindings/i2c/tsd,mule-i2c-mux.yaml  | 80 ++++++++++++++=
++++++++
> >  1 file changed, 80 insertions(+)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/i=
2c/tsd,mule-i2c-mux.example.dtb: fan@18: '#cooling-cells' does not match an=
y of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/trivial-devices.ya=
ml#

You cannot add warnings. Please fix this or this patch will never be
accepted. Either drop the property from the example or add it to the
binding (by moving out of trivial-devices.yaml).

Rob