Received-SPF: pass (google.com: domain of linux-kernel+bounces-211679-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 12 Jun 2024 10:36:46 -0400
From: Frank Li <Frank.li@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	imx@lists.linux.dev
Subject: Re: [PATCH v4 2/8] dt-bindings: mmc: mmc-spi-slot: Change
 voltage-ranges to uint32-matrix
Message-ID: <Zmmyfna+DoAcYzHp@lizhi-Precision-Tower-5810>
References: <20240611-ls_waring_esdhc-v4-0-d0d8a5b3f3cb@nxp.com>
 <20240611-ls_waring_esdhc-v4-2-d0d8a5b3f3cb@nxp.com>
 <20240611202311.GB3003237-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240611202311.GB3003237-robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?oWDPmcHdEWq6jqhndtWVkUA+5turB6L1K30P/TY2TrHtH7cKG3TrkH1GJE0S?=
 =?us-ascii?Q?53hfCUxZfxh6fEW4Mn6Tsw6dTlWS2LK33Mh/r7S3D3a/t59PjHD198pGlmyQ?=
 =?us-ascii?Q?H1bwBFAstMa46zNXLHqBaSyJ7fG9/Z3R2sG8vvcGDL/sPA6sAPfDjurgFVL0?=
 =?us-ascii?Q?lBnLpcbjEHf60I/qr8D/47PhkMCCw8DwpyGOJ+VeQ5cUrzNOhNojoQ3Rqgqo?=
 =?us-ascii?Q?DoT2WAdTEty+tl3FbsDwbqyRMyRzxNE5x9nPMdw7AzOi/6NJSbtpDzjnZ5k8?=
 =?us-ascii?Q?eUxzPTnpGPuQz9kDQ2kvj4HPsp0fegUn11nILJAiRrQpPi28nUm+GucZyCoD?=
 =?us-ascii?Q?whcA6j5lKQYmtLyy8NdONdkAoJjpCLDDUFEiMX/VmCiSyOKWMC0ZCJqj6UU2?=
 =?us-ascii?Q?Bk0nOtBUFGiJx1Bn1ZzXJEB602cdxVVqJauSQ+BLIDUu2xgPyDA0DZZoBQqj?=
 =?us-ascii?Q?bHUaQ7AN3lODNmVznAVTU/aEetn6UbpgnkmCVq9UOvI0pOGebFxloUr5bren?=
 =?us-ascii?Q?JTtpAsUYZ2EDfcEb1hPFqLlB03g49aVPIijPCIVM2lwQ4aInQ4VeYhEwHrgx?=
 =?us-ascii?Q?7nv+PO8doqYKBfGTT6L1Luk5wUTG542WsCRQ9pjQDFMhTNAejx38dp3VHJEh?=
 =?us-ascii?Q?65chaDhDN8CxlTzHVd7lqNRxpXihh/cKONdJTbra1dRKAehoBmBP6/+9Yn/x?=
 =?us-ascii?Q?INH0MPKwlR6Vq7JkwcqntoBjUxVdQNGq5T9lRAsxO8duYkmGGrAlheDEqOMd?=
 =?us-ascii?Q?gIuY1rTSN9oM1zxsak985uq3qshfg/+pJoupX3JyMKUSo4JeTJ0ncru4rZAM?=
 =?us-ascii?Q?4hucO3dcUCdJu84JVeqG1G/ERBC8Cya6EsGrwq3w3LdokoTZrvwiGAN356lg?=
 =?us-ascii?Q?GJ/1hCJog3R8wRMvGHpNtNDmLLGKwDDQWv6TPDTIOgN5M3/onl61+CI9t2oo?=
 =?us-ascii?Q?ZdSICAprBQfK06F0LbT26NuCZKGIlCnP5OKSH3Dz5k3ZlWmcRAyFN3Yw/R5d?=
 =?us-ascii?Q?t+OeE7RBzYolBm11NEjcyA5HdxY10Zw62ZSxDl/uG7olzys7apwOP+Uh6+hp?=
 =?us-ascii?Q?GLZ8c3tPLdcfXGAFWk9sIDbeC3C6xm6KOD70fHI3bugETq98q6LndmWKC99F?=
 =?us-ascii?Q?Vuk9aXg6nKvpfCOaGrpZ4QhAg1RzC0f8HhEkl+vPNrVw6qPBxxUpiEobIKij?=
 =?us-ascii?Q?TcHCm0kBIsPnbXPYa0LAt+lR5n16e3PBbFX5ImL9QoCYOZQrlRkxaneq71iF?=
 =?us-ascii?Q?ZbVl3tHQTlJG2qCJyHge6upq7zDHVMn/eFsQtlLdjJGXQO74fCeoj2Ri4bBS?=
 =?us-ascii?Q?tVBfEFdBCdPTLJ+TPTlGsha6ygeFzvh8ZoSjcqdTOLmcL70DqabQp5yqqeEt?=
 =?us-ascii?Q?pHHSasFJTLHY1CnBNy23FWgzTHLoYeiMVg13CTgg9oLxxmI5BskHMIKpuhp8?=
 =?us-ascii?Q?hOawCLyKMFTocSHyqntrSaTPZ5K74x1qqp+28fJCETm7kAB08u+Dtz0cheHx?=
 =?us-ascii?Q?MENeZc/KX3g24XVeVCDtXzAy5/evnb6ZZ/hg+l+fwYPz2c1dQy6qjBCiZ454?=
 =?us-ascii?Q?3lq463wpVbyfCT7PVCs9NjtVRdnigMukr5oRhVtq?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 124be509-f42e-45f9-bbb1-08dc8aed1b4e
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 14:36:55.1091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7/a+0hQjyWrNjdI9Cf+fidvJM5UU8zorjLA+2gZ+vA8YzkSX5RYd/c3+ph8pQJKjm1dQ+Ya2Im08XSl0aIo26g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8218

On Tue, Jun 11, 2024 at 02:23:11PM -0600, Rob Herring wrote:
> On Tue, Jun 11, 2024 at 12:01:47PM -0400, Frank Li wrote:
> > According to common mmc core, voltages-ranges should be matrix.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > 
> > ---
> > Not sure why it impact other mmc yaml's voltage-ranges.
> 
> It's a quirk of the tools. When decoding properties, the tools only know 
> all possible types. Types are global, not per binding. Sometimes it can 
> be figured out, but cases like this cannot be.
> 
> > ---
> >  Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml | 17 ++++++++++-------
> >  1 file changed, 10 insertions(+), 7 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
> > index 36acc40c7d181..05815b837219d 100644
> > --- a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
> > @@ -27,17 +27,20 @@ properties:
> >      maxItems: 1
> >  
> >    voltage-ranges:
> > -    $ref: /schemas/types.yaml#/definitions/uint32-array
> > +    $ref: /schemas/types.yaml#/definitions/uint32-matrix
> >      description: |
> >        Two cells are required, first cell specifies minimum slot voltage (mV),
> >        second cell specifies maximum slot voltage (mV).
> >      items:
> > -      - description: |
> > -          value for minimum slot voltage in mV
> > -        default: 3200
> > -      - description: |
> > -          value for maximum slot voltage in mV
> > -        default: 3400
> > +      items:
> > +        - description: |
> > +            value for minimum slot voltage in mV
> > +          default: 3200
> > +        - description: |
> > +            value for maximum slot voltage in mV
> > +          default: 3400
> > +    minItems: 1
> > +    maxItems: 8
> 
> From what I remember, SPI mode doesn't support voltage changes. 
> Switching to 1.8V came much later in the spec. So it should be 
> 'maxItems: 1'. Or better yet, make the outer 'items' a list (of 1 
> entry).

I don't understand "make the outer 'items' a list (of 1 entry)." Can guide
me how to write it?

Frank 

> 
> Rob