Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp496017lqp; Wed, 12 Jun 2024 07:48:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVn2DEEbexRZ564+rZZtrLacjFHiYfh33wYZ5EcFFayfvcbQiGCbYBvhd++p35fczKHWFauzDyzg5aT4Joz3jdO0wWm5NmIX2E/AZYlFw== X-Google-Smtp-Source: AGHT+IFA1f/K6MW+/6FKspLS657aniV2qlIilc10/mMD0wkhRioRRs3aPLqKnkdTXua6uJNMbPFn X-Received: by 2002:ac8:7d06:0:b0:43a:d064:5118 with SMTP id d75a77b69052e-4415ac74626mr21355691cf.64.1718203738572; Wed, 12 Jun 2024 07:48:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718203738; cv=pass; d=google.com; s=arc-20160816; b=zQV0TIFK2nF/y0vnX2JEsbi5FXI9bFPBM6bmO791j2S3wgiVLfGjHi9BpJC8tEg4Oz badUf+IPI7o0pQ6TAO6Gxc+17YeRMMpE6yAluE1ebK/147PEYZrkcuYae44bGskOVM0K gys00a4ajzXDeN6ZB4H8hnTj2ImzBrFF8s40Xn6ne7JJ0hXWHkKRyQgi5jLbxC8eDMnA nDYSwKNLB1GE6bcsCCTFiYtL2RQ+B9JCbUsc1luXy956gu2Jhuz/4sRjpML4tazfsQbV yR82pkEyuuGt5o1lg/slr9SroZCNW19uX1r2te9pvSKjuMIAWd+V3BB7F1yj42VjV7l7 otCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eb+oJNJrw1FNwQ5bOtgRiw3PyvXDpLn2bjuulj/9bbM=; fh=NzwMMa8QMwKUxWqOdm3Npk7z/Ugjrc8Wwm2Hb0EYXrg=; b=md9zfEtII7vKGp8v5bSNvJPHrJv4BuiquetclBjsKin9KgQXvjjBsGaUZw7e+rUYSL 25x//XLik0PUg9LIYcPinQLpBQ7a/8QCS7ARNe9caGMTWKfVYG0mnedH5NmotWU6wWwU uM3HB87kucnLeUQtwWb+O7peddq2rxO4pW5Xb56Os8E0BxRezn4SZOoBBuhdiFdtVisl 2IUeFFi0YKkmISgsuMrzW/rXSAV7ag0Tb6Ww7pRRNuaGGdJWV4r5QQ3HZpmALwnlNUsc iHzqgSOicAXPmXrp+yByWW1s2mzXHLNZM2bZiwn7oLO0NXpQLFMa6sRz3zxyzuW969Po klVA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AUhSppyo; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-211701-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211701-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-44038a85f8csi155275761cf.194.2024.06.12.07.48.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 07:48:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-211701-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=AUhSppyo; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-211701-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211701-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4B6C31C220BB for ; Wed, 12 Jun 2024 14:48:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 665CC17F4E4; Wed, 12 Jun 2024 14:48:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AUhSppyo" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 793101E504; Wed, 12 Jun 2024 14:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718203687; cv=none; b=bN1HT8lVYZKdr/WqQqB1+JLy/g19kASDxmEcCoJubDHA7V+APbVB96xWFDBQjzRoGxmbpWfMxvfn6mPWi+dZMD6LWVUsaw/5JN+Rl7xl2iqq5iFwETM5JhKXzl32qy0GMYdxYoemio/Xpxo9FSWFa8RWzLcM+6P70oDyDiJeM28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718203687; c=relaxed/simple; bh=gIuOYfz93n8dSbxaF6xUILMdMtwvKuPRkUX+zeecAKU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l1LFb52wmKrMpqKM2PGaBWUkp/mnk2UOCOmadpbw+YG0eRvxkioetw0d19ZSSK3oIgBLGFW1loNnAu3WM0XHV1ZMXmm1KaAgQVoi9QYbxT/SpHInRJQHqYfenJZlGjUHB981uahcu8E8gQdZBOZSD3dK+4JqACiSSa6/w5WOHnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AUhSppyo; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 695EEC116B1; Wed, 12 Jun 2024 14:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718203687; bh=gIuOYfz93n8dSbxaF6xUILMdMtwvKuPRkUX+zeecAKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AUhSppyowsRAhKMbeg3vEuP/5Y45fwXYI0mxxW89h4nOx5NS7rF4pWv/SYGu/CW21 AC7eO/BbZKnj+y2vlp7UDvV+yOKgzjVqTWHQYnpKnpCgP+cDbS7KEFG8p1Dmw9DcAV /U9rCCoifJGVK1kWKk24zcNge8Hqn/D3TIZO32uo= Date: Wed, 12 Jun 2024 16:48:04 +0200 From: Greg KH To: Kuntal Nayak Cc: stable@vger.kernel.org, pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vasavi.sirnapalli@broadcom.com Subject: Re: [PATCH 1/2 v5.10] netfilter: nf_tables: restrict tunnel object to NFPROTO_NETDEV Message-ID: <2024061254-crayfish-gory-e4b8@gregkh> References: <20240607213735.46127-1-kuntal.nayak@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607213735.46127-1-kuntal.nayak@broadcom.com> On Fri, Jun 07, 2024 at 02:37:34PM -0700, Kuntal Nayak wrote: > From: Pablo Neira Ayuso > > [ upstream commit 776d451648443f9884be4a1b4e38e8faf1c621f9 ] > > Bail out on using the tunnel dst template from other than netdev family. > Add the infrastructure to check for the family in objects. > > Fixes: af308b94a2a4 ("netfilter: nf_tables: add tunnel support") > Signed-off-by: Pablo Neira Ayuso > [KN: Backport patch according to v5.10.x source] > Signed-off-by: Kuntal Nayak > --- > include/net/netfilter/nf_tables.h | 2 ++ > net/netfilter/nf_tables_api.c | 14 +++++++++----- > net/netfilter/nft_tunnel.c | 1 + > 3 files changed, 12 insertions(+), 5 deletions(-) Both now queued up, thanks. greg k-h