Received-SPF: pass (google.com: domain of linux-kernel+bounces-211710-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 12 Jun 2024 10:54:04 -0400
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
CC: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza <jose.souza@intel.com>,
	<linux-kernel@vger.kernel.org>, <intel-xe@lists.freedesktop.org>, "Greg
 Kroah-Hartman" <gregkh@linuxfoundation.org>, Mukesh Ojha
	<quic_mojha@quicinc.com>, Jonathan Cavitt <jonathan.cavitt@intel.com>
Subject: Re: [PATCH v6 1/2] devcoredump: Add dev_coredumpm_timeout()
Message-ID: <Zmm2jC2nx6gZ2WOn@intel.com>
References: <20240611174716.72660-1-jose.souza@intel.com>
 <49c2fbdc91d128c5249d50d016d97c8e5162f7b7.camel@sipsolutions.net>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <49c2fbdc91d128c5249d50d016d97c8e5162f7b7.camel@sipsolutions.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?iKXhzV15X9V6WMoOfyp16fcywUfe5XHpxpILq+sJkkEXNWwfzjAJkvGFBF?=
 =?iso-8859-1?Q?tGMdIFOgREQ72JYWu0FCNepG3Yp+S7bj2LmFeFd1gZBoctrx8k55FMu4XR?=
 =?iso-8859-1?Q?LFKo++U4qkjnMmRv822pZ2UU4/cZnmRHN6yf9pBwPcW9Z0qNcSr7mVtXEY?=
 =?iso-8859-1?Q?3s6Q6VQR0V5UFvLsONCpztyLai7FjmmvD4qSF9gg0+NSEYQVGoRblBOUsP?=
 =?iso-8859-1?Q?EaVmQz1CD9Ia1QoZRlDMbxKZGe5lz0GR4enIJCKfBNRylMbG9AwFClDJTN?=
 =?iso-8859-1?Q?HRWwvTGiGkHBzDaC9u2uIG7TM7UpPxew7JWaXbHFXHgyv59tJOHlT7kouU?=
 =?iso-8859-1?Q?mTcGCrP84RnJyvCcnw+aTmNx0PdYe8vBAdWKOpbk27oO1ARVUN8p0tFSkC?=
 =?iso-8859-1?Q?WBj/vanhqTlUZSgYLdFBGQkX4DRH8c2QFWAtRryf8Z0kFftQ9sdSdMONX6?=
 =?iso-8859-1?Q?KR51EfOTE9mZch7huTPWK67jXEYhB6WYeouwGYmL2rmOQNGwDL/GcabvFV?=
 =?iso-8859-1?Q?bPHaEGLn/T/uwtZI4eayrJuKskMC7WoTLTI6XkrzKj4DfYhBtXcW3xSvYa?=
 =?iso-8859-1?Q?OdndH8Kvyn+GLqNFUnC8WXBwqeIddqnKFCclYLfE8KpwrQhlvFdihZr6/K?=
 =?iso-8859-1?Q?bT5JRUtagmJWn8BSikBl9itZerkYK/eYTCADMICKf5tNfSHtn6kBom+4bl?=
 =?iso-8859-1?Q?R8dUf3A/Z2TanBj3pWQhB7zXQrS7qjQbGNucftZgv7K709cNJkNePcnppm?=
 =?iso-8859-1?Q?Nr/m0BASYL4zRaEEhkExJt7MjogHbUtrWyRx5G3K19JKeVdd7hhhY/7qZQ?=
 =?iso-8859-1?Q?1C7N5un3LYQWb4lkUZ4+Z6jNhcVr3uEGksGdLYZ+/rY7UaEgZwAojDz0+z?=
 =?iso-8859-1?Q?dKH1i4DstKUfkO/AMKhxVqMQ5B4yQTFyRnHlT305l+UbaloCzs9deSuCPX?=
 =?iso-8859-1?Q?vPJk7pcd0NFm+oatXYLSUhCoX7dGuPmtAiZRBRIgHgKZb6M5zj1qKaMTjJ?=
 =?iso-8859-1?Q?I2zwSgxMJWC1zSGvaJOengwb8oLlANVbCtoubAP0BMNdHki1to9a7et4Uy?=
 =?iso-8859-1?Q?emBiq7jTRD4gU3MPLrAD9ee7TCOhuyW3DZwFOldg8AMybrhWlljr7BzhOg?=
 =?iso-8859-1?Q?PQ4iIktuaHn2RUwM1NhRGMFAks5U6JPuV/SeAHVtWq6sclcJZaqOBAgUCT?=
 =?iso-8859-1?Q?GG+Msb0eZWM/v91lGJLtXAWizRujvx4GwgH4UKjCey1dyrKjItuV2dKKPf?=
 =?iso-8859-1?Q?zGRHocg/pXvZcpVqLhQbHjfVNCNc6lHReFUY8JhKQO/Q0mSIVQb0VlPe1X?=
 =?iso-8859-1?Q?QFgPwHc564kO5efYK8WoXpIa4Iuy3pi9+FoExZplFmR/4QzPb8y7G3kVHa?=
 =?iso-8859-1?Q?DUNmlN1M7CMIJdmm/e3xo+5bgeUpRXS6+SAy/kUSF95yC7/9naa60Vo4r8?=
 =?iso-8859-1?Q?0yZj54szfLfndv7WQ40WEFyUK4fwHcRAGAYnKYb16sOabZ2YtdmGTlIoaH?=
 =?iso-8859-1?Q?vwJ8eh+MKs0RXmcQfGhLKOpwxFLiIbq8+R88SFiAE37STh7UGJiryTGlQE?=
 =?iso-8859-1?Q?WoBVOKSurSF65RuMtlzGUKFIlTub2uzatw1lupFUMBRfglpZlbgwiBuz8O?=
 =?iso-8859-1?Q?Yc6Fd2CTYGGvJfQLfc02fFYQQ8UPntrjxg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d0b4289c-7636-4066-0b47-08dc8aef823c
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2854.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 14:54:06.9526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KLyq27WYmGxf0Fi8ZMl1nCxXA3cx1whbVSbF4oY9CIBj9rdzIQwUFmaEpei63dTegfESnnIdYZDkyHMOleLjZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5006
X-OriginatorOrg: intel.com

On Wed, Jun 12, 2024 at 02:02:37PM +0200, Johannes Berg wrote:
> On Tue, 2024-06-11 at 10:47 -0700, Jos? Roberto de Souza wrote:
> > Add function to set a custom coredump timeout.
> > 
> > For Xe driver usage, current 5 minutes timeout may be too short for
> > users to search and understand what needs to be done to capture
> > coredump to report bugs.
> > 
> > We have plans to automate(distribute a udev script) it but at the end
> > will be up to distros and users to pack it so having a option to
> > increase the timeout is a safer option.
> > 
> > v2:
> > - replace dev_coredump_timeout_set() by dev_coredumpm_timeout() (Mukesh)
> > 
> > v3:
> > - make dev_coredumpm() static inline (Johannes)
> > 
> > v5:
> > - rename DEVCOREDUMP_TIMEOUT -> DEVCD_TIMEOUT to avoid redefinition
> > in include/net/bluetooth/coredump.h
> > 
> > v6:
> > - fix definition of dev_coredumpm_timeout() when CONFIG_DEV_COREDUMP
> > is disabled
> 
> Got to v6, heh.
> 
> I still don't think this is _right_, but I guess I'm OK with giving you
> rope to hang yourself ;-)

I do see your point. But with the udev in place, 5 min or 1 hour it shouldn't
matter right? But for users without the udev script then a long time is better
to react and learn how to capture the very first GPU hang information.

> 
> Acked-by: Johannes Berg <johannes@sipsolutions.net>

Thank you

> 
> Seems like you really should've CC'ed Greg though since these things
> usually went through his tree, so if you want to take them through yours
> he really should be at least aware ...

Indeed

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Greg, ack on getting it through drm?

> 
> johannes
>