Received-SPF: pass (google.com: domain of linux-kernel+bounces-211736-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 12 Jun 2024 16:03:26 +0100
From: Conor Dooley <conor@kernel.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Jason Baron <jbaron@akamai.com>, Ard Biesheuvel <ardb@kernel.org>,
	Miguel Ojeda <ojeda@kernel.org>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	Wedson Almeida Filho <wedsonaf@gmail.com>,
	Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
	=?iso-8859-1?Q?Bj=F6rn?= Roy Baron <bjorn3_gh@protonmail.com>,
	Benno Lossin <benno.lossin@proton.me>,
	Andreas Hindborg <a.hindborg@samsung.com>,
	linux-trace-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] rust: add static_key_false
Message-ID: <20240612-cottage-revision-9842e7e22070@spud>
References: <20240610-tracepoint-v2-0-faebad81b355@google.com>
 <20240610-tracepoint-v2-1-faebad81b355@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="dUAfOGkLLXcIvSlP"
Content-Disposition: inline
In-Reply-To: <20240610-tracepoint-v2-1-faebad81b355@google.com>


--dUAfOGkLLXcIvSlP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024 at 02:01:04PM +0000, Alice Ryhl wrote:
> Add just enough support for static key so that we can use it from
> tracepoints. Tracepoints rely on `static_key_false` even though it is
> deprecated, so we add the same functionality to Rust.
>=20
> It is not possible to use the existing C implementation of
> arch_static_branch because it passes the argument `key` to inline
> assembly as an 'i' parameter, so any attempt to add a C helper for this
> function will fail to compile because the value of `key` must be known
> at compile-time.
>=20
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>

> +#[cfg(target_arch =3D "x86_64")]

> +#[cfg(target_arch =3D "aarch64")]

This patch breaks the build on riscv (and I assume loongarch):

error[E0432]: unresolved import `_static_key_false`
--> /stuff/linux/rust/kernel/static_key.rs:87:10
|
87 | pub use {_static_key_false, static_key_false};
|          ^^^^^^^^^^^^^^^^^ no external crate `_static_key_false`

Cheers,
Conor.


--dUAfOGkLLXcIvSlP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZmm4vgAKCRB4tDGHoIJi
0pVkAP9EeMhX3Q/hwLb+de1F64FhI0DaOk0yQebsR9xD6ZE8VgEAlwzOITVeEvJ2
iMqajvY89XlzKAdwizJAOPQ+h/BZwQk=
=xvXY
-----END PGP SIGNATURE-----

--dUAfOGkLLXcIvSlP--