Received-SPF: pass (google.com: domain of linux-kernel+bounces-211764-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 12 Jun 2024 17:10:02 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	=?iso-8859-1?Q?Jos=E9?= Roberto de Souza <jose.souza@intel.com>,
	linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org,
	Mukesh Ojha <quic_mojha@quicinc.com>,
	Jonathan Cavitt <jonathan.cavitt@intel.com>
Subject: Re: [PATCH v6 1/2] devcoredump: Add dev_coredumpm_timeout()
Message-ID: <2024061248-scanning-backlight-da0f@gregkh>
References: <20240611174716.72660-1-jose.souza@intel.com>
 <49c2fbdc91d128c5249d50d016d97c8e5162f7b7.camel@sipsolutions.net>
 <Zmm2jC2nx6gZ2WOn@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Zmm2jC2nx6gZ2WOn@intel.com>

On Wed, Jun 12, 2024 at 10:54:04AM -0400, Rodrigo Vivi wrote:
> On Wed, Jun 12, 2024 at 02:02:37PM +0200, Johannes Berg wrote:
> > On Tue, 2024-06-11 at 10:47 -0700, Jos? Roberto de Souza wrote:
> > > Add function to set a custom coredump timeout.
> > > 
> > > For Xe driver usage, current 5 minutes timeout may be too short for
> > > users to search and understand what needs to be done to capture
> > > coredump to report bugs.
> > > 
> > > We have plans to automate(distribute a udev script) it but at the end
> > > will be up to distros and users to pack it so having a option to
> > > increase the timeout is a safer option.
> > > 
> > > v2:
> > > - replace dev_coredump_timeout_set() by dev_coredumpm_timeout() (Mukesh)
> > > 
> > > v3:
> > > - make dev_coredumpm() static inline (Johannes)
> > > 
> > > v5:
> > > - rename DEVCOREDUMP_TIMEOUT -> DEVCD_TIMEOUT to avoid redefinition
> > > in include/net/bluetooth/coredump.h
> > > 
> > > v6:
> > > - fix definition of dev_coredumpm_timeout() when CONFIG_DEV_COREDUMP
> > > is disabled
> > 
> > Got to v6, heh.
> > 
> > I still don't think this is _right_, but I guess I'm OK with giving you
> > rope to hang yourself ;-)
> 
> I do see your point. But with the udev in place, 5 min or 1 hour it shouldn't
> matter right? But for users without the udev script then a long time is better
> to react and learn how to capture the very first GPU hang information.
> 
> > 
> > Acked-by: Johannes Berg <johannes@sipsolutions.net>
> 
> Thank you
> 
> > 
> > Seems like you really should've CC'ed Greg though since these things
> > usually went through his tree, so if you want to take them through yours
> > he really should be at least aware ...
> 
> Indeed
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Greg, ack on getting it through drm?

Fine with me:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>