Received-SPF: pass (google.com: domain of linux-kernel+bounces-211773-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 12 Jun 2024 11:13:38 -0400
From: Frank Li <Frank.li@nxp.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] arm64: dts: imx8: add basic lvds and lvds2
 subsystem
Message-ID: <Zmm7IjyZnxLvh5p+@lizhi-Precision-Tower-5810>
References: <20240610-imx8qm-dts-usb-v2-0-788417116fb1@nxp.com>
 <20240610-imx8qm-dts-usb-v2-1-788417116fb1@nxp.com>
 <5792284.DvuYhMxLoT@steina-w>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5792284.DvuYhMxLoT@steina-w>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?uP5jSU0Qv3ZjfJgI/g5E/BtJ5V6wAgIVC8tq4SlVt3rNlAVFQpkCvfGNNn?=
 =?iso-8859-1?Q?yCLGuGHnev9bLwHRkimWox8SeJoApgeqaJ13lESPpLi3O6ZUFmN2ODXTbG?=
 =?iso-8859-1?Q?nkOsecEaQXrCebfQLrYD1B4Si1Vyo5k8OGxOMFVoUzyy6iIv7JRIR5L+Pu?=
 =?iso-8859-1?Q?4zPFJY5R6WaeXsFQtOUAXK/h1tor6Eb8/aXiadt6AOeE8KgNxpPha38EM0?=
 =?iso-8859-1?Q?zs7fenDh4RhG0MfodaCPvooK1cbze2I5vpcQphFsbZrxh2rPdlINWughDB?=
 =?iso-8859-1?Q?WVdH8lC/2IGS1mcT0GAnBA0mtq7KlV4+K2dbePopTxFm9185MqvDyU15le?=
 =?iso-8859-1?Q?5MCaMOJOCTQDFPB3044WMNVugIT9KjPXop0pW/K/VYuQJ9pN55ao275gI8?=
 =?iso-8859-1?Q?c18fEwuZT7nSQEIPP/60CsQrWwhma61kXkhUz1i76wKpAArqi0L5GbuJyl?=
 =?iso-8859-1?Q?jaxZKOoyvt+utAYYbJNHVRDfUjRM4C7AD8yH+UWZjJFrK42kpm8CUHkqCe?=
 =?iso-8859-1?Q?TS4ltoioU+Nl045M5z01DZPqGAaPrLTXkgy1Za+k3yhullWAkP4SqTebQ4?=
 =?iso-8859-1?Q?CkuKWSZkvLqDJqWFzLikktUx2oeYt+h64C4J5/9XZnncmmqPnDTEE3N5Jh?=
 =?iso-8859-1?Q?vEhVYPayh3NQM+7I35CcWHuqowqCjA7Ah073qZRSFey15jmbN6kpkZuR3h?=
 =?iso-8859-1?Q?c6LXCNL0dFQNMLG8K12Z4ignDGYpB2x32Gc9qFv2fTFezgYR4YdGaUhl+0?=
 =?iso-8859-1?Q?uq279JPiXp3z98Gyb46G78ef6tWiKkNY+c6rGoZUlDg5Gl9l7BKl8XD5A/?=
 =?iso-8859-1?Q?NYn3o5CPCeERZxoXamfvOCL6TGtCUzgbTIv9RNhuGEEOYocUZumm5Ar94N?=
 =?iso-8859-1?Q?04jIDYuS7q/pfdL2mxYcdmfB9S0eafnAeZYSAQPdKNEP+ife8MMVIRdm5v?=
 =?iso-8859-1?Q?GDLlrKKVqDzBBGzJpCVSUnBA6NXSJkQuMI243Y4cHd8SIqgjzxar9QyPrO?=
 =?iso-8859-1?Q?4t5XV0atnGRe0j9YlXsHvaAx5VsUvUFt+OJ8ntlZ7hSGuWp+sIXR238lUQ?=
 =?iso-8859-1?Q?w+J8g4zja6cPkWV0yi5yTd1Osy5C0DC6qm5GnBCqYLF8QjBoNJ1zWYc/FL?=
 =?iso-8859-1?Q?2UuyV+qSQ/e5m9Ju85VyUmxboNtna2CY7nCz6UtvNDfdzpcxySSbyxauTq?=
 =?iso-8859-1?Q?bOECOSzetAJd0ncl4VEJtuM+4dEF6R6nF7eY8cXhZly8caj/fn39flqJIa?=
 =?iso-8859-1?Q?FLUrOHcm4XeNH3SJefr4uC7xGD2p2BqsRSiUMlOfbYAy0YuhFaCSsw8eu8?=
 =?iso-8859-1?Q?TQkReJWtBp4c0KS54w8NKOCgP9rDOxvBC9EgW+oweuIy3tJsCdrVUDCTcP?=
 =?iso-8859-1?Q?n3awSN80+zHaF171cxpY8PgvmGJkokvfGS8zfUhNwsni7rwIelSD/oelei?=
 =?iso-8859-1?Q?as7s24AIhUgZjopPGQvKLzegUmzrKXa4frO4CcqL/FXl2uPR1efbJ+/7sL?=
 =?iso-8859-1?Q?V0SYY/M0IheMpuPL9xXL8htj0a6ghLCnpS0knHE/BdcMFXVI+G2dEOpUzM?=
 =?iso-8859-1?Q?9SoZNf/w/yQmPNpouaRckLXSPSkVv8CdBB3u6X+hCKeKwcaURH0HRZjPIR?=
 =?iso-8859-1?Q?rIodN8YU1gLP1JMbWASjL3vQqVzOGZwYmf?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d70f0bb-71fb-48c4-cbb7-08dc8af240d4
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 15:13:45.6939
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PkndRH7r+Tz3lqfzAwfsbMJXXRoPnWEdwANw0INexRF3q5EkQJ0V76USQOx26IM71HKn5wSNU2rclbjpBbR0tA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10572

On Tue, Jun 11, 2024 at 12:05:35PM +0200, Alexander Stein wrote:
> Hi Frank,
> 
> Am Montag, 10. Juni 2024, 22:46:18 CEST schrieb Frank Li:
> > Add basic lvds and lvds2 subsystem for imx8qm an imx8qxp.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8-ss-lvds0.dtsi |  63 +++++++++++++
> >  arch/arm64/boot/dts/freescale/imx8-ss-lvds1.dtsi | 114 +++++++++++++++++++++++
> >  2 files changed, 177 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lvds0.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-lvds0.dtsi
> > new file mode 100644
> > index 0000000000000..55fd60446ad21
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-lvds0.dtsi
> > @@ -0,0 +1,63 @@
> > +// SPDX-License-Identifier: GPL-2.0-only and MIT
> > +
> > +/*
> > + * Copyright 2024 NXP
> > + */
> > +
> > +lvds0_subsys: bus@56240000 {
> > +	compatible = "simple-bus";
> > +	#address-cells = <1>;
> > +	#size-cells = <1>;
> > +	ranges = <0x56240000 0x0 0x56240000 0x10000>;
> > +
> > +	qm_lvds0_lis_lpcg: qxp_mipi1_lis_lpcg: clock-controller@56243000 {
> > +		compatible = "fsl,imx8qxp-lpcg";
> > +		reg = <0x56243000 0x4>;
> > +		#clock-cells = <1>;
> > +		clock-output-names = "mipi1_lis_lpcg_ipg_clk";
> > +		power-domains = <&pd IMX_SC_R_MIPI_1>;
> > +	};
> > +
> > +	qm_lvds0_pwm_lpcg: qxp_mipi1_pwm_lpcg: clock-controller@5624300c {
> > +		compatible = "fsl,imx8qxp-lpcg";
> > +		reg = <0x5624300c 0x4>;
> > +		#clock-cells = <1>;
> > +		clock-output-names = "mipi1_pwm_lpcg_clk",
> > +				     "mipi1_pwm_lpcg_ipg_clk",
> > +				     "mipi1_pwm_lpcg_32k_clk";
> > +		power-domains = <&pd IMX_SC_R_MIPI_1_PWM_0>;
> > +	};
> > +
> > +	qm_lvds0_i2c0_lpcg: qxp_mipi1_i2c0_lpcg: clock-controller@56243010 {
> > +		compatible = "fsl,imx8qxp-lpcg";
> > +		reg = <0x56243010 0x4>;
> > +		#clock-cells = <1>;
> > +		clock-output-names = "mipi1_i2c0_lpcg_clk",
> > +				     "mipi1_i2c0_lpcg_ipg_clk";
> > +		power-domains = <&pd IMX_SC_R_MIPI_1_I2C_0>;
> > +	};
> > +
> > +	qm_pwm_lvds0: qxp_pwm_mipi_lvds1: pwm@56244000 {
> > +		compatible = "fsl,imx8qxp-pwm", "fsl,imx27-pwm";
> > +		reg = <0x56244000 0x1000>;
> > +		clock-names = "ipg", "per";
> > +		assigned-clocks = <&clk IMX_SC_R_MIPI_1_I2C_0 IMX_SC_PM_CLK_PER>;
> 
> Is IMX_SC_R_MIPI_1_I2C_0 actually correct? I would have assumed
> it's IMX_SC_R_MIPI_1_PWM_0.
> 
> > +		assigned-clock-rates = <24000000>;
> > +		#pwm-cells = <3>;
> > +		power-domains = <&pd IMX_SC_R_MIPI_1_PWM_0>;
> > +		status = "disabled";
> > +	};
> > +
> > +	qm_i2c0_lvds0: qxp_i2c0_mipi_lvds1: i2c@56246000 {
> > +		compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c";
> > +		reg = <0x56246000 0x1000>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		interrupts = <8>;
> > +		clock-names = "per", "ipg";
> > +		assigned-clocks = <&clk IMX_SC_R_MIPI_1_I2C_0 IMX_SC_PM_CLK_PER>;
> > +		assigned-clock-rates = <24000000>;
> > +		power-domains = <&pd IMX_SC_R_MIPI_1_I2C_0>;
> > +		status = "disabled";
> > +	};
> > +};
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lvds1.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-lvds1.dtsi
> > new file mode 100644
> > index 0000000000000..12ae4f48e1e1c
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-lvds1.dtsi
> 
> This is only for imx8qm, no?
> 
> It maybe makes sense to rename this file to imx8qm-ss-lvds1.dtsi

It plan include in root node, it'd better keep consistency with other
file names.

        /* sorted in register address */                                                            
        #include "imx8-ss-audio.dtsi"                                                               
        #include "imx8-ss-img.dtsi"                                                                 
        #include "imx8-ss-dma.dtsi"                                                                 
        #include "imx8-ss-security.dtsi"                                                            
        #include "imx8-ss-cm41.dtsi"                                                                
        #include "imx8-ss-conn.dtsi"                                                                
        #include "imx8-ss-ddr.dtsi"                                                                 
        #include "imx8-ss-lsio.dtsi"                                                                
        #include "imx8-ss-hsio.dtsi"                                                                
        #include "imx8-ss-dc0.dtsi"                                                                 
        #include "imx8-ss-dc1.dtsi"                                                                 
        #include "imx8-ss-gpu0.dtsi"                                                                
        #include "imx8-ss-gpu1.dtsi"                                                                
        #include "imx8-ss-vpu.dtsi"  

}

imx8qm-ss-xxx should overwrite common ss part.

Frank

> 
> Best regards,
> Alexander
> 
> > @@ -0,0 +1,114 @@
> > +// SPDX-License-Identifier: GPL-2.0-only and MIT
> > +
> > +/*
> > + * Copyright 2024 NXP
> > + */
> > +
> > +lvds1_subsys: bus@57240000 {
> > +	compatible = "simple-bus";
> > +	interrupt-parent = <&irqsteer_lvds1>;
> > +	#address-cells = <1>;
> > +	#size-cells = <1>;
> > +	ranges = <0x57240000 0x0 0x57240000 0x10000>;
> > +
> > +	irqsteer_lvds1: interrupt-controller@57240000 {
> > +		compatible = "fsl,imx8qm-irqsteer", "fsl,imx-irqsteer";
> > +		reg = <0x57240000 0x1000>;
> > +		interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
> > +		interrupt-controller;
> > +		interrupt-parent = <&gic>;
> > +		#interrupt-cells = <1>;
> > +		clocks = <&lvds1_lis_lpcg IMX_LPCG_CLK_4>;
> > +		clock-names = "ipg";
> > +		power-domains = <&pd IMX_SC_R_LVDS_1>;
> > +		fsl,channel = <0>;
> > +		fsl,num-irqs = <32>;
> > +	};
> > +
> > +	lvds1_lis_lpcg: clock-controller@57243000 {
> > +		compatible = "fsl,imx8qxp-lpcg";
> > +		reg = <0x57243000 0x4>;
> > +		#clock-cells = <1>;
> > +		clocks = <&lvds_ipg_clk>;
> > +		clock-indices = <IMX_LPCG_CLK_4>;
> > +		clock-output-names = "lvds1_lis_lpcg_ipg_clk";
> > +		power-domains = <&pd IMX_SC_R_LVDS_1>;
> > +	};
> > +
> > +	lvds1_pwm_lpcg: clock-controller@5724300c {
> > +		compatible = "fsl,imx8qxp-lpcg";
> > +		reg = <0x5724300c 0x4>;
> > +		#clock-cells = <1>;
> > +		clocks = <&clk IMX_SC_R_LVDS_1_PWM_0 IMX_SC_PM_CLK_PER>,
> > +			 <&lvds_ipg_clk>;
> > +		clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> > +		clock-output-names = "lvds1_pwm_lpcg_clk",
> > +				     "lvds1_pwm_lpcg_ipg_clk";
> > +		power-domains = <&pd IMX_SC_R_LVDS_1_PWM_0>;
> > +	};
> > +
> > +	lvds1_i2c0_lpcg: clock-controller@57243010 {
> > +		compatible = "fsl,imx8qxp-lpcg";
> > +		reg = <0x57243010 0x4>;
> > +		#clock-cells = <1>;
> > +		clocks = <&clk IMX_SC_R_LVDS_1_I2C_0 IMX_SC_PM_CLK_PER>,
> > +			 <&lvds_ipg_clk>;
> > +		clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> > +		clock-output-names = "lvds1_i2c0_lpcg_clk",
> > +				     "lvds1_i2c0_lpcg_ipg_clk";
> > +		power-domains = <&pd IMX_SC_R_LVDS_1_I2C_0>;
> > +	};
> > +
> > +	lvds1_i2c1_lpcg: clock-controller@57243014 {
> > +		compatible = "fsl,imx8qxp-lpcg";
> > +		reg = <0x57243014 0x4>;
> > +		#clock-cells = <1>;
> > +		clocks = <&clk IMX_SC_R_LVDS_1_I2C_0 IMX_SC_PM_CLK_PER>,
> > +			 <&lvds_ipg_clk>;
> > +		clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
> > +		clock-output-names = "lvds1_i2c1_lpcg_clk",
> > +				     "lvds1_i2c1_lpcg_ipg_clk";
> > +		power-domains = <&pd IMX_SC_R_LVDS_1_I2C_0>;
> > +	};
> > +
> > +	pwm_lvds1: pwm@57244000 {
> > +		compatible = "fsl,imx8qxp-pwm", "fsl,imx27-pwm";
> > +		reg = <0x57244000 0x1000>;
> > +		clocks = <&lvds1_pwm_lpcg IMX_LPCG_CLK_4>,
> > +			 <&lvds1_pwm_lpcg IMX_LPCG_CLK_0>;
> > +		clock-names = "ipg", "per";
> > +		assigned-clocks = <&clk IMX_SC_R_LVDS_1_PWM_0 IMX_SC_PM_CLK_PER>;
> > +		assigned-clock-rates = <24000000>;
> > +		#pwm-cells = <3>;
> > +		power-domains = <&pd IMX_SC_R_LVDS_1_PWM_0>;
> > +		status = "disabled";
> > +	};
> > +
> > +	i2c0_lvds1: i2c@57246000 {
> > +		compatible = "fsl,imx8qm-lpi2c", "fsl,imx7ulp-lpi2c";
> > +		reg = <0x57246000 0x1000>;
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		interrupts = <8>;
> > +		clocks = <&lvds1_i2c0_lpcg IMX_LPCG_CLK_0>,
> > +			 <&lvds1_i2c0_lpcg IMX_LPCG_CLK_4>;
> > +		clock-names = "per", "ipg";
> > +		assigned-clocks = <&clk IMX_SC_R_LVDS_1_I2C_0 IMX_SC_PM_CLK_PER>;
> > +		assigned-clock-rates = <24000000>;
> > +		power-domains = <&pd IMX_SC_R_LVDS_1_I2C_0>;
> > +		status = "disabled";
> > +	};
> > +
> > +	i2c1_lvds1: i2c@57247000 {
> > +		compatible = "fsl,imx8qm-lpi2c", "fsl,imx7ulp-lpi2c";
> > +		reg = <0x57247000 0x1000>;
> > +		interrupts = <9>;
> > +		clocks = <&lvds1_i2c1_lpcg IMX_LPCG_CLK_0>,
> > +			 <&lvds1_i2c1_lpcg IMX_LPCG_CLK_4>;
> > +		clock-names = "per", "ipg";
> > +		assigned-clocks = <&clk IMX_SC_R_LVDS_1_I2C_0 IMX_SC_PM_CLK_PER>;
> > +		assigned-clock-rates = <24000000>;
> > +		power-domains = <&pd IMX_SC_R_LVDS_1_I2C_0>;
> > +		status = "disabled";
> > +	};
> > +};
> > 
> > 
> 
> 
> -- 
> TQ-Systems GmbH | M?hlstra?e 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht M?nchen, HRB 105018
> Gesch?ftsf?hrer: Detlef Schneider, R?diger Stahl, Stefan Schneider
> http://www.tq-group.com/
> 
>