Received-SPF: pass (google.com: domain of linux-kernel+bounces-211760-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <56aef347-7582-497e-be02-d82eda7b3528@arm.com>
Date: Wed, 12 Jun 2024 16:07:45 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/5] mfd: axp20x: AXP717: Fix missing IRQ status
 registers range
To: Lee Jones <lee@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>, Liam Girdwood <lgirdwood@gmail.com>,
 Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
 Jernej Skrabec <jernej.skrabec@gmail.com>,
 Samuel Holland <samuel@sholland.org>, Ryan Walklin <ryan@testtoast.com>,
 Chris Morgan <macroalpha82@gmail.com>
References: <20240418000736.24338-1-andre.przywara@arm.com>
 <20240418000736.24338-2-andre.przywara@arm.com>
 <20240502093907.GM5338@google.com>
Content-Language: en-US
From: Andre Przywara <andre.przywara@arm.com>
In-Reply-To: <20240502093907.GM5338@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Lee,

On 02/05/2024 10:39, Lee Jones wrote:
> On Thu, 18 Apr 2024, Andre Przywara wrote:
> 
>> While we list the "IRQ status *and acknowledge*" registers as volatile,
>> they are missing from the writable range array, so acknowledging any
>> interrupts was met with an -EIO error.
>>
>> Add the five registers that hold those bits to the writable array.
>>
>> Fixes: b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC")
>> Reported-by: Chris Morgan <macromorgan@hotmail.com>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>> ---
>>   drivers/mfd/axp20x.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Acked-by: Lee Jones <lee@kernel.org>

Can you please take just this patch as a fix for 6.10? This fixes the 
power key operation.
This applies cleanly on top of v6.10-rc3, so there is no need for any 
extra immutable branch or coordination with regulator.
(The same is true independently for patch 2/5, on the regulator side).

Cheers,
Andre

> 
>> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
>> index 48ce6ea693cea..d8ad4e120d379 100644
>> --- a/drivers/mfd/axp20x.c
>> +++ b/drivers/mfd/axp20x.c
>> @@ -210,6 +210,7 @@ static const struct regmap_access_table axp313a_volatile_table = {
>>   
>>   static const struct regmap_range axp717_writeable_ranges[] = {
>>   	regmap_reg_range(AXP717_IRQ0_EN, AXP717_IRQ4_EN),
>> +	regmap_reg_range(AXP717_IRQ0_STATE, AXP717_IRQ4_STATE),
>>   	regmap_reg_range(AXP717_DCDC_OUTPUT_CONTROL, AXP717_CPUSLDO_CONTROL),
>>   };
>>   
>> -- 
>> 2.35.8
>>
>