Received-SPF: pass (google.com: domain of linux-kernel+bounces-211775-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Songyang Li <leesongyang@outlook.com>
To: helgaas@kernel.org
Cc: bhelgaas@google.com,
	leesongyang@outlook.com,
	linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH]  PCI: Cancel compilation restrictions on function pcie_clear_device_status
Date: Wed, 12 Jun 2024 23:15:43 +0800
Message-ID:
 <TY3P286MB275469F17C8C5389C18313BBB4C02@TY3P286MB2754.JPNP286.PROD.OUTLOOK.COM>
In-Reply-To: <20240611223418.GA1005201@bhelgaas>
References: <20240611223418.GA1005201@bhelgaas>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TY3P286MB2754:EE_|TYRP286MB4456:EE_
X-MS-Office365-Filtering-Correlation-Id: b2ccfc9e-cdfe-4c17-c149-08dc8af29543
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199021|3412199018|440099021|1710799020;
X-Microsoft-Antispam-Message-Info:
	EMMYripY4xMcz+s771T5Ng9LyPQwV+eOe7tUuKXUIbTlbZZ4P6VLCMsSi74B7e0eA7xuCE8Fy56MOe2RAGKiDwP4sODoeKG4/Jl+xnR3ciHrCWpMex9dn1lQZlCr2T4e+de7TXXvTGVrERlNZKSj7ALyi44sVoGQVUwRzTpEn+ZG1R9W8Yp22c2flCgVSrbYI0WQEizsULVPHIjqxbrwmM9obfpIAya/ddAILE9ngywdZwtVBas+kF7JjknwD8qwFYgeoNWp8C3kuRw6cCnkELcaLa/SGUw2VQpv3ImEPj7p4pqV20l64lZjSqJLaRnsDeiaYNK4rpL5d9pl8F9IThIIY/U5jOIwh4RiCGfhHJycL2zwyCMHbwppLpO0Csg+04qUNRMRZ8Oho436A79rvN1ooWv383mB9j3+ZOwOFIyiJ3qGTMGp/uDkehxD6Eijp9i6z/rI8adScZI0x57G3KW/tjuR7q9nZgz4yI39kGAxjKTY0o9wZIA+eXbopbMc6tHiFQFXc9vX7pXnVQetmr3Esm4N6tSJZSecOX0jwpXru0ZeutJrviZgPERuTOowOsgmfRncEVxNZzpS+SsFA85ANoZn0nlHpAFmUBhUGylJU1bvYUpyWSNAmVVp+Dqj
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?E5OMjJDiXfS8b8NN5FRg9n+XDOLLTT34yVLM81CsvTysJiZtZm+nZSMWesk7?=
 =?us-ascii?Q?Jp+aWlkuPhsJjtq8jOVzjg2NhnXa6LxtTuj87GTGAqoKVKy9QOThU12Opn3b?=
 =?us-ascii?Q?anq0aTFAgmzGvIGQBuDDMu3IOJdmIKynKysnq4wixifltOrW1llrDBRTOeaj?=
 =?us-ascii?Q?w+Qy+AnCrD1266EtikfH9tSFRrfmqTlfPEjCkonsp+DJId3Nk2epRr56LdbM?=
 =?us-ascii?Q?MNe7TWTkMD59465tdBT9r1jxSZCyzoKtftsKrQACW8GRZn6Sob3vpAeOwtz/?=
 =?us-ascii?Q?3mgZNnARWeGvr/o/BWxSzKmZvzbzqvf+HOedBK6LUH7DDB1GZpnEA5ZFBg0k?=
 =?us-ascii?Q?OF4nke3LMiMG9AnhM99gxc7L8dhn1KHbyEp0gPkhMiF8PNe7FutLse93O32H?=
 =?us-ascii?Q?/r4loZMh1Uq856jWzwrVUPAizqLFMhsAEIF78tPkWK/RRg+68e4jaVXkAAny?=
 =?us-ascii?Q?SYTBTSNivfzq3qSM0huwrGBFyda7+1tlVSgSIQGKMUaA/+U5yEd8+T2pa07c?=
 =?us-ascii?Q?lnIQkCjdmpzyNzvd0hrp4Wot7Zeb5c2hGnXHojLZs5fxB64+KAUccySHkJtK?=
 =?us-ascii?Q?oQT/u7NibDL4UAnkkPqchRR6VY7epd2m5eQuNX2f++up/PTxICQ+lzaycBeI?=
 =?us-ascii?Q?Iqij1034aPpyWs5YKgcSvDzVaJ5bBS9Mgk2DCRF08wIzkNl4yewLMuGNSQ72?=
 =?us-ascii?Q?2Tk7fl1bnzD4zJAS0vCZEx2f68OpjxDz4Bfb3JY43oIqKyAvPShXzFCYfAtS?=
 =?us-ascii?Q?Wg2lDwDdbEmtKkm9xnTYLHICcn2FcYu0ZfhTEk8aIx/uFvaMNZD6Q0b3l8F1?=
 =?us-ascii?Q?gaTEpyvNr6J/ZSqXjp1rNWuut+lIE4KpfSh7CADbLY6bYtkj1q0kzpSs5BJ9?=
 =?us-ascii?Q?72pGRLjQCma2cCx5RzAgzx7ToZj1wvdlfnz7nN3uPl2MTgX2GN08kjFA/UBy?=
 =?us-ascii?Q?q0UjCfhGmuTii6SJNUZD1dUlvzh9Ar+Ds3xN9nlTFi/DiX+4ocgRWe7ip5u4?=
 =?us-ascii?Q?B2JlikwlufNT54isP4ZT5KcD1NEx+f4zpp8ENH68czj+jvSXb7mXPuvxmeun?=
 =?us-ascii?Q?k2gvoF1UKMz5anFD+JQ40CeokPGlGLtcowLvaEB4Io+cU8p6o9errjR3UhFy?=
 =?us-ascii?Q?YHPSLRDjvJXe5vLej4p0wt8ccczKP36EzXM3JKNa0J7EIJe4Ty2GkVR/SifW?=
 =?us-ascii?Q?kx1kxqiQATDiI5Q2TtUvpj3jN9c1uEHAiu6m6thuA/9vXSj1AU7k54LX4+M?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2ccfc9e-cdfe-4c17-c149-08dc8af29543
X-MS-Exchange-CrossTenant-AuthSource: TY3P286MB2754.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 15:16:08.5980
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYRP286MB4456

On Tue, 11 Jun 2024 17:34:18 -0500, Bjorn Helgaas wrote:
> Unindent this.

> Add "()" after function names.

> Please explain what this patch does and why we want it.  I can see
> from the patch that it makes it so pcie_clear_device_status() is
> always compiled, but the commit log should say that and should say why
> we need that.

Thank you for reminding to add "()" after function pcie_clear_device_status.
The following is a revised patch,and it explains why we need that.
Thanks,

Songyang Li

From 3c1340522565a44ef25d2045e5bee2c0bdb72b32 Mon Sep 17 00:00:00 2001
From: Songyang Li <leesongyang@outlook.com>
Date: Wed, 12 Jun 2024 22:29:51 +0800
Subject: [PATCH] PCI: Cancel compilation restrictions on function
 pcie_clear_device_status()

Some PCIe devices do not have AER capabilities, but they have
device status registers. The PCIe device status register and
AER register are independent PCIe capabilities, so it is
unreasonable to use CONFIG_PCIEAER for compilation control of
pcie_clear_device_status(), although which is currently only
used in the "aer.c", "edr.c", and "err.c". Some operating system
configurations do not enable the AER feature, but still expect to
use the device status register for simple RAS. In this case,
pcie_clear_device_status() can be used to clear the device status
regs, so this patch can meet the requirements of this scenario.

Signed-off-by: Songyang Li <leesongyang@outlook.com>
---
 drivers/pci/pci.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
 mode change 100644 => 100755 drivers/pci/pci.c

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
old mode 100644
new mode 100755
index 35fb1f17a589..e6de55be4c45
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2263,7 +2263,12 @@ int pci_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state state)
 }
 EXPORT_SYMBOL_GPL(pci_set_pcie_reset_state);
 
-#ifdef CONFIG_PCIEAER
+/**
+ * pcie_clear_device_status - Clear device status.
+ * @dev: the PCI device.
+ *
+ * Clear the device status for the PCI device.
+ */
 void pcie_clear_device_status(struct pci_dev *dev)
 {
 	u16 sta;
@@ -2271,7 +2276,6 @@ void pcie_clear_device_status(struct pci_dev *dev)
 	pcie_capability_read_word(dev, PCI_EXP_DEVSTA, &sta);
 	pcie_capability_write_word(dev, PCI_EXP_DEVSTA, sta);
 }
-#endif
 
 /**
  * pcie_clear_root_pme_status - Clear root port PME interrupt status.
-- 
2.34.1