Received-SPF: pass (google.com: domain of linux-kernel+bounces-211789-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 12 Jun 2024 08:29:07 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Dan Williams
	<dan.j.williams@intel.com>
CC: <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>, Vishal Verma
	<vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Ira Weiny
	<ira.weiny@intel.com>
Subject: Re: [PATCH] nvdimm: make nd_class constant
Message-ID: <6669bec3102cb_310129441@dwillia2-xfh.jf.intel.com.notmuch>
References: <2024061041-grandkid-coherence-19b0@gregkh>
 <66673b8a1ec86_12552029457@dwillia2-xfh.jf.intel.com.notmuch>
 <2024061206-unleveled-seduce-9861@gregkh>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2024061206-unleveled-seduce-9861@gregkh>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XFZGj1tfrdk55Ejj61PnFli0rdg02E+LJ33O/ktO3GfU31EeEK/P1z/rM/in?=
 =?us-ascii?Q?s9fqk4pniPKZIgd2zXtMyAkcR7BcoVm2nJ+xBJA5DMv9Xt9aHdqVfh/o8/SH?=
 =?us-ascii?Q?FE2162PjjMg0hdoaiCc3n/+F2RRaa+/3RDS3RXGFoO+eeaa/2UL6HhVoCFv/?=
 =?us-ascii?Q?Cx3lCH/nxGdZS37MDhEVZVGVAtO9e3N/wGoxskQ8BDTlpTAKF7dSOX62LxL4?=
 =?us-ascii?Q?F9LU+AsiBWT2ZJNbZrd2pNfxHlNEWSuhmNaPYsHaOWf/ye003z14HkS1VCdE?=
 =?us-ascii?Q?W83J4z0WLKnD4LZ3P740MskgUVgO90CHRmifCaPfWmkL20/sM3ELWNm0356d?=
 =?us-ascii?Q?CaLdUVGYkBnnvA5EixjjT/CBg3Kx4QwPX7ppOxXNzn8yAET9ypmPJkgOZyUg?=
 =?us-ascii?Q?bt2QixE2jLkvA32plRTyp0v8xv1r7iiSD4PA1oYPJFhFmLUhEmLrCzcXPcMx?=
 =?us-ascii?Q?zkDrq4ul6E93g3LBCiB3jFcknK7qzQVJEhn1otrmTQ0aNJRhUOKBRSBtZk1B?=
 =?us-ascii?Q?s/qAfyU+DEbjswaqNUBG6XiSewA3TjlJ4NGbp62m7du/M8Qb/y92TR9PU+fN?=
 =?us-ascii?Q?BThiKFgml9pvzBnZhEbqwbdqw4OK2zpscMvn63KCor9a18llNrPds29Kb3rF?=
 =?us-ascii?Q?amnoQn1O8TN+yBGcwcuWcFIRgJYloD011IQc92c7Hv+KBGzQ5ulB89nTfOpT?=
 =?us-ascii?Q?JYMabNZiT5IP7pe0pHBCUwq8ke1lka02xFMsWw6/EFmmaiEH+/uruseiUn5k?=
 =?us-ascii?Q?4xTwnYi+SlBqO186TrKmZKYWxCh414XNihwkeb4wBFQjniQMCaLsDwYhcj7X?=
 =?us-ascii?Q?dcAoPqoU3MN0I/grb0JVdOI9jT/1vrdFsBDEgzUtwvVMmB4vDvLljizdRSb6?=
 =?us-ascii?Q?JtllUJXpnfa3iIb3EwCLu2NNaOKWIePPHCer1sujbJCmhxTemc646oTpoegw?=
 =?us-ascii?Q?nTnfQQATwBg3duGnli+R/7ym3ctbiGTYHdmDNBxDL4mAOmqxToWt7ki/ZlGQ?=
 =?us-ascii?Q?cAdFo2krfM7lmLIZeH6oKTJeVDAhOZ7TcQA83JXPljrXqe6kPIqLxiXcvNCe?=
 =?us-ascii?Q?6P74zI8ls2HQDsYxbLUPdF545M/flnEHN88Jkpo+GkeYyE6Ju7GED/n5ulzd?=
 =?us-ascii?Q?6295wY7MtZqLItVS3/TzUCS1byCgrCp/+fdGTlSRie2FZcY1pSpvkCMoLlFx?=
 =?us-ascii?Q?agW0diR7QhYQtJGXEmPK//XZKQTbOR6s/BP/grwB4xHLMJXfOjbve85Ut+J/?=
 =?us-ascii?Q?4HQ45dG8bCjdudAvoL9HDDJak//yDjdPzP9mYLqFlDPkhzSYF/TqiM3hHUp4?=
 =?us-ascii?Q?Ke4RZ7om67U96UXKIsTg0F+yzOKUw+Mn7m12lV9M8G4nWtmAZ/4tDiZ+qK/a?=
 =?us-ascii?Q?EXZcKI20qOCoy3YkJnANR13iM4TwbkecV/6CCvJGKVdMvjS0zM4NMz6th4Eq?=
 =?us-ascii?Q?Id4CYP6mQ6bgM4Et+PQSmuQp28uqZdtUPl7QEJiAzxdcTtM2ynpjys9tzH7n?=
 =?us-ascii?Q?LW65RA4VrI0AdZ9+KlrVoOwHKLIpaJlDmhy9WN0a6R8Ap/of8EjuyU57e8qE?=
 =?us-ascii?Q?0W34D7/TEaxLFll6NUwWkzinGQInkWBynSiEGEnccll+/1ty5Et7P11NaIeX?=
 =?us-ascii?Q?aQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bf6cdb1d-a455-457f-d517-08dc8af46798
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 15:29:09.5868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SuhRCS9uyAzvfDrego9TnSSmHTI90VFEgqpV1Ifk34Ajhf4mPKDaetfctUpVMYyfkpvj+1tm+8YkE6uRbujYLBTGrBmCUyASlR0MHyzITCU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8531
X-OriginatorOrg: intel.com

Greg Kroah-Hartman wrote:
> On Mon, Jun 10, 2024 at 10:44:42AM -0700, Dan Williams wrote:
> > Greg Kroah-Hartman wrote:
> > > Now that the driver core allows for struct class to be in read-only
> > > memory, we should make all 'class' structures declared at build time
> > > placing them into read-only memory, instead of having to be dynamically
> > > allocated at runtime.
> > 
> > Change looks good to me,
> > 
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> > 
> > ...changelog grammar tripped me up though, how about:
> > 
> > "Now that the driver core allows for struct class to be in read-only
> > memory, it is possible to make all 'class' structures be declared at
> > build time. Move the class to a 'static const' declaration and register
> > it rather than dynamically create it."
> 
> That works too, want me to resubmit with this, or can I update it when I
> commit it to my tree?

Take it through your tree sounds good to me.

> thanks,
> 
> greg "the changelog is the hardest part" k-h

lol!

dan "can't code, but can proofread" williams