Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp548844lqp; Wed, 12 Jun 2024 09:06:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWg0iJORIAGIUEgvFeqlz7fJL4KLbSdDYg/k243ZAz6nyklZkx0ikoyUINw7K10q8NtLkTnIRE+vtyN0JIub2MyuZ/N6+OA03HDn03zTA== X-Google-Smtp-Source: AGHT+IF9akmYKFtnFdo2mrr0wj/oPwdGne4Wx6jTI6tf2paCMZRC7czlZ3qQmeewzT39dtfGz1um X-Received: by 2002:a17:906:f888:b0:a6f:2206:99ae with SMTP id a640c23a62f3a-a6f47ce9cb7mr139820466b.41.1718208376124; Wed, 12 Jun 2024 09:06:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718208376; cv=pass; d=google.com; s=arc-20160816; b=NDydgF4z1a2E5Y/xt8PQS2EHdw0Y8spEZPQ3+bHFy2uIrxhfi8N132LtQCpnS8xmLz mHm52KLyNi/NkApSNH+3IV4+FjFHUcp3yGzlZ4ZTbL26cHB9ssHAqi7I0A8K1kKF/u3E sO7mlb1uJDU47d7cMsdlA2xqxKc5QfPGKPhASzqLddPTkRY9LftoElf8Jc/8XMhJiY1Z U9xG0r/6qIIfL5Otg0uEIFqT1lMLdsa28jvFnWoEGtElNYe6GD1uwHxhVFNsLCJhRpcS elXqmzzhKOYh1FlX3ot6MAOS8KFQtvUE55WJ0gHJTfcv7zMXFhUr1rO5IkDc310Wb8hH t6dQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=B54Be83JNs7nl+rMReElF3H5ROq4XTJOopa9NkI4U9s=; fh=ch2Pwgocnz8HO+tm1GXowJ8Uq2NbfVMaUnSwsCeBCJA=; b=IsxKPEoVwIiZQgYIXZF94zpLFkxj616v7qvyyqeT8dld6EJkEMTpLtsC2lq/oEgFnW n3VibbJdsPmM6ki6Z5Wfvh/itwGw7+9bWd1UuTlNhLmNb1RAHaZjEjWzPmIzj03clhNv 7bMaUTN/9Xq+zlu7Mc2dZajs+SZX+Vbb5aP7Bh8DX1k2hoOmemoKJHBhQRoyzEkC0e/B rI5uk5An62a7EYktSgqI3A3zFdy4AUGCmNWYUXDb4snBlfT0CYveM1OqeC3EMBl6qCmb m5BPOGaXr5y8yIOnth3Dvl3x+DR3ToQb7H1UwOGH/T0ii0hvKDMtDLeRTLkz6Nis1cEr L1hg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=CQwRuXXG; arc=pass (i=1 spf=pass spfdomain=sang-engineering.com dkim=pass dkdomain=sang-engineering.com); spf=pass (google.com: domain of linux-kernel+bounces-211863-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211863-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f27fc642asi263940466b.727.2024.06.12.09.06.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 09:06:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-211863-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=CQwRuXXG; arc=pass (i=1 spf=pass spfdomain=sang-engineering.com dkim=pass dkdomain=sang-engineering.com); spf=pass (google.com: domain of linux-kernel+bounces-211863-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211863-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C96871F2121D for ; Wed, 12 Jun 2024 16:06:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 396E3180A77; Wed, 12 Jun 2024 16:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="CQwRuXXG" Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DD5F1836C4 for ; Wed, 12 Jun 2024 16:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718208209; cv=none; b=pzsWYbPpxQOqWzLg2/ZWTdL5usr+yBN1RKOsvlbafPF6sEAF/ltyLjdoJG+SsxaeomEZ4awbpMBMy/506Sq35/i7BF9XusUVYMUBAZg7dz512PTeCoFvLDx6qoUNRMlVrQHhghn1tTobUmobtiO8pY2UrsZmF2rLLjOFM0P48Fs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718208209; c=relaxed/simple; bh=332UBS0prHxkyUP4CYQFP5s8Gc011jBYVWz+9XPLa9c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pCe5Po3SvntLI5qF05t5PCdNPXmWvTHXs9Rz4AklE9jeKXgWWPcXkxhckMEsD+oo5Il1/LqJnbMCj8SUz5jYUS1ZzPBAxVkFmrH8wIEmSxc27cCki/SPrzJ0SdhMxIaoWssMCByc1Ig81iKFyqW6XESF/jF0NK2aXzq1ZW/drKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=CQwRuXXG; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=B54B e83JNs7nl+rMReElF3H5ROq4XTJOopa9NkI4U9s=; b=CQwRuXXGQsXzbkMKeRef BiEfLsMYDRrCKtKab3BTsl82biB8MvTwjBnrYoiycs8RjW7gmPyvazaDPOcnl6U0 aFlBgPwJ1xdNtW0DCrCYwB9VuQz5miQRl2aRdNYdIPQCW6k+HTsi2GEnQGyTw5B5 6TfsnUgfV1AadDA872fkj+330NTsC/wGUOJsLEG1WhiUxkFlISXTM9glWndbUI/w ZHfVmgx4NjSOY0mch35Z1s0NCXSTlfHqCWJIK9n/o2e6dg2bvDx4FGOJUdo1bARW 0pTR6G//LlAPF0ruOVOY6NCE1sJce3YmBDdpT/jCall9c8/I/iTvfrtJ9W3DlhPE mQ== Received: (qmail 864170 invoked from network); 12 Jun 2024 18:03:22 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 12 Jun 2024 18:03:22 +0200 X-UD-Smtp-Session: l3s3148p1@fkR/hbMa7DNtKPIY Date: Wed, 12 Jun 2024 18:03:20 +0200 From: Wolfram Sang To: Bartosz Golaszewski Cc: linux-renesas-soc@vger.kernel.org, Jonathan Corbet , Linus Walleij , Kent Gibson , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v9 1/1] gpio: add sloppy logic analyzer using polling Message-ID: Mail-Followup-To: Wolfram Sang , Bartosz Golaszewski , linux-renesas-soc@vger.kernel.org, Jonathan Corbet , Linus Walleij , Kent Gibson , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20240610112700.80819-1-wsa+renesas@sang-engineering.com> <20240610112700.80819-2-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pvtrej2bwhzfyplx" Content-Disposition: inline In-Reply-To: --pvtrej2bwhzfyplx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Bart, > I really dislike drivers being called in an ambiguous way like > "simple" or - in this case "sloppy". I understand why it is - in fact > - sloppy but can we call it anything else? Like > "gpio-logic-analyzer.c"? Sure, we can if you prefer. I named it like this to make the limitations super-clear. And even with that in place, I still got a private email where someone wanted to build a 400MHz-RPi-based logic analyzer device with it. Which would not only have the latency problems, but also likely have a max sampling speed of whopping 400kHz. > > +Note that you must provide a name for every GPIO specified. Currently a > > +maximum of 8 probes are supported. 32 are likely possible but are not > > +implemented yet. > > + >=20 > What happens on non-DT systems? Can you still create an analyzer in a > different way? Can I maybe interest you in configfs for the purpose of > device configuration like what gpio-sim and the upcoming gpio-virtuser > does? Frankly, I'd like to leave this to the person needing it. I've been working on this for way too long already and am not up to major changes anymore. Minor stuff, okay, I'll go one or two more rounds. The GPIO analyzer is a debug tool aimed for development boards in remote labs, and all boards I have access to use DT. Furthermore, debugfs is nice because it is clear there is no stable ABI. It has been useful as-is in the past. That's what I am offering. If that's not enough, no hard feelings, but someone else needs to continue then. All the best, Wolfram --pvtrej2bwhzfyplx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmZpxsEACgkQFA3kzBSg Kbb5LhAAq7J+u9AU3h27i893hHfBUdMFaOWvXvYAUCE7Ihm1awM4jeRX7zVMZ2v/ NbXFUj7xY4aM40fIEhcHfv4+eESY5ba72+3w8n8xkUgepmYCbzirZ2CetqgA4R6S y7bnz8Zb32bQAEPtLOeDc138+UOlI11LwYLk9aF5hdkRLGja0GVy8vXUb6N8Ioy9 ChOdx3OSqnhdkUOWHemErPpFC5QbtOVkXusvpdhSh3ixT+CMIXBAINHBeFgax8Z3 suaRT0jxA/F8utd3uGQZmW3BJTjpdJpPuzoRRD91TvfI4ZOTRmMSIJz+9nJlTfYw 0MIiNgRdIyD4xSjTIzOj5R2aZi6RgeJeqeyc9ILYoVaLG4/SGcZ0/LfE5IrJ/9rO VqrPcndc5MgzNexkacS9jG+x0StUTD6FXpePN9xAJ8Mz9lvZU51kGo3KNNWFYmlV TVqdLu73GdsCdn2IddJJ6L0lqb2pn+obcX1Hpjb/pcIn76swDehemGGEScmV4J65 pKRdc/5DrRf/jtlWVnU5Er+pKEL72nU7VyfQjfom62fQ5wRZVgyD6j0mp6jd63fZ h7JzLl2rbr0+JaGDn6eZLhjpvv5JFnb9uWnoL5CJSexICOYLJ8pbk89y6aZ5gxl2 wm4SK454E0Hs5Lz2qWkn63OOWHCMg+7Mqu4MslSH9dHBT1i5e64= =PsWW -----END PGP SIGNATURE----- --pvtrej2bwhzfyplx--