Received-SPF: pass (google.com: domain of linux-kernel+bounces-211912-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 12 Jun 2024 10:26:01 -0600
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Abdulrasaq Lawani <abdulrasaqolawani@gmail.com>
Cc: devicetree@vger.kernel.org, linux-sound@vger.kernel.org, 
 broonie@kernel.org, krzk+dt@kernel.org, skhan@linuxfoundation.org, 
 javier.carrasco.cruz@gmail.com, lgirdwood@gmail.com, 
 linux-kernel@vger.kernel.org, conor+dt@kernel.org
In-Reply-To: <20240612145903.497758-1-abdulrasaqolawani@gmail.com>
References: <20240612145903.497758-1-abdulrasaqolawani@gmail.com>
Message-Id: <171820956123.2881078.5853703079167472760.robh@kernel.org>
Subject: Re: [PATCH v2] dt-bindings: sound: Convert max98088 to dtschema


On Wed, 12 Jun 2024 10:59:01 -0400, Abdulrasaq Lawani wrote:
> Convert the max98088 audio codec txt bindings to DT schema.
> 
> Signed-off-by: Abdulrasaq Lawani <abdulrasaqolawani@gmail.com>
> ---
> Validated with dtschema and tested against samsung/exynos5800-peach-pi.dts.
> 
>  .../bindings/sound/maxim,max98088.txt         | 23 ---------
>  .../bindings/sound/maxim,max98088.yaml        | 47 +++++++++++++++++++
>  2 files changed, 47 insertions(+), 23 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/maxim,max98088.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98088.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/sound/maxim,max98088.example.dtb: /example-0/i2c/audio-codec@10: failed to match any schema with compatible: ['maxim,max98089']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240612145903.497758-1-abdulrasaqolawani@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.