Date: Wed, 06 Feb 2008 22:42:45 -0800 (PST)
Message-Id: <20080206.224245.228156843.davem@davemloft.net>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org, kay.sievers@vrfy.org
Subject: Re: partition sysfs OOPS in current GIT
From: David Miller <davem@davemloft.net>
In-Reply-To: <20080207064407.GA22963@suse.de>
References: <20080207054738.GB20902@suse.de>
	<20080206.220544.238067538.davem@davemloft.net>
	<20080207064407.GA22963@suse.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1266
Lines: 31

From: Greg KH <gregkh@suse.de>
Date: Wed, 6 Feb 2008 22:44:07 -0800

> On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote:
> > From: Greg KH <gregkh@suse.de>
> > Date: Wed, 6 Feb 2008 21:47:38 -0800
> > 
> > > On Wed, Feb 06, 2008 at 08:06:18PM -0800, David Miller wrote:
> > > > I redid the bisect to make sure it absolutely was that specific
> > > > changeset, and it is.
> > > 
> > > Thanks for doing that, I'll let you know when I have a patch to test.
> > 
> > I found the problem, it's the "whole_disk" partition attribute.
> > 
> > Look in fs/partitions/check.c:add_partition() where it tests the
> > ADDPART_FLAG_WHOLEDISK flag.
> 
> So, if you just comment out that whole "if (flags &
> ADDPART_FLAG_WHOLEDISK)" chunk, does the oops go away?  I think that is
> the real solution here as I don't see what this attribute is supposed to
> be showing.

See my other reply, it's supposed to just exist and be
a zero length file.  udev looks for it to determine
which partition is the "whole disk" partition
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/