Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp573514lqp; Wed, 12 Jun 2024 09:41:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWIdn0SUJjw/jVQ6fK4H4E8v1iAN5VHayu3jMk/ArZ6ra1UpqciuezA+U7KfKK6RHIDpk1WRy7+qIc3RvgBklJm3PkQcX5XaGLl2D+52w== X-Google-Smtp-Source: AGHT+IHvOILFsCGUMJ7aBpHf0FwdOH6VSUefVkfAwmC2+ocFGmHyxnX3xv9VpdMVfyzBjyAfcuTZ X-Received: by 2002:ac8:5716:0:b0:441:24e:6463 with SMTP id d75a77b69052e-4415ac99a2bmr23750321cf.50.1718210461192; Wed, 12 Jun 2024 09:41:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718210461; cv=pass; d=google.com; s=arc-20160816; b=XdyWPqwUq1UArObYtvkpDwlDMjG86H06C+gjuArUbMqiUjdGseO3eD+192ESTmT7ER HlJZ+bDaYzsbGNiJCY45NvT+N+qJyc/fR0rdJhsHSQQoiQUXDXMQMGlBewJGEEnaY0CS 1VFmM8Zx9GyozJ9BP5n6QGOfFGq+lpBE5QXX1iNQpHfAVmKB9yR4RXuBN6BvpALE/flK zzY+ScCsevpvF0NaDyusYKt4HvrZQosqhtLWDdUp8PN8xJ9ne0z77ET3O67Dpvdf2/Nc sud8uaT6bkKtaELUwb6yeARxDmgbxtRLM1uCOZmYIVQukKeSp3VBQqIEn1p5RYA7JLKL 0mFw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jRa2Q5cHuUuevC7oIlGSsUAwd7TrdeGMtMdw6xIKRkU=; fh=jVcFwdxGL9mk6ge4LhgRU1yz/BtbyfmdYKnsEthoACU=; b=0TsSMYpzOIegssZu/fVsAAjiKwpBW05EfbqkT+o5ZW6LDozhWI2YFyymlmj6fuTllZ SePKq5JwdyMg90kfWLIiBZQFwuLedIDGdx2pGQfL7kh6cb92XvrVtYDZ8CyvTQEZke2W cNuUVhz6x6dx4ccGGA92ij6UT/9hxVPCxsKEoDai6JYK6T9R9BBuwkuLs6Xi8jkwz8sL dUlDdw7CWbVCp+yVSSzdzWHO7uY11OeJT1IaVh4vNM24+g+fMTg255fCvcn9Piw9RFr3 7nCJ+lPsfGbCgwcqnren0T2Tqh0uCtPDxqNExVcW3otSt9zB7hQHgciXVDf1lXGnJG1k oq/w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Onyhj8Vn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-211926-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211926-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-440489b01b7si121395951cf.661.2024.06.12.09.41.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 09:41:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-211926-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Onyhj8Vn; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-211926-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211926-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CFEA41C219DB for ; Wed, 12 Jun 2024 16:41:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 072DA181BB0; Wed, 12 Jun 2024 16:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Onyhj8Vn" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26A7716F295; Wed, 12 Jun 2024 16:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718210444; cv=none; b=TCV+sDWR8F2eWL/BmBt/0uQ/Mp/bByOW+C7VzYJfT+9lxcoYmkIPoJgGvgs++WEqdu7gqG7OiMj6JQ48A6+WzHJWT+P8D5jUoQLgK6RyilOBXtCqTpLfwR1lghPX5czW5dfoHUfKkuhLvAXCxsyrfU2elZSWreZQUnfT9ABp72E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718210444; c=relaxed/simple; bh=85XKwtq8lgNQ9l2YL8a7SauGQb3hZbNGMy8WU/0vk1g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t2+qwRS+R7ZTYSAqZ1aJKYGKK5c66Xc5l99EXcQ4oRs2EvBkojqaWlvTLEybNL0CggFUGGOVq0FCT6GJpSVcyp2JjuAbVv6OYRzaIHCYLOHHLdnqm/9rS4mr1U9ILNf1n1soVEKZ+cqUgwg8dKHjOEd8YcUUdXl1xN0u0Gksfhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Onyhj8Vn; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43E9AC116B1; Wed, 12 Jun 2024 16:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718210444; bh=85XKwtq8lgNQ9l2YL8a7SauGQb3hZbNGMy8WU/0vk1g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Onyhj8VnaDXMhsbCz7cO+Y8QwfDHUHrbPdQuUwf3RtVAPOQVp6hFN36QZkn8UZyjj z1QiIOV9ySHhisFsBLEpfP2/jcgqX8ctchnG4WmeDsX3PaGsAEOnBNpF2HF8tMjpVI wD+mXurj7sKz1FUlW6atUkUhBcvK35uqQ0c26t3unHt78YjVQJVoj7018kqF8S5LHR LBWVa0N2JqW9XnK4rGJZskhVQOStjDYwhYUASlE46Z8ljlljsy1dHvta3r4ja0vywE cEK/TmxyBAu12SgetSgLfa+6PAMVBdf4AzaMXC8ia2LsIELW/GWOx4VmHhJS1NWL/C heUprjyrZFDQw== Date: Wed, 12 Jun 2024 17:40:39 +0100 From: Mark Brown To: Conor Dooley Cc: linux-mmc@vger.kernel.org, Conor Dooley , Ulf Hansson , cyril.jean@microchip.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-spi@vger.kernel.org Subject: Re: [RFC v1 2/3] spi: microchip-core-qspi: Add regular transfers Message-ID: References: <20240612-brigade-shell-1f626e7e592f@spud> <20240612-uphold-dinner-a47b4c44be18@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MdwxjcRzQ3pyUpUj" Content-Disposition: inline In-Reply-To: <20240612-uphold-dinner-a47b4c44be18@spud> X-Cookie: Your love life will be... interesting. --MdwxjcRzQ3pyUpUj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 12, 2024 at 04:48:32PM +0100, Conor Dooley wrote: > + //TODO: questionable robustness if both cs_change and cs_off toggle > + list_for_each_entry(t, &m->transfers, transfer_list) { > + //cs_change being set means we need to re-enable Is it not possible to implement prepare_message() and transfer_one() rather than open coding all this? --MdwxjcRzQ3pyUpUj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZpz4YACgkQJNaLcl1U h9AVQwf+MGtExjI/bWW1yGC4RO+HV4ZjtGV3c7j96NAiLdf+87svqV9in+GrvgRZ Gv3J0UZoID/NR9sJoPYXZ1j9KR7cD/ps2pScjog4b8t7K1RKGzO1lck5WOlh+c4E D9WThX1LgACsUO8N0tplHE2OK/86wJe6LiSrJttKezDV+RpuvevMMAFs1vv9M+CV abVC0AHa//7OZ9gYfzg3tLeclZCtrnHSvfG6ftXwso1glyYK3ky6sR+JN0BwvoXV 4o8mXO6+SyWkx7p/8FVVZ3qM21w3UHodxvslwMKAlXmAIdXes8c4v1wlUUuzr4sK sSThubOWebv8HG4Pc3SfyEldXQ6CHQ== =pdjw -----END PGP SIGNATURE----- --MdwxjcRzQ3pyUpUj--