Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755348AbYBGHCo (ORCPT ); Thu, 7 Feb 2008 02:02:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752964AbYBGHCe (ORCPT ); Thu, 7 Feb 2008 02:02:34 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34625 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752929AbYBGHCd (ORCPT ); Thu, 7 Feb 2008 02:02:33 -0500 Date: Wed, 6 Feb 2008 23:00:44 -0800 From: Greg KH To: David Miller Cc: linux-kernel@vger.kernel.org, kay.sievers@vrfy.org Subject: Re: partition sysfs OOPS in current GIT Message-ID: <20080207070044.GA4851@suse.de> References: <20080207054738.GB20902@suse.de> <20080206.220544.238067538.davem@davemloft.net> <20080207064210.GA22896@suse.de> <20080206.223944.200455039.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080206.223944.200455039.davem@davemloft.net> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1806 Lines: 52 On Wed, Feb 06, 2008 at 10:39:44PM -0800, David Miller wrote: > From: Greg KH > Date: Wed, 6 Feb 2008 22:42:10 -0800 > > > On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote: > > > I found the problem, it's the "whole_disk" partition attribute. > > > > I don't understand that code at all, on 2.6.24, what does reading that > > file give you? At first glance, I don't see how that file would spit > > out anything and not give you the same kind of oops. > > > > you are in a maze of kobject pointers, all alike... > > It's supposed to just exist, and be an empty zero length file. > That's why it's given no ->show method pointer. > > It's existence just means that the partition is a "whole disk" > partition type. Can you try this patch to see if it solves the oops, and that the file is still there and works properly? thanks, greg k-h --- fs/partitions/check.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) --- a/fs/partitions/check.c +++ b/fs/partitions/check.c @@ -353,11 +353,9 @@ void add_partition(struct gendisk *disk, partition_sysfs_add_subdir(p); p->dev.uevent_suppress = 0; if (flags & ADDPART_FLAG_WHOLEDISK) { - static struct attribute addpartattr = { - .name = "whole_disk", - .mode = S_IRUSR | S_IRGRP | S_IROTH, - }; - err = sysfs_create_file(&p->dev.kobj, &addpartattr); + static DEVICE_ATTR(whole_disk, S_IRUSR | S_IRGRP | S_IROTH, + NULL, NULL); + err = device_create_file(&p->dev, &dev_attr_whole_disk); } /* suppress uevent if the disk supresses it */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/