Date: Wed, 06 Feb 2008 23:11:44 -0800 (PST)
Message-Id: <20080206.231144.174648341.davem@davemloft.net>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org, kay.sievers@vrfy.org
Subject: Re: partition sysfs OOPS in current GIT
From: David Miller <davem@davemloft.net>
In-Reply-To: <20080207070044.GA4851@suse.de>
References: <20080207064210.GA22896@suse.de>
	<20080206.223944.200455039.davem@davemloft.net>
	<20080207070044.GA4851@suse.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1285
Lines: 32

From: Greg KH <gregkh@suse.de>
Date: Wed, 6 Feb 2008 23:00:44 -0800

> On Wed, Feb 06, 2008 at 10:39:44PM -0800, David Miller wrote:
> > From: Greg KH <gregkh@suse.de>
> > Date: Wed, 6 Feb 2008 22:42:10 -0800
> > 
> > > On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote:
> > > > I found the problem, it's the "whole_disk" partition attribute.
> > > 
> > > I don't understand that code at all, on 2.6.24, what does reading that
> > > file give you?  At first glance, I don't see how that file would spit
> > > out anything and not give you the same kind of oops.
> > > 
> > > you are in a maze of kobject pointers, all alike...
> > 
> > It's supposed to just exist, and be an empty zero length file.
> > That's why it's given no ->show method pointer.
> > 
> > It's existence just means that the partition is a "whole disk"
> > partition type.
> 
> Can you try this patch to see if it solves the oops, and that the file
> is still there and works properly?

It doesn't crash, but the file returns -EIO instead of zero when read.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/