Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756020AbYBGHQR (ORCPT ); Thu, 7 Feb 2008 02:16:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754121AbYBGHQE (ORCPT ); Thu, 7 Feb 2008 02:16:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:35481 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753977AbYBGHQC (ORCPT ); Thu, 7 Feb 2008 02:16:02 -0500 Date: Wed, 6 Feb 2008 23:20:30 -0800 From: Greg KH To: David Miller Cc: linux-kernel@vger.kernel.org, kay.sievers@vrfy.org Subject: Re: partition sysfs OOPS in current GIT Message-ID: <20080207072030.GA24242@suse.de> References: <20080207064210.GA22896@suse.de> <20080206.223944.200455039.davem@davemloft.net> <20080207070044.GA4851@suse.de> <20080206.231144.174648341.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080206.231144.174648341.davem@davemloft.net> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1545 Lines: 41 On Wed, Feb 06, 2008 at 11:11:44PM -0800, David Miller wrote: > From: Greg KH > Date: Wed, 6 Feb 2008 23:00:44 -0800 > > > On Wed, Feb 06, 2008 at 10:39:44PM -0800, David Miller wrote: > > > From: Greg KH > > > Date: Wed, 6 Feb 2008 22:42:10 -0800 > > > > > > > On Wed, Feb 06, 2008 at 10:05:44PM -0800, David Miller wrote: > > > > > I found the problem, it's the "whole_disk" partition attribute. > > > > > > > > I don't understand that code at all, on 2.6.24, what does reading that > > > > file give you? At first glance, I don't see how that file would spit > > > > out anything and not give you the same kind of oops. > > > > > > > > you are in a maze of kobject pointers, all alike... > > > > > > It's supposed to just exist, and be an empty zero length file. > > > That's why it's given no ->show method pointer. > > > > > > It's existence just means that the partition is a "whole disk" > > > partition type. > > > > Can you try this patch to see if it solves the oops, and that the file > > is still there and works properly? > > It doesn't crash, but the file returns -EIO instead of zero when read. Picky, picky, picky :) It's odd that the original one didn't also do that, but I'll fix that up properly, let me try again... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/