Received-SPF: pass (google.com: domain of linux-kernel+bounces-211999-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 12 Jun 2024 11:24:11 -0600
From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Keith Busch <kbusch@meta.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
	"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
	"paulmck@kernel.org" <paulmck@kernel.org>,
	"davidgow@google.com" <davidgow@google.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"venkat88@linux.vnet.ibm.com" <venkat88@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] nvme: fix namespace removal list
Message-ID: <ZmnZu-QceHYbYf0S@kbusch-mbp.dhcp.thefacebook.com>
References: <20240612155135.3060667-1-kbusch@meta.com>
 <20240612155135.3060667-2-kbusch@meta.com>
 <5cb2c809-bfa3-4389-8f60-ea0edf742724@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5cb2c809-bfa3-4389-8f60-ea0edf742724@nvidia.com>

On Wed, Jun 12, 2024 at 05:20:48PM +0000, Chaitanya Kulkarni wrote:
> On 6/12/24 08:51, Keith Busch wrote:
> > From: Keith Busch<kbusch@kernel.org>
> >
> > This function wants to move a subset of a list from an element to the
> > end to another list, so do that with the new list_cut helper instead of
> > using the wrong list splice.
> >
> > Fixes: be647e2c76b27f4 ("nvme: use srcu for iterating namespace list")
> > Reported-by: Venkat Rao Bagalkote<venkat88@linux.vnet.ibm.com>
> > Tested-by: Venkat Rao Bagalkote<venkat88@linux.vnet.ibm.com>
> > Signed-off-by: Keith Busch<kbusch@kernel.org>
> 
> not a blocker, but it'd be really useful if we can get a blktests for this,
> I've asked OP to provide steps at least ...

Recreate the original report: detach the highest namespace id from your
controller. Let's say it's nsid 10, and let's assume your ctrlid is 0:

  # nvme detach-ns /dev/nvme0 -c 0 -n 10

blktests supposedly has something that detaches namespaces through the
nvmet module, but it doesn't seem to be catching anything.