Received-SPF: pass (google.com: domain of linux-kernel+bounces-212003-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>
To: Oscar Salvador <osalvador@suse.de>, Andrew Morton
	<akpm@linux-foundation.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>, Muchun Song
	<muchun.song@linux.dev>,
	"syzbot+569ed13f4054f271087b@syzkaller.appspotmail.com"
	<syzbot+569ed13f4054f271087b@syzkaller.appspotmail.com>
Subject: RE: [PATCH] mm/hugetlb: Guard dequeue_hugetlb_folio_nodemask against
 NUMA_NO_NODE uses
Thread-Topic: [PATCH] mm/hugetlb: Guard dequeue_hugetlb_folio_nodemask against
 NUMA_NO_NODE uses
Thread-Index: AQHavKK4B0EzVOxbPk2t2TFNeotrHrHEYELQ
Date: Wed, 12 Jun 2024 17:25:45 +0000
Message-ID: <IA0PR11MB71853C005303041A07A5CF12F8C02@IA0PR11MB7185.namprd11.prod.outlook.com>
References: <20240612082936.10867-1-osalvador@suse.de>
In-Reply-To: <20240612082936.10867-1-osalvador@suse.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G5CMHLkLoabflzIsnncATfkot6oaQo44II+T1YXzQmx9EZp2CVjnzcRKiaYJ?=
 =?us-ascii?Q?TT/pReVedYVL7eGrzpimo/x6kob6ahUDm40MSEYkiHsKQ45pIODK7v1EQ06G?=
 =?us-ascii?Q?ClYZ9fqhDZdoK/pemMGQndGbJXdJAcAsR6uINJmzlaBYsZRShRvw+TgmO1I7?=
 =?us-ascii?Q?dXlOKYbyQs4kbAHlaXtQnao6Spr9TNMEcE+dhov6OZo5uWrTXMTQJViORAi6?=
 =?us-ascii?Q?o1gB2jog7bRqs4PwZ1IYFlTfXOhYtvDYZqY/vH3LYen9dfyo93YVxf6gSwQW?=
 =?us-ascii?Q?zB4a3mRrCpf7qb2uDxajabamqgkON9ceTzVBKWYa1jGu6PmyZlH52h8x5k9X?=
 =?us-ascii?Q?gaOd+vBBd1sM0iTBxOx40sLEg8Smz96ZQYC3qi5SrTMtKKFhOXUqBYQrnT9E?=
 =?us-ascii?Q?NTntuYDrwh0Vb9/oDvztYJaJAffLqTTQ6sDKBGbYfNb/LK0u3bjBZ5JrJgYH?=
 =?us-ascii?Q?HUSJgJOC9D+gZEugbop2TR5OxdV1tYFbtTP3nxAI4hCrHJMBqlBCdHhe5nD+?=
 =?us-ascii?Q?9tNFRaHlv/l/GpTBqrbRw6ZYseBCztCz6YS3qHJwXID7duQ70HfbI4mq2UAV?=
 =?us-ascii?Q?Tu5ZAY+mX9V52O0O5fVx0T88XftUct0NdPxW88h3iCNCzq+pPopKQ+HuwqXY?=
 =?us-ascii?Q?tk/p2wKPXaebdUz/Qk4SLjcIyxg/DKFfgymXnCDVNxfF9lLuCu2laBX8EBRq?=
 =?us-ascii?Q?VBjUUebdK8abn8n5I11z9JBBHzgK4HxGb/ucy9HhhOR2BB/xMC9Wn4vTB+ad?=
 =?us-ascii?Q?1vR5mrg27SyNhTdDI3yk2xNu95VKyUHbhWv0FKxIGwqJ7bbL/urW4S+BYyZI?=
 =?us-ascii?Q?f76w2ziaQNSIqdBQADcPogcmrlOyHO4H4s9KFt7eChvzfT4iZBbZgpNUl9O8?=
 =?us-ascii?Q?Zo/X37X73iYK5JHNEyQM+JmB56wjUgspQeMOq6ETWj1MxtvlzVu+xMlsF3Sz?=
 =?us-ascii?Q?ejSW6cRpWO1QMGWU+RwUND19z3nUCeNFGF32oz8w3SHSQw2G9qnkJ/BBbMdQ?=
 =?us-ascii?Q?zLsMR06LVdweJWmvYkl668misk1HVUMxz42BF79jM0BbPLhqtmZ7iUThT2yL?=
 =?us-ascii?Q?/kvqMtyA06dKtJf+7K0poIgA5FOvOBmVfGNAqwBPO9hGGt6pCKcws95/fJ2b?=
 =?us-ascii?Q?C1hqekvdczAyLQxw7L3+lFKV1Twt+cwF16buOUgM3oOrX6yUf0kKANFAS/2x?=
 =?us-ascii?Q?yRx4dh7OMtu9q3bakH5nD4mhEXetatfDoGSY7Nm6rO7NuLrmc6t//fDOg7es?=
 =?us-ascii?Q?LrYMqIGZZFUnn1R2e/QbyAF34y0tFNAWsZXCQJ7aXXJ9MZHaBH0sPEspCV3q?=
 =?us-ascii?Q?93xWnCMC6R896rZs9J0a1rS7qkrfsuvTazc9VKBSue7ef3CmJPGULSK0ShMB?=
 =?us-ascii?Q?LsiFk9o8JxWKGxTcmpPG3eg0xByXf4xvA82Fziec9plvQ2d8CnqYVin3k1oy?=
 =?us-ascii?Q?QqJZwffWqVx+913JxmBA0xTRFqc0zs2pm0l68n27wvGIu6psF71dZJZaJOmz?=
 =?us-ascii?Q?/1B9T091/hUF1lHXau/HsqPrD6zXVbwGalIDky6yZ7+qjP6qij2g22SkCr9p?=
 =?us-ascii?Q?6LYGAAoi98eLN4I6d7cJypbknvqIhKRFCnCcxbZ6?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB7185.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8ec5229-b307-4b13-c8f2-08dc8b04b1a0
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2024 17:25:45.5865
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VSsviDP64BzU49aoeSNuMCZckx9LYCmm/7cPT5r8pD0muquOcPS34HZ6754dA0rCt+Rl/VxiYMuSJeVOcWjv06Iwk+aSa4vN2a5LIQ6n3aU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7253
X-OriginatorOrg: intel.com

> dequeue_hugetlb_folio_nodemask() expects a preferred node where to get
> the
> hugetlb page from.
> It does not expect, though, users to pass NUMA_NO_NODE, otherwise we
> will
> get trash when trying to get the zonelist from that node.
> All current users are careful enough to not pass NUMA_NO_NODE, but
> it opens the door for new users to get this wrong since it is not
> documented [0].
> Guard against this by getting the local nid if NUMA_NO_NODE was passed.
>=20
> [0] https://lore.kernel.org/linux-
> mm/0000000000004f12bb061a9acf07@google.com/
>=20
> Closes: https://lore.kernel.org/linux-
> mm/0000000000004f12bb061a9acf07@google.com/
> Reported-and-tested-by:
> syzbot+569ed13f4054f271087b@syzkaller.appspotmail.com
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---
>  mm/hugetlb.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 3518321f6598..6a5ea898e4da 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1355,6 +1355,10 @@ static struct folio
> *dequeue_hugetlb_folio_nodemask(struct hstate *h, gfp_t gfp_
>  	struct zoneref *z;
>  	int node =3D NUMA_NO_NODE;
>=20
> +	/* 'nid' should not be NUMA_NO_NODE. Try to catch any misuse of it
> and rectifiy. */
> +	if (nid =3D=3D NUMA_NO_NODE)
> +		nid =3D numa_node_id();
> +
>  	zonelist =3D node_zonelist(nid, gfp_mask);
Acked-by: Vivek Kasireddy <vivek.kasireddy@intel.com>

>=20
>  retry_cpuset:
> --
> 2.45.2