Received-SPF: pass (google.com: domain of linux-kernel+bounces-212069-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 12 Jun 2024 14:28:09 -0400
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org, gregkh@linuxfoundation.org, linux-mm@kvack.org,
        surenb@google.com, rppt@kernel.org, gerd.rausch@oracle.com
Subject: Re: [PATCH v4 3/7] fs/procfs: add build ID fetching to PROCMAP_QUERY
 API
Message-ID: <uofb56lk6isrwqf42ilky7r3wa4tetaaze2m2ususzqpbnftkw@hwskh5quvlfm>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@oracle.com>, 
	Andrii Nakryiko <andrii@kernel.org>, linux-fsdevel@vger.kernel.org, brauner@kernel.org, 
	viro@zeniv.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, 
	bpf@vger.kernel.org, gregkh@linuxfoundation.org, linux-mm@kvack.org, 
	surenb@google.com, rppt@kernel.org, gerd.rausch@oracle.com
References: <20240611110058.3444968-1-andrii@kernel.org>
 <20240611110058.3444968-4-andrii@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240611110058.3444968-4-andrii@kernel.org>
User-Agent: NeoMutt/20231103
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?H9oEHnVfE1fAkKNosmnKrwyVFavBYePeubicNScJUZFJP/YQwwf3Muf/RYqo?=
 =?us-ascii?Q?bwmTdP+ZovdWyIu1KUJ4mXwcXpET2uJYplslCWf0kZS3WEIi/XSdGoq/ovYS?=
 =?us-ascii?Q?6iws2mBAFOnKqdgoKCLIXdgsiEvFbRFzCmsNvuejYMUIhRiUJ7jYzvbjcFlw?=
 =?us-ascii?Q?0TM92+SURVf80cOuykz9UQjs6t2mwdw3FyO0Db5Ae3hfj7dtYXuJGuL6/w+E?=
 =?us-ascii?Q?zDuEPHrWBg0S1vnSE1kDrcyYrhOpJw6Vc8ztDVnhf2T4GTuFIXCwuylwob7X?=
 =?us-ascii?Q?bmWzMKsSCH3hsd8S/G37vEZSA/NGWjmINH1dtmzpfbDWtOWDYm66VsnNTuON?=
 =?us-ascii?Q?1xEyVD0cOgVOmkZKbxnVko6qw42JZAybdxLTkR1Bfauk80C+qQS0kfbAhbLw?=
 =?us-ascii?Q?xZC5iTKQWRk4JNqsP4VNB6YGPi/tUon0HcNsFI5CGYpoMwzvmxWeUXQXsZEw?=
 =?us-ascii?Q?bPmfohvyzhODehX0XFVFggK9qwhgFwwirO4N3JNplOaWprywWFJ/TSNauLNO?=
 =?us-ascii?Q?5V5q3BUYDlQ4UDzJr/jbpt0t17p4VEzqBqBkvD7NL3qbrh+50T3EKJ6ix/dB?=
 =?us-ascii?Q?i3YYxuZ/b0Zu98snk5ItAaIu1ad+w0/9nQeazK9Qqsraja648gxJ9trsfuoR?=
 =?us-ascii?Q?P4iQu73Avhtp0SbNf2ad/QkwRE6C3jiTVOwjbFRXJe5PKUYuCRnqTElodOI8?=
 =?us-ascii?Q?gBiCLhH7OK5WPPqajzolzVsXBk1Qs5WZ2Jff9NVMtVboQHZrYBg/JIF+XqsB?=
 =?us-ascii?Q?DBpwoc//f3mHT9y5mZ7m9r6bri++SxFG61DQ1EWaoRTF6AEyoxiaxPb0CmLl?=
 =?us-ascii?Q?tl3cCnXCc8pZCLNik5mESUcgY3WsyeMLaTdmBKlTlnN3h8amnecBP5SUCJbm?=
 =?us-ascii?Q?JIge3KcD4zyEqxZUH24VD3VIAwwQYN3talby7kTM3+YJiyjrOrPk+ccIBqsc?=
 =?us-ascii?Q?YUtVZCWcp1ZQnwtZDZ2Et22S7g93R3wI7NrEwz1wYVxWaaMnYEWmr1JMkFG1?=
 =?us-ascii?Q?7QzV4E2Ya3WSgXx++vyxKh/IxupGPTCBWoypKNJ6u6AZnRrJvbEeNEn5lF35?=
 =?us-ascii?Q?VAqut4g7LgTkI79Th6LjGLxdq1c1Q+zUuIy+EAw5d49F4t+4KEYxVM3/b6Qd?=
 =?us-ascii?Q?ltlMJjpEpiSEr36a9F+ckCwptDAhMrKpbNUKgEJC9OYIeDDQSuPMTTfz0E1T?=
 =?us-ascii?Q?fI/r1fXiWNN86DqnAXtS3rGZXx19OJ+3Arvhvo+Gk7HjuB33RkEGq+5ueiVb?=
 =?us-ascii?Q?2IKU5weVA9DndH7yHcEacr3aA9DQd7o1CgYj6IVfXb1H+syQLHAapZ5UZ9dD?=
 =?us-ascii?Q?hgPjmdRuSdkesBAD1GFB/q0cks72QFa0XmqPEMIkb61V81ihrclqTJ6t4yPf?=
 =?us-ascii?Q?geGRFo8X0WL7yQzjmLKmpoQHZnrgG515CahGb6jBEwYAmmUhQNLrUHm3tiTv?=
 =?us-ascii?Q?NEpeQWqraE0L50shHSXxSPQuBzHVhxyy2IwKI4PAgyukBxg/Zoj0fiMOP5I/?=
 =?us-ascii?Q?scYxpPqk/9f+eeDLIJIO4crOFXoAuus7v+Uf8QLm/xOMitLB0xRD+RW/7/4a?=
 =?us-ascii?Q?gHubd6Bf1kV4LjCHO48lLFKXbZY8wVvEkOK96IE9?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	RhVd8uwP0PocfIQGEV0z4TykLtge+vLHXvzsKUZuPGEhK8TiE2bpxCTdRjEBlCHlkN2PTil2XMzQ3055xWy5LDt1DozKcD1o0ToGzJnvwIbyqi+dkxa4OELdR3xnc3e9ylJHGO6Q6nQnPHGjYPNAZ4wRGIaTCRxivatQrTwRVwgVIqmZKTBX0EEdV6/9gLevTkQ99Apv7Si/8iTvPjX6TgGPu7FpwMFgRwfH3DX2Ea9QVfCIgdzU/Gj1ILTeFx1r0DLi7rxaSzJrH77DAevCth1t5iGmB98yW2g2BsMDUQzuHyADVicIAlPbCpqGwpsQxaJ500RJwtkAuiHdHHg/pMOB2v2BwmDXURcSmLCr+iPPBW9jPq0+Uk7NtyEjOlVvej1FGclWIsgyQHesB83VbGDYFBXpXDKMR4Ed0TSHwLEMprHgnOPmwK6YWYpmGzvPQbDRLa487F1N7tz8EGb3diAdmLA7fTTu3eLbh+wyFY3iCWfAOiZBFreknZ+ZBXqdUQ/AV6obXchFAdP4j2STzMrQloLYBl7L6p4hpMWqZejEm6VzKh0u6W8X2BlsHhoicLmytAo8G5nLaLMBouqVXzWh1oZhailxAhdWtiXMw98=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8deea059-752d-4e35-349b-08dc8b0d6a90
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 18:28:12.0180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uztJBvHvEjhme2QUIZ+mTwaoAvyCFH+S4vhUZoFMnCxyIKJLUySqjRyLMnCT4CBPMtadWntYKkC0uFX5fyegsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5784
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-12_09,2024-06-12_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxscore=0
 mlxlogscore=694 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2406120131
X-Proofpoint-GUID: wQcyU5rNRp76FpF08C5GUkVaWP9xP7cP
X-Proofpoint-ORIG-GUID: wQcyU5rNRp76FpF08C5GUkVaWP9xP7cP

* Andrii Nakryiko <andrii@kernel.org> [240611 07:01]:
> The need to get ELF build ID reliably is an important aspect when
> dealing with profiling and stack trace symbolization, and
> /proc/<pid>/maps textual representation doesn't help with this.
> 
> To get backing file's ELF build ID, application has to first resolve
> VMA, then use it's start/end address range to follow a special
> /proc/<pid>/map_files/<start>-<end> symlink to open the ELF file (this
> is necessary because backing file might have been removed from the disk
> or was already replaced with another binary in the same file path.

Can we please also add the vma_kernel_pagesize() to this interface?  We
have a user who parses the entire smaps file specifically for
KernelPageSize, which could be included for a low cost here.

The only way to get this information today seems to be from the
/proc/<pid>/smaps file and it is necessary for certain hugepage calls
for alignment reasons (otherwise the calls fail with -EINVAL).  Adding
this extra information would allow for another text-parsing user to
switch to this API.

Thanks,
Liam