Received-SPF: pass (google.com: domain of linux-kernel+bounces-212093-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <CAJg=8jz4OwA9LdXtWJuPup+wGVJ8kKFXSboT3G8kjPXBSa-qHA@mail.gmail.com>
 <20240612-hofiert-hymne-11f5a03b7e73@brauner>
In-Reply-To: <20240612-hofiert-hymne-11f5a03b7e73@brauner>
From: Marius Fleischer <fleischermarius@gmail.com>
Date: Wed, 12 Jun 2024 11:36:34 -0700
Message-ID: <CAJg=8jxMZ16pCEHTyv3Xr0dcHRYdwEZ6ZshXkQPYMXbNfkVTvg@mail.gmail.com>
Subject: Re: possible deadlock in freeze_super
To: brauner@kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org, 
	linux-kernel@vger.kernel.org, syzkaller@googlegroups.com, 
	harrisonmichaelgreen@gmail.com
Content-Type: text/plain; charset="UTF-8"

Hi Christian,

Thanks for your response!

> > ======================================================
> > description: possible deadlock in freeze_super
> > affected file: fs/super.c
> > kernel version: 5.15.159
> > kernel commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
>
> I'm sorry but this is really inconsistent information.
> The kernel version points to 5.15.159. The commit referenced right after
> is for v6.9 though and it goes on...

I'm very sorry for the mistake in my previous email. The kernel
version is correct but the commit hash is not. It should have
been83655231580bc07485a4ac2a6c971c3a175dd27d.


>
> >        freeze_go_sync+0x1d6/0x320 fs/gfs2/glops.c:584
>
> That function doesn't exist on v6.9 and has been removed in
> commit b77b4a4815a9 ("gfs2: Rework freeze / thaw logic") which fixes the
> deadlock you supposedly detected. So, this must be from a kernel prior
> to v6.5.
>

Do you think it might be worth it to port the patch that you mentioned
back to v5.15?

Wishing you a nice day!

Best,
Marius