Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp658722lqp; Wed, 12 Jun 2024 12:09:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV8CD6vWRtRtuOYV6H3HiqgUaGhe1+nJcRyrAuB/0cR01FxfhOMC3SjBGxBEaK40MeF76/Gp0LuzNT0KpajYdDkqJgAcKoNkXDxZNla2g== X-Google-Smtp-Source: AGHT+IF/6MQd2QY9c0Vf+/MZon6Mwxo8RRlrhvi9pmuMH6gcbeUlzJPiio7L1t6FH/8zcBkgOG91 X-Received: by 2002:a17:902:dacf:b0:1f8:3658:c893 with SMTP id d9443c01a7336-1f83b661840mr34047365ad.32.1718219355724; Wed, 12 Jun 2024 12:09:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718219355; cv=pass; d=google.com; s=arc-20160816; b=C7MDqrehOwqthHpYRmgiyyIbMrCLOnWPjjKJNcB2GoJ7F3tsC+W+/hCS+0Ml//8G/x CaQh1zguCPTwbHu6gACgHkX5t5WXDbDGPH2DRSWsCvQQzNvS3dlQyQgL5LrhkoYblBfD PNSweVebslgHjECulm3Cvvif9iD5F4kJELCd8WvVNzZwNawOI4byzYHAPzhyWfU1kTRu YtO6NolgeyLQTd+yNjAGR/SNQC/c0LSCslj4LFUE1YaQWY80X5+U3CKtYoiEE+zm1S1q P0dg7qfdqYxGNkWdbbo39QGn4TxPFcQyJByVUS6R8YbfvP3EHfKZfGPOiwUHuF6HD2c8 v7lg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TB6Z0sKvymLochdIiF63c/oqmpyetKA3fPFSRbBUZjo=; fh=aie918drKqAaLtBBcevmkVAjHNfONtdn0N46cKjn+fc=; b=ka+wRh4fjsN/c4dzzfT86mHWdHU4yyQoRkN0JAeNDyxezfch1oJd/SErkbuKfN/TC2 19UrjD1oM73ZikXmzFsC1/HyDh+ExEwHV/Gce8KEvsA/TlG6nvGaxFlCCMimBQaI1TLz Uh6Xy25VAOZAJeJHIAv0bWMijHROeG26EAT4Wz2avvQADfz+Y9vhtk/Bdu4vfkGbFz8x rw739B0H6nQ0u9e3A4em6zhv7eqtlELquPBRrhBtZUBxLSDx+lCFDzZHefEDe8M1nwHd 8NzY1O3OLcNjjx4iFXqgQBcvjpL11/efYcRe0Pqj0Vx983bXyu/FQIMfn2C0Yilu9XKb GGQA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YnIdIh9G; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-212112-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212112-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f7178e639csi60253155ad.176.2024.06.12.12.09.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 12:09:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-212112-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YnIdIh9G; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-212112-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212112-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 19238B26360 for ; Wed, 12 Jun 2024 18:45:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 262E64EB45; Wed, 12 Jun 2024 18:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YnIdIh9G" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34117757E5; Wed, 12 Jun 2024 18:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718217873; cv=none; b=YRE+yXq/ZnUMIvvjN+5uMLxowbYTPYoWm03kyXpvozg2FbNlYgvYjGfdKZTqNpMijrY/Sp07g/s1+5rlmvXM0yz23sumkT60nBabuI7uSc3P+xtmEU3cCN5pLr4I7Jr+5S5JMjdOsZTkrBlcmNK3Pwra02yRjbai7rESLD7+mkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718217873; c=relaxed/simple; bh=yqaEOGVGz/BenIqXBokoUcl0MRlmm1/UI7MPcy+JMbI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=swIOj+3mlTAYEvbUDmC3Fu0rQJI6WKPNMFiJQNtSNMXIO8JfUfpaMWrjKxHAcJcBgSwXVgAp8w4dUES7QLsfQpOxq9xzysuLQqKZbzg94aP1H9CRkBEt94eNk69Z/yLh7lwqxjpAQrsjIa3gOjcLQtfK8st6OCfog4e/9SL9zt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YnIdIh9G; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3A5EC116B1; Wed, 12 Jun 2024 18:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718217870; bh=yqaEOGVGz/BenIqXBokoUcl0MRlmm1/UI7MPcy+JMbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YnIdIh9GKOd77HAfLlrrY3rPi1M8c9CWwC/vR2tfplbfJSafpnCSXuRVwQwe+NX8P i08JylThZesu0MVSXTKvVCJ16tEnrkfByE58j8SR6yqNP7ovYvlJzf2rleNXUwMKPg CGl+2p2ojDEHNwpTgUavUVtksFFEuGIbUMTZpoQxMrIEhAmXjzk9ZOQRf7VRdvHUFr joEDK63vJKyH98tR/viDwrxCnET4lkDfdkFGNnEszDIiBvWJWaBS/xfsmFHFUASkLr x0hxZeJHJ0oCQyLp+IFkgd7sjqIN896OULF7pie2E6xPa0eC7SnRooW8PadIClT5MY vFnC2zsBBURQg== Date: Wed, 12 Jun 2024 11:44:30 -0700 From: Kees Cook To: Amer Al Shanawany Cc: Andy Lutomirski , Will Drewry , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Carrasco , kernel test robot , Shuah Khan Subject: Re: [PATCH v3] selftests: seccomp: fix format-zero-length warnings Message-ID: <202406121144.0EE6C17FF@keescook> References: <43e24489-a3af-4e53-afc6-ff1dd9462ee2@linuxfoundation.org> <20240611151638.5767-1-amer.shanawany@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611151638.5767-1-amer.shanawany@gmail.com> On Tue, Jun 11, 2024 at 05:16:08PM +0200, Amer Al Shanawany wrote: > fix the following errors by using string format specifier and an empty > parameter: > > seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format > string [-Wformat-zero-length] > 197 | ksft_print_msg(""); > | ^~ > seccomp_benchmark.c:202:24: warning: zero-length gnu_printf format > string [-Wformat-zero-length] > 202 | ksft_print_msg(""); > | ^~ > seccomp_benchmark.c:204:24: warning: zero-length gnu_printf format > string [-Wformat-zero-length] > 204 | ksft_print_msg(""); > | ^~ > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202312260235.Uj5ug8K9-lkp@intel.com/ > Suggested-by: Kees Cook > Signed-off-by: Amer Al Shanawany Thanks! Reviewed-by: Kees Cook -- Kees Cook