Received-SPF: pass (google.com: domain of linux-kernel+bounces-212189-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5
Precedence: bulk
MIME-Version: 1.0
Message-Id: <7f258a4c-6048-4718-851d-4768789bc5e1@app.fastmail.com>
In-Reply-To: <20240612160038.522924-1-steven.price@arm.com>
References: <20240612160038.522924-1-steven.price@arm.com>
Date: Wed, 12 Jun 2024 22:02:50 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Steven Price" <steven.price@arm.com>
Cc: Linux-Arch <linux-arch@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixmap: Remove unused set_fixmap_offset_io()
Content-Type: text/plain

On Wed, Jun 12, 2024, at 18:00, Steven Price wrote:
> The macro set_fixmap_offset_io() was added in commit f774b7d10e21
> ("arm64: fixmap: fix missing sub-page offset for earlyprintk") but then
> commit 8ef0ed95ee04 ("arm64: remove arch specific earlyprintk") removed
> the file causing the only user to be removed when the two commits were
> merged. Since this has never been used again since the v3.15 release
> remove it.
>
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> This came up because for Arm CCA there is a need to override
> set_fixmap_io() [1] and rather than also update set_fixmap_offset_io() I
> thought it would be better to just drop the unused macro.
>
> [1] https://lore.kernel.org/lkml/20240605093006.145492-6-steven.price@arm.com/

I assume you want to keep this with your other patch, so

Acked-by: Arnd Bergmann <arnd@arndb.de>