Received-SPF: pass (google.com: domain of linux-kernel+bounces-212270-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 12 Jun 2024 16:18:16 -0500
From: Ira Weiny <ira.weiny@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Dan Williams
	<dan.j.williams@intel.com>
CC: <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>, Vishal Verma
	<vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>, Ira Weiny
	<ira.weiny@intel.com>
Subject: Re: [PATCH] nvdimm: make nd_class constant
Message-ID: <666a10986e8e4_20324e2946b@iweiny-mobl.notmuch>
References: <2024061041-grandkid-coherence-19b0@gregkh>
 <66673b8a1ec86_12552029457@dwillia2-xfh.jf.intel.com.notmuch>
 <2024061206-unleveled-seduce-9861@gregkh>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2024061206-unleveled-seduce-9861@gregkh>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3chimejPLZAHv2M17COTTLpdQaCuu1U9ssxjUDpDH+vRAHyxpMsLmZ7GtmUj?=
 =?us-ascii?Q?JSrvHzjHaMNhDp/SA7CIc+DV5fwzyjYJ0B8JdloPXZkqOMzrbJvGm+cictyH?=
 =?us-ascii?Q?VCfm1DzsO3D95PPyDYIuyKMpR3Yol9xFQ39ib0p4boKkRzwx6yRoV4UTZgs5?=
 =?us-ascii?Q?oVYWd+Ojit099vddwUdFWZMFlJoiEDrIeWO2eUhmg1ufDkQNeuZvefQVeuaR?=
 =?us-ascii?Q?KR9j0seG+mViQyCl3AIrN8YU5KcnucDQF7pcw7jOhzxfAsaZYa0s7bqlGwAr?=
 =?us-ascii?Q?BMV35f64XyRmxSg8weKwQEm/kkST/zDqk0aS/gwWQV7RbKmUpu2PA0SDGFT2?=
 =?us-ascii?Q?RIZqqYCZnWjCGzKgWsY9Z0HEehcxc+CnY9AMayVPr1oXJdDJDQtdpkKRktpr?=
 =?us-ascii?Q?CC+bHKixyJGri7CAV9ft0U5hqA03t2lubnaRJmqTFcwtXboPBixRH+zzT9Lj?=
 =?us-ascii?Q?jwZ/HLjX5onDwYQY+s2Nx+1fckqzjhMWS3SIHA/mCZXKC79XcX9LMzAZetfe?=
 =?us-ascii?Q?ieT1QHNTOCWPoGm08ldPRiUtTG9SX7It3hwBUIjur4epdcS1aTRg6ezz/bwu?=
 =?us-ascii?Q?h7VmVSLqC5kSIqbIjK/8KktGHiTU8bMO7mhJc63ImKYTTqMCRuwq+jiwg0Fe?=
 =?us-ascii?Q?Ku7bV9pu43GIpVwpv41TRer0K67VYe1KuxjwpbYqpGsANVBPfh2/Nwhc5fao?=
 =?us-ascii?Q?wSeyYXrCC8vSa+xr3I3I2kA1eYXHUtQw8skuNHdbCDFxzUJtA+wy6SLtoRAG?=
 =?us-ascii?Q?rB3IWzqJVzbgChtfEeAxyM0oPbTbCcE5JEY3mV7bEImKaMfZKH1/Ff3UGyaJ?=
 =?us-ascii?Q?wB/CtA+n4oLq0ZKZordml79YklbbKqBYszguagVs1VuQYdkYgjCpsi9GRXT7?=
 =?us-ascii?Q?GyTKMT11P62ufDHjvXLgri4QPYNZC1rsz/BlzR+8mYWT7S7B6H/rlx2isyqu?=
 =?us-ascii?Q?6KayobpcUV8TY5QOcEKNbjrtYe0cvFk81m+feBvQ/tRNp+Qbn9H1Tt5/LnKj?=
 =?us-ascii?Q?YojHS6Kkt/2PtE9DdvRmD39Y+DMuDatb9s+Dttvb3dPLoQDRkeGeVx+zB8ag?=
 =?us-ascii?Q?PFh3Myt9enDP6GJO9M5fT8pRlNQj00zRF3k6eeLvXkkHLUSeXEEKvBAN8Yln?=
 =?us-ascii?Q?a2tXrDmq338iVHupw4dg4sJOnL5pK+41VlXgh2rtkuD5yfM3+Y0k2IY9Fqo4?=
 =?us-ascii?Q?m2SaWBryAw7aGw381Ep2pzUf8ASpOnmWUaUVxDDLzanNlF/Ksef9H31Jh1Af?=
 =?us-ascii?Q?66j620BtHr4oUlWR7GUnZ6BZysKm1BTKdmilTtzgBmwmXNVkeivnd4vSL8vv?=
 =?us-ascii?Q?kUA3Sluy8p+5aEjcYz6Msk5L53budWH76RABsq/uEgMplnMYb1YCgWf1USkW?=
 =?us-ascii?Q?6c3IScQIylSl3xHh9MQui2aCeQWCSPT6o8FR1z174QFKaExK7UDUfKSYrtkc?=
 =?us-ascii?Q?2yU9UggGN1O433ewQ6GkD1Ojv6seRZqARwa1NAuARdVMMD3EuTiG1UH/kNqe?=
 =?us-ascii?Q?RzQS8LREqMDLUkeV1oYzEWbGaED0zS6WTkpQHVffW20EEx72XvOE7Ri6K53z?=
 =?us-ascii?Q?kr70z9Rsrpbr/4vLGdJ2esKtF72Ei/g6bMIgGRVr?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6204d289-e7a7-4fea-8e07-08dc8b252f59
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 21:18:20.6423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pyLyiuXR6oT2irlv4nH1NGy4DW60ROFf1hMt8xtWpA78M/7pW7uX4tQfMQQSIWYJHkiAA1hXfGpZ7/iPrz6Mtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6683
X-OriginatorOrg: intel.com

Greg Kroah-Hartman wrote:
> On Mon, Jun 10, 2024 at 10:44:42AM -0700, Dan Williams wrote:
> > Greg Kroah-Hartman wrote:
> > > Now that the driver core allows for struct class to be in read-only
> > > memory, we should make all 'class' structures declared at build time
> > > placing them into read-only memory, instead of having to be dynamically
> > > allocated at runtime.
> > 
> > Change looks good to me,
> > 
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> > 
> > ...changelog grammar tripped me up though, how about:
> > 
> > "Now that the driver core allows for struct class to be in read-only
> > memory, it is possible to make all 'class' structures be declared at
> > build time. Move the class to a 'static const' declaration and register
> > it rather than dynamically create it."
> 
> That works too, want me to resubmit with this, or can I update it when I
> commit it to my tree?

In that case.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> 
> thanks,
> 
> greg "the changelog is the hardest part" k-h