Received-SPF: pass (google.com: domain of linux-kernel+bounces-212313-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 13 Jun 2024 00:20:57 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>, 
	devicetree@vger.kernel.org, Nicolas Dufresne <nicolas.dufresne@collabora.com>, 
	Jianfeng Liu <liujianfeng1994@gmail.com>, linux-rockchip@lists.infradead.org, 
	Nicolas Frattaroli <frattaroli.nicolas@gmail.com>, Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>, 
	kernel@collabora.com, Heiko Stuebner <heiko@sntech.de>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Philipp Zabel <p.zabel@pengutronix.de>, Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v5 1/5] media: dt-bindings: rk3568-vepu: Add RK3588
 VEPU121
Message-ID: <t5yyanxuweou6edj3subsbtndow6nwwexcgkhctfx3mdkoi7dl@zjtqmvklwzz4>
References: <20240612173213.42827-1-sebastian.reichel@collabora.com>
 <20240612173213.42827-2-sebastian.reichel@collabora.com>
 <171821679246.3419351.9732124883795406633.robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ntp3lma6src7nirh"
Content-Disposition: inline
In-Reply-To: <171821679246.3419351.9732124883795406633.robh@kernel.org>


--ntp3lma6src7nirh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Jun 12, 2024 at 12:26:32PM GMT, Rob Herring (Arm) wrote:
> On Wed, 12 Jun 2024 19:15:41 +0200, Sebastian Reichel wrote:
> > From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
> >=20
> > This encoder-only device is present four times on this SoC, and should
> > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8
> > encoding). No fallback compatible has been added, since the operating
> > systems might already support RK3568 VEPU and want to avoid registering
> > four of them separately considering they can be used as a cluster.
> >=20
> > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> >  .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml      | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >=20
>=20
> My bot found errors running 'make dt_binding_check' on your patch:
>=20
> yamllint warnings/errors:
>=20
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/m=
edia/rockchip,rk3568-vepu.yaml: properties:compatible:oneOf: [{'const': 'ro=
ckchip,rk3568-vepu'}, {'const': 'rockchip,rk3588-vepu121'}] should not be v=
alid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['co=
nst']}}
> 	hint: Use 'enum' rather than 'oneOf' + 'const' entries
> 	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
>=20
> doc reference errors (make refcheckdocs):
>=20
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202406=
12173213.42827-2-sebastian.reichel@collabora.com
>=20
> The base for the series is generally the latest rc1. A different dependen=
cy
> should be noted in *this* patch.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>=20
> pip3 install dtschema --upgrade
>=20
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your sch=
ema.

oops. That's on me for not doing another test and doing something
stupid. I obviously wanted this and didn't recheck the bindings
after dropping the fallback compatible.

enum:
  - rockchip,rk3568-vepu
  - rockchip,rk3588-vepu121

I will change it in v6 if people are fine with this solution.

-- Sebastian

--ntp3lma6src7nirh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmZqH0IACgkQ2O7X88g7
+pqdoA/9EV2En/+YR2Jzd8BcFmaqKhPrT3iarETgvi+l5Pil5FpQk+4uPvpRYTpJ
XsvG36RWz2jDBnHwqIwcqbU6fzM/YdEQbyk6RzCQwbJ7aZrDgq+Va4+RzlwNb9YG
Cvd00NTkP+Nvj1vdP7YQ4hkB9jHpGNAU6AsF+Te+A3K/YDkqvSMwDAyAL+n5bN8D
i8n3x0R5DOUVKibVFZgQgf+onqXPf9HGOfZhxGzyPArnK8i9ccyu6BGSjwcQYWIr
q24mfPKWIKmRR8+7BQvyG0gA/YPhtYzmCei4zAVXEmM9ZzK3CjNub7jHOBsBTdX/
BEAWc/S1LBboiHF1Nk3eDZr7GyUGL3i+mnMS7VJ9i35GKMNqUo/dLc9su+UVWHGK
V4T89f+yADLH1ojY4aUB9Ay3f96D3bVnHlH+RcqNvS4L0R+0lhEJ7DS5NW6yq+kn
MR+odxWpNJoQvbQJ66vb0xCr57YmKSOXNqq+k4IBXUbLG8fQf7XytmqVstZ90iGy
/PEfFTG1gjpySqENBccrQd2liRWtxsEfF/AQe3N1tthyXMORiCc1805FThm7IsFr
tTN2vaFTZt5FCv/07WzT5KyP6iQkxwiKnshN6L7wIhovNj/yo6HkW1GJ1jZx/Eab
QnzlBXW2SJpf4q6z3PMLd7ZzjBaYio+FIBDsv4PvO3mOymc6lMs=
=977a
-----END PGP SIGNATURE-----

--ntp3lma6src7nirh--