Received-SPF: pass (google.com: domain of linux-kernel+bounces-212338-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 13 Jun 2024 00:50:12 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Diederik de Haas <didi.debian@cknow.org>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Nicolas Frattaroli <frattaroli.nicolas@gmail.com>, 
	Heiko Stuebner <heiko@sntech.de>, linux-rockchip@lists.infradead.org, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, 
	Conor Dooley <conor+dt@kernel.org>, Jianfeng Liu <liujianfeng1994@gmail.com>, 
	Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>, Nicolas Dufresne <nicolas.dufresne@collabora.com>, 
	linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	kernel@collabora.com, Hugh Cole-Baker <sigmaris@gmail.com>
Subject: Re: [PATCH v5 5/5] arm64: dts: rockchip: Add VPU121 support for
 RK3588
Message-ID: <r7zxxruucz5agn4wjyugzn6rblodw47n5hufooysx773ub6ccl@ni7l6q2e6d3y>
References: <20240612173213.42827-1-sebastian.reichel@collabora.com>
 <20240612173213.42827-6-sebastian.reichel@collabora.com>
 <4207056.GSNtieVc0Q@bagend>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wfg47polgte7e7hz"
Content-Disposition: inline
In-Reply-To: <4207056.GSNtieVc0Q@bagend>


--wfg47polgte7e7hz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Jun 12, 2024 at 08:10:30PM GMT, Diederik de Haas wrote:
> On Wednesday, 12 June 2024 19:15:45 CEST Sebastian Reichel wrote:
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi index
> > 9edbcfe778ca..e7e1b456b9b9 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> > @@ -1239,6 +1239,27 @@ jpeg_enc3_mmu: iommu@fdbac800 {
> >                 #iommu-cells =3D <0>;
> >         };
> >=20
> > +       vpu: video-codec@fdb50000 {
> > +               compatible =3D "rockchip,rk3588-vpu121",
> > "rockchip,rk3568-vpu"; +               reg =3D <0x0 0xfdb50000 0x0 0x80=
0>;
> > +               interrupts =3D <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH 0>;
> > +               interrupt-names =3D "vdpu";
> > +               clocks =3D <&cru ACLK_VPU>, <&cru HCLK_VPU>;
> > +               clock-names =3D "aclk", "hclk";
> > +               iommus =3D <&vpu_mmu>;
> > +               power-domains =3D <&power RK3588_PD_VDPU>;
> > +       };
> > +
> > +       vpu_mmu: iommu@fdb50800 {
> > +               compatible =3D "rockchip,rk3588-iommu",
> > "rockchip,rk3568-iommu"; +               reg =3D <0x0 0xfdb50800 0x0 0x=
40>;
> > +               interrupts =3D <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH 0>;
> > +               clock-names =3D "aclk", "iface";
> > +               clocks =3D <&cru ACLK_VPU>, <&cru HCLK_VPU>;
> > +               power-domains =3D <&power RK3588_PD_VDPU>;
> > +               #iommu-cells =3D <0>;
> > +       };
> > +
> >         av1d: video-codec@fdc70000 {
>=20
> Shouldn't these nodes come *before*=20
> jpeg_enc0: video-codec@fdba0000=20
> As fdb50000 is lower then fdba0000?

Of course. I will fix that in v6.

-- Sebastian

--wfg47polgte7e7hz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmZqJiMACgkQ2O7X88g7
+prMHw/+KUizkP3UyEenXwGeOVPBehTauSjXoE/h2KTeuHCzFFm5Xd/WC7tB5Sz+
6T29txSA4Zla5v3P3dP5lwUNqn0PTU5hkfxw3bR/iAlGRLTD8VcYKW7BdC6ow94l
O1hBX1wGP2D/f6l59SvFpF9j8zWRb10xUuzpVLI+1uwY5n01iJWfzxOBMPeWIeHF
8K+XClLnZChzJklVmjlfxleI5Xl8SUQVMCIufwCiX6+WOcqiYIK1KJF0fqQ7zM34
3xwElK9I1limJXCPMnXbu4g3F6GvA90FGoweVHfjOM27tpqibV2z6fXWXg1ztsJ2
ZMOP1bD6oXXqsm8pOJYfc+ClTS5pXUDT1U6yCcfG4RtKAsIoMg86BAgHlBCxEemF
IwxV1hiwol6/do7EehKJaP1zO8VrvtBFIT4TxyvME0M7SBynP278ixgpRBsGh7c+
/pka7BWJx4srb0wrcoeQ3xNeO+ZkeaA3kWHcQR4gQlNqJaQre5xnVHr07i2EipRB
jNSBNgp11NhA5c3Vn4EMgbydVT0Cspl5B9aBQE6eGrywf9JAzCmOKVKyg7WgR+6x
9hmJ2Q+y3K9IDA3WpfanY3xcakaAnP1M29blchf1TQJipn3+n3eQN27pYqpdCVrt
ru6i1eb1EmZ95k3LtEUOV89WJdvIiJDsFSDkToBNcG+miIhrbvQ=
=UnLa
-----END PGP SIGNATURE-----

--wfg47polgte7e7hz--