Received-SPF: pass (google.com: domain of linux-kernel+bounces-212352-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 12 Jun 2024 16:13:29 -0700
From: Isaku Yamahata <isaku.yamahata@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	Isaku Yamahata <isaku.yamahata@intel.com>,
	Michael Roth <michael.roth@amd.com>, isaku.yamahata@linux.intel.com
Subject: Re: [PATCH] KVM: interrupt kvm_gmem_populate() on signals
Message-ID: <20240612231329.GA1900928@ls.amr.corp.intel.com>
References: <20240611102243.47904-1-pbonzini@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240611102243.47904-1-pbonzini@redhat.com>

On Tue, Jun 11, 2024 at 06:22:43AM -0400,
Paolo Bonzini <pbonzini@redhat.com> wrote:

> kvm_gmem_populate() is a potentially lengthy operation that can involve
> multiple calls to the firmware.  Interrupt it if a signal arrives.

What about cond_resched() in the loop?  kvm_gmem_allocate() has both.

The change itself looks good for TDX because KVM_TDX_INIT_MEMREGION checks the
signal.  I can drop the duplicated check.  Similar to cond_resched().
-- 
Isaku Yamahata <isaku.yamahata@intel.com>