Received-SPF: pass (google.com: domain of linux-kernel+bounces-212506-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 13 Jun 2024 02:57:11 +0000
To: linux-kernel@vger.kernel.org
From: Raymond Hackley <raymondhackley@protonmail.com>
Cc: Markuss Broks <markuss.broks@gmail.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Stephan Gerhold <stephan@gerhold.net>, Nikita Travkin <nikita@trvn.ru>, linux-input@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: [PATCH v2 3/3] input/touchscreen: imagis: Add supports for Imagis IST3038
Message-ID: <20240613025631.5425-4-raymondhackley@protonmail.com>
In-Reply-To: <20240613025631.5425-1-raymondhackley@protonmail.com>
References: <20240613025631.5425-1-raymondhackley@protonmail.com>
Feedback-ID: 49437091:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Imagis IST3038 is another variant of Imagis IST3038 IC, which has
a different register interface from IST3038C (possibly firmware defined).

Unlike IST3038C/IST3032C, IST3038 has different registers for commands,
which means IST3038 doesn't use protocol B.
Similar to IST3032C and maybe the other variants, IST3038 has touch keys
support, which provides KEY_APPSELECT and KEY_BACK.

Add support for IST3038 with touch keys.

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
 drivers/input/touchscreen/imagis.c | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen=
/imagis.c
index 886bcfc8497a..aeabf8d057de 100644
--- a/drivers/input/touchscreen/imagis.c
+++ b/drivers/input/touchscreen/imagis.c
@@ -12,9 +12,17 @@
 #include <linux/property.h>
 #include <linux/regulator/consumer.h>
=20
+#define IST30XX_REG_STATUS=09=090x20
+#define IST30XX_REG_CHIPID=09=09(0x40000000 | IST3038C_DIRECT_ACCESS)
+
+#define IST30XX_WHOAMI=09=09=090x30003000
+#define IST30XXA_WHOAMI=09=09=090x300a300a
+#define IST30XXB_WHOAMI=09=09=090x300b300b
+#define IST3038_WHOAMI=09=09=090x30383038
+
 #define IST3032C_WHOAMI=09=09=090x32c
+#define IST3038C_WHOAMI=09=09=090x38c
=20
-#define IST3038B_REG_STATUS=09=090x20
 #define IST3038B_REG_CHIPID=09=090x30
 #define IST3038B_WHOAMI=09=09=090x30380b
=20
@@ -25,7 +33,6 @@
 #define IST3038C_REG_TOUCH_STATUS=09(IST3038C_REG_HIB_BASE | IST3038C_HIB_=
ACCESS)
 #define IST3038C_REG_TOUCH_COORD=09(IST3038C_REG_HIB_BASE | IST3038C_HIB_A=
CCESS | 0x8)
 #define IST3038C_REG_INTR_MESSAGE=09(IST3038C_REG_HIB_BASE | IST3038C_HIB_=
ACCESS | 0x4)
-#define IST3038C_WHOAMI=09=09=090x38c
 #define IST3038C_CHIP_ON_DELAY_MS=0960
 #define IST3038C_I2C_RETRY_COUNT=093
 #define IST3038C_MAX_FINGER_NUM=09=0910
@@ -397,9 +404,17 @@ static const struct imagis_properties imagis_3032c_dat=
a =3D {
 =09.protocol_b =3D true,
 };
=20
+static const struct imagis_properties imagis_3038_data =3D {
+=09.interrupt_msg_cmd =3D IST30XX_REG_STATUS,
+=09.touch_coord_cmd =3D IST30XX_REG_STATUS,
+=09.whoami_cmd =3D IST30XX_REG_CHIPID,
+=09.whoami_val =3D IST3038_WHOAMI,
+=09.touch_keys_supported =3D true,
+};
+
 static const struct imagis_properties imagis_3038b_data =3D {
-=09.interrupt_msg_cmd =3D IST3038B_REG_STATUS,
-=09.touch_coord_cmd =3D IST3038B_REG_STATUS,
+=09.interrupt_msg_cmd =3D IST30XX_REG_STATUS,
+=09.touch_coord_cmd =3D IST30XX_REG_STATUS,
 =09.whoami_cmd =3D IST3038B_REG_CHIPID,
 =09.whoami_val =3D IST3038B_WHOAMI,
 };
@@ -415,6 +430,7 @@ static const struct imagis_properties imagis_3038c_data=
 =3D {
 #ifdef CONFIG_OF
 static const struct of_device_id imagis_of_match[] =3D {
 =09{ .compatible =3D "imagis,ist3032c", .data =3D &imagis_3032c_data },
+=09{ .compatible =3D "imagis,ist3038", .data =3D &imagis_3038_data },
 =09{ .compatible =3D "imagis,ist3038b", .data =3D &imagis_3038b_data },
 =09{ .compatible =3D "imagis,ist3038c", .data =3D &imagis_3038c_data },
 =09{ },
--=20
2.39.2