Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755192AbYBGJqZ (ORCPT ); Thu, 7 Feb 2008 04:46:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753064AbYBGJqP (ORCPT ); Thu, 7 Feb 2008 04:46:15 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:49822 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752777AbYBGJqN (ORCPT ); Thu, 7 Feb 2008 04:46:13 -0500 Date: Thu, 7 Feb 2008 01:45:03 -0800 From: Andrew Morton To: Jens Axboe Cc: linux-kernel@vger.kernel.org, Alan.Brunelle@hp.com, arjan@linux.intel.com, dgc@sgi.com, npiggin@suse.de, Oleg Nesterov Subject: Re: [PATCH 2/8] Add interface for queuing work on a specific CPU Message-Id: <20080207014503.cf1853c2.akpm@linux-foundation.org> In-Reply-To: <1202375945-29525-3-git-send-email-jens.axboe@oracle.com> References: <1202375945-29525-1-git-send-email-jens.axboe@oracle.com> <1202375945-29525-3-git-send-email-jens.axboe@oracle.com> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2078 Lines: 56 On Thu, 7 Feb 2008 10:18:59 +0100 Jens Axboe wrote: > Signed-off-by: Jens Axboe > --- > include/linux/workqueue.h | 1 + > kernel/workqueue.c | 15 +++++++++++++++ > 2 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h > index 7f28c32..4c46944 100644 > --- a/include/linux/workqueue.h > +++ b/include/linux/workqueue.h > @@ -179,6 +179,7 @@ __create_workqueue_key(const char *name, int singlethread, > extern void destroy_workqueue(struct workqueue_struct *wq); > > extern int FASTCALL(queue_work(struct workqueue_struct *wq, struct work_struct *work)); > +extern int FASTCALL(queue_work_on_cpu(struct workqueue_struct *wq, struct work_struct *work, int cpu)); -ETOOWIDE please don't add fastcall - we're trying to remove it. > extern int FASTCALL(queue_delayed_work(struct workqueue_struct *wq, > struct delayed_work *work, unsigned long delay)); > extern int queue_delayed_work_on(int cpu, struct workqueue_struct *wq, > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index 52db48e..551ad7e 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -175,6 +175,21 @@ int fastcall queue_work(struct workqueue_struct *wq, struct work_struct *work) > } > EXPORT_SYMBOL_GPL(queue_work); > > +int fastcall queue_work_on_cpu(struct workqueue_struct *wq, > + struct work_struct *work, int cpu) > +{ > + int ret = 0; > + > + if (!test_and_set_bit(WORK_STRUCT_PENDING, work_data_bits(work))) { > + BUG_ON(!list_empty(&work->entry)); > + __queue_work(per_cpu_ptr(wq->cpu_wq, cpu), work); > + ret = 1; > + } > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(queue_work_on_cpu); Might as well change queue_work() to call this? Oleg cc'ed as queue_work() maintainer ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/