Received: by 2002:ab2:6f44:0:b0:1fd:c486:4f03 with SMTP id l4csp131035lqq; Wed, 12 Jun 2024 20:08:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV/WA/fZ0ysL4dTpvpsCPUCKmrfcky7CKbVJoJ3EX7dBeKn/DipgYSQTTnXg10swJRWobt6JsTsNVHOjDveAscHyM67tuVh/OLNnJr3og== X-Google-Smtp-Source: AGHT+IEj3ekVWDD1NsH01sNQr4eMaL/Te5l9kDEbpcczVSqXr6zW+SSuFH5jI1JKJXlMdN8spTJW X-Received: by 2002:a17:902:f54d:b0:1f6:6ae5:143d with SMTP id d9443c01a7336-1f83b6f28demr35509435ad.47.1718248084176; Wed, 12 Jun 2024 20:08:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718248084; cv=pass; d=google.com; s=arc-20160816; b=hJbBA3rx8PHWHDvqYExOhSdAkvxhRhmBmIkYcYabnmdiqIGLpYVaGC521a00L6pS8Y hGqm7N1xgPT0urcEYFoVFf+BiDT63M06Bz6qsg/Q85+y6WFu+FTYmhFb6CoUCHkChv2t wPT3OM7+Gjuloo3jRSv1Z7/aNV95093pU8dnGlHpmSunuj45gNDsWogcqyBoa/Q74bCD ZvyXdTkUVVg1ZnRsg33lP/xm4YjTafDIPxhckBojS/+EI/FBl0BQVzFFekDuzfE4e9Iv bDMXajae+HNnab0hAZb/cZ9Ni1vv9pi/wNwgyVdRxXzOM/9+PR3XPu15/Qc+cFpR9q9/ i1AA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NZBiiMdM04IcSF+p7G806u9/yqWym6DLPn0H0NUD42s=; fh=7U6hmmbwAQ+V4IKIhIvnl7RlPJ1aaQ3DN5P3w8zV2oM=; b=fUK0StoJzDgTFecCezJEwf16UAbyw5bofXvSkVNALNWgn5w4PEkEupmq99k1VwJnnv 5UOnzddAwKojDezm63ZNzE0lsI3bvWZZ5g+Ap3d2cQmLBZSptN1VhgMjoF/w/j09zGGh dGovx9gLIhDJ7muRbxceTDBD7f7Vl52VGvxGEZuZP966UGERiBWf9Ge+Wl4LxIO8bcit OL7sslQvQQXFQCjlSoefsvMI5CbaxX6tYs4lY2wVrHeUG9ExJMuy9DB5QbEgFfKFFXdY udXA/kwHRkclloCuq4oOomgBGGazUnQU8PAyi5Tv3vcctNIgDtg1AhldZtYHeXySiuhV R9qw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WIAndfv2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-212510-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212510-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f855e52e10si3764905ad.139.2024.06.12.20.08.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 20:08:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-212510-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WIAndfv2; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-212510-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212510-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8741AB225F7 for ; Thu, 13 Jun 2024 03:06:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5092112D765; Thu, 13 Jun 2024 03:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WIAndfv2" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7035612CD8C; Thu, 13 Jun 2024 03:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718247935; cv=none; b=nhjAa+Ojkvp0PZhmQ4Q2lzjsi32U52VPiT31mz2qKK7zwhqNcUTm3BqEiC9i516sqGeMutGfTn8qClcwJBcEPGsBNUJjB6WTTveG6LHQ55OOEYwqhvS9B/YOYGJ1G07PP1I0ZUMy/+OG9rKtTrf0Nazi+gUjwVO49gOGCXp71G0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718247935; c=relaxed/simple; bh=4/qP8iALJ2CgmtztzTTE52P6OmpNtjaTkKxP969Ql0s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WOgR1Xfypk5L+MMXBW7PTmxoP9X4aktMze0r6sAHsXpNZ02uui6itIw+/je5Lynb6P+hhP0jcbp5d+r4FiKCncmhzeWPKkE92TYe64qpD8bFmRSSCNZAlRnOHJGVk/KAaQa0U2m5/jyNxjTn6vuMaU0HDI8DG7CDcO5Pa567C/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WIAndfv2; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EADF9C116B1; Thu, 13 Jun 2024 03:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718247935; bh=4/qP8iALJ2CgmtztzTTE52P6OmpNtjaTkKxP969Ql0s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WIAndfv2ZIidRa65O52I4HSr4r8H/g+BFE/EF6QsC9dVxzBl1iFCW5zRvkRnVMuyv kx4HEi6GaRS7ZzL7lkvaeMhd7or24QGINZTZzVmYgPlVsFL3u8EEJ3hFvNPRV5rAoK NRTWWD20N2/v9Aiuy+azJISDH10vhOefMCndLitusHCxoMK0f7S+6G5U5+7tjt1f62 TWiCkzmwllU/4j5WQ1B/4ZXCp+XOhz5a9uAHF9aHqqa+htgc2mfreuOtgeSfMsRZvu JuyuicE2bafavvKEzILB4tZI7uBVKPDhNCnn7AbnF9pmvuyO+tayKQClWhF8Nl4mGJ 3zIuOIGtbmhjQ== Date: Wed, 12 Jun 2024 20:05:34 -0700 From: Kees Cook To: Aryan Srivastava Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, mw@semihalf.com, netdev@vger.kernel.org, pabeni@redhat.com Subject: Re: [PATCH v1] net: mvpp2: use slab_build_skb for oversized frames Message-ID: <202406122003.E02C37ADD1@keescook> References: <20240611193318.5ed8003a@kernel.org> <20240613024900.3842238-1-aryan.srivastava@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613024900.3842238-1-aryan.srivastava@alliedtelesis.co.nz> On Thu, Jun 13, 2024 at 02:49:00PM +1200, Aryan Srivastava wrote: > Setting frag_size to 0 to indicate kmalloc has been deprecated, > use slab_build_skb directly. > > Fixes: ce098da1497c ("skbuff: Introduce slab_build_skb()") > Signed-off-by: Aryan Srivastava > --- > Changes in v1: > - Added Fixes tag This looks like similar updates like commit 99b415fe8986 ("tg3: Use slab_build_skb() when needed") Reviewed-by: Kees Cook -- Kees Cook