Received-SPF: pass (google.com: domain of linux-kernel+bounces-212516-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Justin Lai <justinlai0215@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "andrew@lunn.ch"
	<andrew@lunn.ch>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "horms@kernel.org"
	<horms@kernel.org>,
        "rkannoth@marvell.com" <rkannoth@marvell.com>,
        "Ping-Ke
 Shih" <pkshih@realtek.com>,
        Larry Chiu <larry.chiu@realtek.com>
Subject: RE: [PATCH net-next v20 08/13] rtase: Implement net_device_ops
Thread-Topic: [PATCH net-next v20 08/13] rtase: Implement net_device_ops
Thread-Index: AQHauLeU3KHUR0FCCkajORloGcGgcbHEXNMAgACmHxA=
Date: Thu, 13 Jun 2024 03:16:27 +0000
Message-ID: <2f6dfc4920694035bf630fccc4f3a943@realtek.com>
References: <20240607084321.7254-1-justinlai0215@realtek.com>
	<20240607084321.7254-9-justinlai0215@realtek.com>
 <20240612173944.05121bf0@kernel.org>
In-Reply-To: <20240612173944.05121bf0@kernel.org>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

> On Fri, 7 Jun 2024 16:43:16 +0800 Justin Lai wrote:
> > +static void rtase_get_stats64(struct net_device *dev,
> > +                           struct rtnl_link_stats64 *stats) {
> > +     const struct rtase_private *tp =3D netdev_priv(dev);
> > +     const struct rtase_counters *counters;
> > +
> > +     counters =3D tp->tally_vaddr;
> > +
> > +     if (!counters)
> > +             return;
>=20
> Same question about how this can be null as in the ethtool patch..

This check seems unnecessary, I will remove it.

>=20
> > +     netdev_stats_to_stats64(stats, &dev->stats);
>=20
> Please dont use this field, there is a comment on it:
>=20
>         struct net_device_stats stats; /* not used by modern drivers */
>=20
> You can store the fields you need for counters in struct rtase_private

Ok, I will remove all parts that use struct net_device_stats stats.

>=20
> > +     dev_fetch_sw_netstats(stats, dev->tstats);