Received-SPF: pass (google.com: domain of linux-kernel+bounces-212523-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 12 Jun 2024 20:34:35 -0700
From: Kees Cook <kees@kernel.org>
To: Aryan Srivastava <Aryan.Srivastava@alliedtelesis.co.nz>
Cc: "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"mw@semihalf.com" <mw@semihalf.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH v1] net: mvpp2: use slab_build_skb for oversized frames
Message-ID: <202406122033.69D9ABFC24@keescook>
References: <20240611193318.5ed8003a@kernel.org>
 <20240613024900.3842238-1-aryan.srivastava@alliedtelesis.co.nz>
 <202406122003.E02C37ADD1@keescook>
 <6c2592c517878a69d37e1957d9624d83dbc982ab.camel@alliedtelesis.co.nz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6c2592c517878a69d37e1957d9624d83dbc982ab.camel@alliedtelesis.co.nz>

On Thu, Jun 13, 2024 at 03:13:34AM +0000, Aryan Srivastava wrote:
> On Wed, 2024-06-12 at 20:05 -0700, Kees Cook wrote:
> > On Thu, Jun 13, 2024 at 02:49:00PM +1200, Aryan Srivastava wrote:
> > > Setting frag_size to 0 to indicate kmalloc has been deprecated,
> > > use slab_build_skb directly.
> > > 
> > > Fixes: ce098da1497c ("skbuff: Introduce slab_build_skb()")
> > > Signed-off-by: Aryan Srivastava
> > > <aryan.srivastava@alliedtelesis.co.nz>
> > > ---
> > > Changes in v1:
> > > - Added Fixes tag
> > 
> > This looks like similar updates like commit 99b415fe8986 ("tg3: Use
> > slab_build_skb() when needed")
> Yeah, I noticed that when I was looking for examples of other "Fixes"
> tags for the "skbuff: Introduce slab_build_skb()" commit. I suspect
> there are many drivers that will need this "fix".

Yeah, at the time the API changes was made it was clear it wasn't easy
to identify which needed it, so the WARN was added along with supporting
the old style via internal fall-back.

-Kees

> > 
> > Reviewed-by: Kees Cook <kees@kernel.org>
> > 
> 

-- 
Kees Cook