Received-SPF: pass (google.com: domain of linux-kernel+bounces-212561-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f0e4c51c-8227-4f5c-876f-38fbb4a0e1bf@linux.ibm.com>
Date: Thu, 13 Jun 2024 10:26:11 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] list: introduce a new cutting helper
To: Keith Busch <kbusch@meta.com>, linux-nvme@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: hch@lst.de, sagi@grimberg.me, paulmck@kernel.org, davidgow@google.com,
        akpm@linux-foundation.org, venkat88@linux.vnet.ibm.com,
        Keith Busch <kbusch@kernel.org>
References: <20240612155135.3060667-1-kbusch@meta.com>
Content-Language: en-US
From: Nilay Shroff <nilay@linux.ibm.com>
In-Reply-To: <20240612155135.3060667-1-kbusch@meta.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 6/12/24 21:21, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> Provide a helper to remove elements from a list to the end, and place
> those elements in a new list.
> 
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
>  include/linux/list.h | 20 ++++++++++++++++++++
>  lib/list-test.c      | 29 +++++++++++++++++++++++++++++
>  2 files changed, 49 insertions(+)
> 
> diff --git a/include/linux/list.h b/include/linux/list.h
> index 5f4b0a39cf46a..f22850e854820 100644
> --- a/include/linux/list.h
> +++ b/include/linux/list.h
> @@ -520,6 +520,26 @@ static inline void list_cut_before(struct list_head *list,
>  	entry->prev = head;
>  }
>  
> +/**
> + * list_cut - cut a list into two from the entry
> + * @list: a new list to add all removed entries
> + * @head: a list with entries
> + * @entry: an entry within head, could be the head itself
> + *
> + * This helper removes elements from @head starting at @entry until the end,
> + * and appends them to @lists.
> + */
> +static inline void list_cut(struct list_head *list,
> +		struct list_head *head, struct list_head *entry)
> +{
> +	list->next = entry;
> +	list->prev = head->prev;
> +	head->prev = entry->prev;
> +	entry->prev->next = head;
> +	entry->prev = list;
> +	list->prev->next = list;
> +}
I am wondering whether we really need the _rcu version of list_cut here?
I think that @head could point to an _rcu protected list and that's true 
for this patch. So there might be concurrent readers accessing @head using
_rcu list-traversal primitives, such as list_for_each_entry_rcu().

An _rcu version of list_cut():

static inline void list_cut_rcu(struct list_head *list,
		struct list_head *head, struct list_head *entry)
{
	list->next = entry;
	list->prev = head->prev;
	head->prev = entry->prev;
	rcu_assign_pointer(list_next_rcu(entry->prev), head);
	entry->prev = list;
	list->prev->next = list;
}

Thanks,
--Nilay