Received: by 2002:ab2:6f44:0:b0:1fd:c486:4f03 with SMTP id l4csp183898lqq; Wed, 12 Jun 2024 22:54:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX+YLaPaAJNP8MXTQ/cJpLfxB6oh3uHuyrTf31Yg2xCBprtoE6skJdrM6RiKgb79HnMju1GGgj4DHE99q9KBcxWRm9kFx3DZp2P2wCbcA== X-Google-Smtp-Source: AGHT+IE2B8wi69pE9WquU21oZ9e+eCOlqGo8vdLgQs2JgoTr3c8xEgZOBxU9Lzv/uJlaCFvrhEB2 X-Received: by 2002:a05:6e02:12ec:b0:375:ac51:9c59 with SMTP id e9e14a558f8ab-375cd16bd22mr46381855ab.12.1718258056432; Wed, 12 Jun 2024 22:54:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718258056; cv=pass; d=google.com; s=arc-20160816; b=xRaGcZK99djPFkds94kOyOcUHyRecJZYCznKUruRwHO1HavH4g67PMQP3/QiS7uNZV b/hdbB93QCV8B3V9ylFvwAAi1FPg/+Wxg60RXK4wAD63PrwFCuC591CYd+1xs0rZzZkt VI3BBhThLJIa+ZK0m0BkPiHM3pb1o2YCjmFnQRYxb5UdExkU0pqSwysAAvFET8pcQypE ayNrZi4wEViLSeVuyNxlt9zJJwBWAiapvrdUujlmZDxgWhVePavwrdRhAh7KfltpNWdA zjs8TJQ4/ireC0RYU2ODw7WKyw9G86we9Pvky04RKEntcq5Z6Q3DOsd6l1slqB49/sZN 1SgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=boJ+B6BDO3fDOlwVxeqXmN5NzCBdwJpoJ+wn/cGU+fY=; fh=U4nFVOyMbGuLIrZBaTnYPbopMTPPuR/3+ysMacQWuJ0=; b=ogGbt0qVh7irMyNHabzPbnoFDj2J0pmGE8hZUXDYezvYKtRaaBCjoOitsMnzu0SgWB SlzToA+c1odWYYatmnP07o/hPLcq6rChBJQR1jYwjS3IT2BXpehjzbTnQK54AQ991Mpu 04cHtRaNCZu0joovQxFT5hI0EIMVp4qP8ZxEST9Z/LIY6jHvPv2eIe8u351Ch/IqVZbC /DDpjx9OhxOzV+59+gp84tYMyMnqFXtt2jiTgQP0twn2XHXc0dfR2+OX1pI2vEvCMT6+ iJTkXqvvvd3FdpKJncnA/T9mNCsjkACtGyWxyWANBC/FrgYJkHBb56IsYbxEVDCwTLgs LprA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WGr5nvc5; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-212584-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212584-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6fee310c8b3si608264a12.351.2024.06.12.22.54.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 22:54:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-212584-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WGr5nvc5; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-212584-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212584-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D9862284A25 for ; Thu, 13 Jun 2024 05:54:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6B1881369AE; Thu, 13 Jun 2024 05:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WGr5nvc5" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80D9281207; Thu, 13 Jun 2024 05:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718258047; cv=none; b=Ysj7pgUvnwr6vFHX1GfHN0Ma656QNRXI0OG4/P63Qr4WWZpJRcHmyneVDdjcgVwTmoeR+PMNndu8zRW6YdbQd1EpBqaFPagCAOkLKrSY9cu4cBPPqIE244aYhpCJlqeOubFZ6uk1MPq5iQN5r3CFE3P/M2qbTzQvlJ19zPV1Hzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718258047; c=relaxed/simple; bh=Bo9w9ZSL4zxjvH+deU09KFW+rBmKUUYyQumKsggz4JM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JwuzcLlf7PxhdOi1n0fC5TwrXfGM7tTyZLUEZjjcdUekqa6mFZyDHrM4HQVXVttK6HCuTtFjoOygnotu3l+yURJa1vSXFdOrQhUyfGGInZitMuAP7v/MABoxAKiG4F8EnxSuhCJujEePUwE8C98yGyfEj+IUQwHh7jey+KEAWDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WGr5nvc5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D352C2BBFC; Thu, 13 Jun 2024 05:54:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718258047; bh=Bo9w9ZSL4zxjvH+deU09KFW+rBmKUUYyQumKsggz4JM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WGr5nvc5uG9oy8c8Mh/Qn4MYJxwmEWgYqgXTs8RKe16rnpPhvqGTl4+VRnfRCXHPB WgH1BK8tXCvcavqY1TRxtcQolrDItkI8nwOR+zAv211p+J9gEeT/UdqtDUGls0bFLw SrE/T4iSUbhZm2VmJ49EDZSyJI7BP/Wo0a3pb7jw= Date: Thu, 13 Jun 2024 07:54:03 +0200 From: Greg KH To: Yu Kuai Cc: axboe@kernel.dk, tj@kernel.org, josef@toxicpanda.com, lizefan.x@bytedance.com, hannes@cmpxchg.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH RFC -next 0/7] blk-iocost: support to build iocost as kernel module Message-ID: <2024061342-walk-cavalier-7e48@gregkh> References: <20240613014937.1326020-1-yukuai1@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613014937.1326020-1-yukuai1@huaweicloud.com> On Thu, Jun 13, 2024 at 09:49:30AM +0800, Yu Kuai wrote: > From: Yu Kuai > > Yu Kuai (7): > kernfs: export pr_cont_kernfs_path() > cgroup: export cgroup_parse_float > block: export some API > blk-iocost: factor out helpers to handle params from ioc_qos_write() > blk-iocost: parse params before initializing iocost > blk-iocost: support to free iocost > blk-iocost: support to build iocost as kernel module No where do you say _why_ building this as a module is a good idea. Why do this at all? thanks, greg k-h