Received: by 2002:ab2:6f44:0:b0:1fd:c486:4f03 with SMTP id l4csp202609lqq; Wed, 12 Jun 2024 23:47:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV+YfjmEzg6oAnihs5cglnB27nSuPg9WUgmniBMqLYHwXk5KCX/aXfoq6t7iy50k0Y0Z9EWBlveZx7gdJ1OYX1sRIczENJtRjm2AHhYpA== X-Google-Smtp-Source: AGHT+IGfkC77Ui6exJrpPKzWIGfS/5flV+tj23FpPTIeZG3fyUsiZ7omvoMIl2SDLi4loBol2dOx X-Received: by 2002:a25:a167:0:b0:dfa:6ea7:b008 with SMTP id 3f1490d57ef6-dfe68433fa1mr4065846276.42.1718261245577; Wed, 12 Jun 2024 23:47:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718261245; cv=pass; d=google.com; s=arc-20160816; b=FX6kWyZViONG71gc+aY9DeP8NqsiMREJbKn48LkIxBSMAqQQes0sk86mMRGcZb6Wwa OLUdiHXq9I54lMGbu9LCynlVvfjS3QITzwELqAyT/EMfgAXZ6yprwwdYvg81+0jflMW0 6AwhTVshXFXKFDyMMpDPvze960J0LUeEtigHs8sC2ILQn7QZg7XFB0cU7sILNe9z47z9 R28dGS5rq15JW78jwwvd7tU1WMQ8j7jjF4EVz0IgrnbU7YYRrxvA1rAh0GPPqMw59GdA CnHZHFNB9JM5h5xZWJ+yQgkuls512WPmcGVzbEDaEZkJkvGKcsj9ciZxbej/8lf7bS7v wEgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=HCtqMLVuRneD2I9CpHCTtTW3x2u6neu0+QY3rL0Tqqw=; fh=+UO5llTb3d+O/njgczElxBUjevivQoy7NZgWQBJkzvc=; b=VrOteYoTdWKu30BCqjFQuyIIq6UlFGF5ufxCBSUN0Gr93ddyZ4lThRkQzEuUBUqV1I t4o+NGXMVliFNjIrensfRXbYtO5ps5OmCLENxWEWucBFzEISGsHPhEGAgZjqMLY42Vr1 38g+B/j7iORUPAAiDzKwgS4HK2VmKKxiAlznC7fQn6ygCH2ngv89LkxDsdXj7lao056P V3FZBk7bQZNIzxLv/WCTD3BkmnUAvCSnHaBymxzNv3PaYuYLJIZhHWMnIPPHH1+e722K YQe3igp0A/znoaSVpSFt7hnni5pU+S8x2k0bwwDWpxf+8XQOXC9WIMreOG4mO0BHB73Y 4YWQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MGAgzDHQ; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-212651-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212651-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-441f2fb74b4si7987881cf.394.2024.06.12.23.47.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 23:47:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-212651-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MGAgzDHQ; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-212651-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212651-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 481661C212F9 for ; Thu, 13 Jun 2024 06:47:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5925C137C54; Thu, 13 Jun 2024 06:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MGAgzDHQ" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E497137924 for ; Thu, 13 Jun 2024 06:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718261227; cv=none; b=iiopnBMonBYtHlsuR8By0ctIOrkCNvvr4EKTX9YAxe4orQDq+dpDTtXBu3CUhvH952r8do2ME1QQBolzyHB+xo/NhNvfilmm0gnmLwT/5aDhnXRMhloUc3rXcW8gqJHLpJTFwXYbHUw5LIBrpdqTWO90rf8MmQJKx1uK4Oip1cQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718261227; c=relaxed/simple; bh=hKFBgo1zxsvPe2XZH3PZju070f1XZgJSoxjnv76xuss=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=IdZ2riujQqaHYhQ3IR1zzTu1ig3X3UqeYWYqBjc6AjuYYYiE01vX5nqEgtmk4whB5sNxI338NyipXvGHBCfHgtJgOdvn0lDxO8x7LAuNo1m7ZMBPBZGD/oBygEbxPZEBbPXUldG2luPhJm0ul11nt8F2l3Rmroj85A/LI/hzPwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MGAgzDHQ; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718261226; x=1749797226; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=hKFBgo1zxsvPe2XZH3PZju070f1XZgJSoxjnv76xuss=; b=MGAgzDHQwGD0TqrbxdBJvXDDNr104kWZKZSmD2d2nwoF/REuOjALJkfg 8JZOol0ddOOwFPeGyN3cWsQInMAAAcGKk1bazqzthJ7xCP4GSrtJ1PiMg jFUwnqn6PHqSJsJk8R22GMBcKMI9lc0SLvsR5MEMS830bPLFz8Jbhwx+8 LFL8Ed8zzcJNEbMskJCe7xok8jPe7if3Tsln45rlG5Ehd2fcR2Me+yWxu 9mURx/Z6E4BRV0I2zv12XaDoqHYPk+MWqJFVBXEK3TrB1xzBSfGMPNPbg R6nyuU5Vle5vvSKF7/q8JFMGXfOWX/fyAJV0G58k9ru7e+H1Fuk85lPWL w==; X-CSE-ConnectionGUID: cftHbgbJTBKl4r7ZTh+VQg== X-CSE-MsgGUID: Szm8+iUTQaK0ZVcyAp0Kfw== X-IronPort-AV: E=McAfee;i="6700,10204,11101"; a="32546796" X-IronPort-AV: E=Sophos;i="6.08,234,1712646000"; d="scan'208";a="32546796" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2024 23:47:06 -0700 X-CSE-ConnectionGUID: HnzvIUYeRd2KKrf3gOlWZw== X-CSE-MsgGUID: yKKRf0CPSI6AvloXzCwYhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,234,1712646000"; d="scan'208";a="40149228" Received: from unknown (HELO [10.239.159.127]) ([10.239.159.127]) by orviesa009.jf.intel.com with ESMTP; 12 Jun 2024 23:47:02 -0700 Message-ID: <75d459d5-1d04-4d10-bc04-71ea83e55ccc@linux.intel.com> Date: Thu, 13 Jun 2024 14:44:43 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: baolu.lu@linux.intel.com, "Tian, Kevin" , Joerg Roedel , Will Deacon , Robin Murphy , Jean-Philippe Brucker , Nicolin Chen , "Liu, Yi L" , Jacob Pan , Joel Granados , "iommu@lists.linux.dev" , "virtualization@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 06/10] iommufd: Add iommufd fault object To: Jason Gunthorpe References: <20240527040517.38561-1-baolu.lu@linux.intel.com> <20240527040517.38561-7-baolu.lu@linux.intel.com> <20240612132531.GV791043@ziepe.ca> Content-Language: en-US From: Baolu Lu In-Reply-To: <20240612132531.GV791043@ziepe.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/12/24 9:25 PM, Jason Gunthorpe wrote: > On Sat, Jun 08, 2024 at 05:58:34PM +0800, Baolu Lu wrote: > >>>> +static int iommufd_fault_fops_release(struct inode *inode, struct file *filep) >>>> +{ >>>> + struct iommufd_fault *fault = filep->private_data; >>>> + >>>> + iommufd_ctx_put(fault->ictx); >>>> + refcount_dec(&fault->obj.users); >>>> + return 0; > > This is in the wrong order, dec users before ctx_put. Done. Best regards, baolu