Received-SPF: pass (google.com: domain of linux-kernel+bounces-212661-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Subject: Re: [PATCH RFC -next 1/7] kernfs: export pr_cont_kernfs_path()
To: Greg KH <gregkh@linuxfoundation.org>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, tj@kernel.org, josef@toxicpanda.com,
 lizefan.x@bytedance.com, hannes@cmpxchg.org, linux-block@vger.kernel.org,
 linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, yi.zhang@huawei.com,
 yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
References: <20240613014937.1326020-1-yukuai1@huaweicloud.com>
 <20240613014937.1326020-2-yukuai1@huaweicloud.com>
 <2024061314-moodiness-snowflake-14c5@gregkh>
From: Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <724f3d15-769e-705d-986f-75a33ad6d715@huaweicloud.com>
Date: Thu, 13 Jun 2024 14:55:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <2024061314-moodiness-snowflake-14c5@gregkh>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

?? 2024/06/13 13:55, Greg KH д??:
> On Thu, Jun 13, 2024 at 09:49:31AM +0800, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> This helper is used in iocost, prepare to build iocost as kernel module.
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>>   fs/kernfs/dir.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
>> index 458519e416fe..84ad163a4281 100644
>> --- a/fs/kernfs/dir.c
>> +++ b/fs/kernfs/dir.c
>> @@ -279,6 +279,7 @@ void pr_cont_kernfs_path(struct kernfs_node *kn)
>>   out:
>>   	spin_unlock_irqrestore(&kernfs_pr_cont_lock, flags);
>>   }
>> +EXPORT_SYMBOL_GPL(pr_cont_kernfs_path);
> 
> This isn't the helper that needs to be exported, it's a include wrapper
> that is using this for cgroups.  Please document this much better and
> perhaps, just fix up the cgroups code instead?

Thanks for the notice, I didn't think much of this, just export API that
is called from iocost. I'll look into this.

Thanks,
Kuai

> 
> thanks,
> 
> greg k-h
> .
>