Received-SPF: pass (google.com: domain of linux-kernel+bounces-212885-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5
Precedence: bulk
MIME-Version: 1.0
Message-Id: <ce1d8150-c595-44d5-b19a-040920481709@app.fastmail.com>
In-Reply-To: 
 <CACRpkda==5S75Bw6F3ZLUmf7kwgi_JkByiizR=m-61nrMDWuvQ@mail.gmail.com>
References: <20240610112700.80819-1-wsa+renesas@sang-engineering.com>
 <20240610112700.80819-2-wsa+renesas@sang-engineering.com>
 <CAMRc=MfZ11U+kAh1+K=DxtJ=QL+cY7Q_sBN4sQDF-RNgjpV0QA@mail.gmail.com>
 <jvnvx7a4pn6evrp5ehfrt4qsiuprq6ogvrue2a3uupwtydmgcm@2rvat7ibvgb4>
 <CAMRc=Mc4__0zzJZG3BPnmbua88SLuEbX=Wk=EZnKH5HQvB+JPg@mail.gmail.com>
 <CACRpkda==5S75Bw6F3ZLUmf7kwgi_JkByiizR=m-61nrMDWuvQ@mail.gmail.com>
Date: Thu, 13 Jun 2024 10:50:25 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Linus Walleij" <linus.walleij@linaro.org>,
 "Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
 Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
 "Jonathan Corbet" <corbet@lwn.net>, "Kent Gibson" <warthog618@gmail.com>,
 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
 "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v9 1/1] gpio: add sloppy logic analyzer using polling
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 13, 2024, at 10:27, Linus Walleij wrote:
> On Thu, Jun 13, 2024 at 10:17=E2=80=AFAM Bartosz Golaszewski <brgl@bgd=
ev.pl> wrote:
>
>> On second thought
>> though: are you sure drivers/gpio/ is the right place for it?
>
> Actually that is something I requested.
>
> I think it fits in drivers/gpio as it is such a clear cut usage of GPIO
> lines, and it doesn't really fit into any other subsystem.
>
>> May I suggest moving it over to drivers/misc/?
>
> Misc is a bit...
> messy. I remember Arnd being very sceptical about putting stuff there
> rather than creating new subsystems, so since I've tried to avoid it,
> albeit recently more and more stuff gets merged there again :/

Right, and that is mostly to avoid having code in there because
there is no other place for it. Some parts of drivers/misc should
have been a separate subsystem, some should have use an existing
subsystem, and other parts should have never been merged.

The parts of drivers/misc that make the most sense to me are
those that expose a one-of-a-kind piece of hardware as a
single character device.

This one would probably fit into drivers/misc/ better than
some other drivers we have in there, but leaving it in
drivers/gpio/ also seems fine.

I could also imagine the functionality being exposed
through drivers/iio/ in a way that is similar to an
adc, but I don't know if that would work in practice or
how much of a rewrite that would be.

      Arnd