Received: by 2002:a05:7208:c250:b0:86:f851:443 with SMTP id w16csp942283rbd; Thu, 13 Jun 2024 01:56:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW2XX2IREkYqCxhh+TL3Kbz6qIg9JJhhnjv4vPkaZaupLvJL8GrK+qJh4Nnb+e8aiJaFaCJHaypMTGgiFOeD2h+ef4hv2WVlMRQgsoUQQ== X-Google-Smtp-Source: AGHT+IGp71+/DfvG6TYmI6ZRCRLWFTb+euagYEPFxpS/kmDO71dyUe9+ke0bsf0qbyROMnpIp5iP X-Received: by 2002:a05:6214:2f87:b0:6b0:93fe:8ed5 with SMTP id 6a1803df08f44-6b192027674mr44427666d6.35.1718268996305; Thu, 13 Jun 2024 01:56:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718268996; cv=pass; d=google.com; s=arc-20160816; b=DpQePbjunRQ/SIrdDHevnVUjXPaXe2WDXZKQIlDZQ+ItdMd9SS+bttps4JHaxsvlIG fqj9v8is+iA/mvcHfFJAfOuCvOKAwznhArJdyAB+sr2H4WEk9fWfLJccvdkw8aG19dVw zCmMGoEVbvAGK4iXYilyLbJfHFbXew+h0Nme9yMdsCwcFV3qZa00Nj23i3oxLw4NEw9H IbNeujUgj5D4O71xU3YJkvm+yxGM5f10xYQrTmHoNSf5Gje2olCC21QBWQ23l73UOKZa hvMXDqc0eG2+pxag/nkmQvDLT7Vo04NL9eAfKnpV2Da+L5YEfRfNDdnp1ROczSPytxjc RZyA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3Dzk+C3x6/O7l/Mmw+O7gTZjYw/iV38/2gr+mmH9V9k=; fh=QzLaDZgJNLq67eynHvd3gHg1CaYmyUpVymA0vL9iwlQ=; b=I1dr0o8+ijHPxL1e1eiSl0HNfTJSGCakJdyB0ES2y2hOUhXNU5hiPLsb5LTjuKqD7k h2bzv8wUxfGCA8bw5daG+dgapoR7KS6BBYsOeXI3bbhsck8UHN4nJEYKly4dteZ+N9QE K5T0y455NTVxFJ+2J0F3QA93ycvBD2tRxFFYzexmVYoFBZt5POl2d13wma1lgMmleTP9 WeDtjulaegxNy+bKWRNfZJf76zwi9LGsKrJc8TS6C98MvdfDmqnMlwSo8v7vGQ3PImAJ xfYis3CVu9DRXLVzQelt0xhvMtm8m15gAeYLAt7BoLMXNirtA+IZueJzq2zwLD/q9F5j vp6w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=FCRHpAur; arc=pass (i=1 spf=pass spfdomain=alien8.de dkim=pass dkdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-212892-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212892-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6b2a5a174c6si10017856d6.33.2024.06.13.01.56.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 01:56:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-212892-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=FCRHpAur; arc=pass (i=1 spf=pass spfdomain=alien8.de dkim=pass dkdomain=alien8.de dmarc=pass fromdomain=alien8.de); spf=pass (google.com: domain of linux-kernel+bounces-212892-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212892-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 139371C20C36 for ; Thu, 13 Jun 2024 08:56:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 76E5B140387; Thu, 13 Jun 2024 08:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="FCRHpAur" Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88E2A13E036; Thu, 13 Jun 2024 08:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718268923; cv=none; b=nRkzT2XUPwB79u02I5/WbrUx6d8789A0zfCoxGgk5bLHnVB/5vJnxN5ykdRmlVWrjuOxZlDvC/PJafVoLjrMv3++ITatyie1fhbCaqeTcbRmlq9AsrrMW/BwAKgrBocG26ByL9M0WBRSH0KA3gN8NK0oqPKJe7QzPGq9aM89hjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718268923; c=relaxed/simple; bh=Mbx86OvHeq6gyJt0/wrbcA7csW4sD7XcvVlcTa4GkFA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=quQCWGSRx2vQJbrbqOJXLZ1ulBdkozJakDvfYNfYYPGJd2NZCqZcbZRQ5S3ScQ6K1Z83uiZ3VCka1WAagExiudIrNLz27Uex0zNglJ92mOfIxCdho6hz6rXYSc+jCTycVFygBjbnBMfqnsDFKjTSgR+vmEtxdFOboR8ywWgl538= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=FCRHpAur; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 3C24740E016C; Thu, 13 Jun 2024 08:55:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bZBfFqES31R9; Thu, 13 Jun 2024 08:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1718268915; bh=3Dzk+C3x6/O7l/Mmw+O7gTZjYw/iV38/2gr+mmH9V9k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FCRHpAurF+Wm/EOGZM65m6GLwmaYdiGwKyoDw/JKgAHLBrGG3jBdRefQOXpURQTgq pRL5nPED5jvwl8KeUqkAUCH6sFbGufzeSw3VpJopkeeMYQpYB5G33X3y52FuuSOjEa UoE0qjM8ngZca0OcO5ZFtgGSmJIlYEFoQ9sPzGXPtbMAnZ8Gn9WfDQIIJ816tJwGLT HEbNzybwLGzKBYTBuA4MgSO2lVzwWn5HKCcGbG6bE9NSaMPRKIgy4Zdg6UWCbU5EP3 O94BGrYUpFVF0msJz0MP6Klh6B/upITbg7aWriz3jVjxxBdVbdIL0SkQe7DoAsJH5w D2AfKnd4qR7iU40tp4HAhSuErQrS+q3Fi3cBakIuJTKvkhIab+WFMJ7YXhB8uBu0hU d4S71CrP5lW6ej2pT4Lb2Pi0Wi5oxXRQ+mFEaTJjmm2f6KiNzzazG2HILEb0Pka/l8 mtn6YgY/hyo9gxaLihpmwJvvXkkL0AGJbQEv1hcIOKqkPOsjOpKD7o3Rh1XNFh6pfK cpvZI+lQ8IESc/H9E4rdWOWCqmhHivDRq5HfiVodUvng//j5tZ6aldkWgGSHhrA0l+ Qu1UJsBfoHjn8sLTURFd2GcB//vOtSFVFBnGjrDp6HhZfQBMHzkK+FuKZ0vq0+8f1c O4IIWM8GAvZiDWb5079/AjxQ= Received: from zn.tnic (p5de8ee85.dip0.t-ipconnect.de [93.232.238.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9031940E0081; Thu, 13 Jun 2024 08:55:06 +0000 (UTC) Date: Thu, 13 Jun 2024 10:55:05 +0200 From: Borislav Petkov To: Ard Biesheuvel Cc: Ard Biesheuvel , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Ashish Kalra , Dave Young , Mike Rapoport , Dan Williams Subject: Re: [PATCH v3] x86/efi: Free EFI memory map only when installing a new one. Message-ID: <20240613085505.GDZmqz6UWxZ1QxKeHu@fat_crate.local> References: <20240612135638.298882-2-ardb+git@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Jun 13, 2024 at 10:28:05AM +0200, Ard Biesheuvel wrote: > Given that this fixes an actual use-after-free bug that is not > specific to TDX/SEV or kexec, I'm inclined to queue this up as a fix. > > @Boris: Mind if I take this as an EFI fix? Otherwise, can you queue > this up? Thanks. Sure, go ahead: $ git log master..tip/master arch/x86/platform/efi/memmap.c $ Should be fine, conflict-wise. :-) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette