Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp22335lqs; Thu, 13 Jun 2024 02:34:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXqZril/cMFtKdiXGFsXuqBu39Lvoz2k78jvGAaTosK1iSMY4jhzo4ei1l7b+VkygGYinm9S1GpjpU9T/guMwtwJTutMAYgcT8mmsMyuQ== X-Google-Smtp-Source: AGHT+IFRA7Czz/lPSxLKg6Gy40yRVkDdAd+NwAyfpK3PKE1M964lLZr9QY+KW9FZp7Vmvki8bMkM X-Received: by 2002:a17:906:1354:b0:a6f:1378:1328 with SMTP id a640c23a62f3a-a6f47c7da7dmr260645966b.10.1718271261497; Thu, 13 Jun 2024 02:34:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718271261; cv=pass; d=google.com; s=arc-20160816; b=KwlGfJ39U9q2W4ANZsd9XeQa9i36JSskbsLaORrsVF49iHitiDGtSzSep7gyPsb8QP 7CPzVhbXj8RhagxBGG238mOH2VbhkT0+yqJg+10rqs8BAmM2VImYBYvlXJwCh8huv0DQ yeHyfWVtqF0mtgIBjaxuTn1a/O9hxxFRVu119B/z/V8TAxnKglg+lJsRvV9eRJv678jX iJb+btSPhn3IzH7HBIU1IpitAfTJNyxeNQwUk/WQ2xESOf4iOK0MIxXsxGmg/WHY08eX gt56TkCai4LIVACQ255nD8U+fMxsEuBirbLeiKtDHNpu2OBCd5tQrHPamW/YoUFOxTJJ DDKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=vPX1AHD54ZweMud2CAGeNnwrJ7C9fon4sYTRXKnYsD8=; fh=DYM55VEvUWORD4VJJQN6QxjiSeM9LSCwC6a32NRjYLc=; b=vMXRnNCpUl362DsE/ehmpRyqyaXPnpRDfMNZV7sCJeissb/xt8r+hAZZ5o7UWndUsI Hm0qk1GMYEpfggIeUuLLF2tFU9ywRQYbEAdC4M90txCLJPDRU+TveJOvWaKt0TpvQXHZ +a1FWSeZinH1pyve/lqgG94gqqD96nn/2JsZfpxohZ72YG2/EcHpVZLpPzwPSuOGPbDf TgegdPlfv1rUJOxhK+7Un3czyDl2i2Iv7qR/wBlrp3zjYjaD8Ds9G3Hsonv8nKIB2DhE OBwbGYpNBhtc9ZvGMYzo4sEU0Qv0pCdDf9VvlEW6AQ4LP58U34KqvSixlJ1O7TX6VRdd 55PQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=NDoSpHHB; arc=pass (i=1 spf=pass spfdomain=mediatek.com dkim=pass dkdomain=mediatek.com dmarc=pass fromdomain=mediatek.com); spf=pass (google.com: domain of linux-kernel+bounces-212956-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212956-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f56e80fd5si49807066b.1001.2024.06.13.02.34.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 02:34:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-212956-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=NDoSpHHB; arc=pass (i=1 spf=pass spfdomain=mediatek.com dkim=pass dkdomain=mediatek.com dmarc=pass fromdomain=mediatek.com); spf=pass (google.com: domain of linux-kernel+bounces-212956-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212956-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3BABD1F268B6 for ; Thu, 13 Jun 2024 09:34:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 64FA913FD62; Thu, 13 Jun 2024 09:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="NDoSpHHB" Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E802913D891; Thu, 13 Jun 2024 09:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718271250; cv=none; b=dEOoiF+HwGQbJbGfheuRkOax/HrW097A9mX7GSJH+B4WROQYJvihGLgEVLlrQTVfxBAFGsRIB5LAJu0YOdjNOBmrSLfXzUCIM8pH1jsM72lCZonpPxcLUb5kzdILDxgks/SGZzlEgjdwJZ0bRoj+3N8pi/2MtPOXpKJ1zwJY6w4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718271250; c=relaxed/simple; bh=a+cbWQvvYbCHyU10BIV7kSt3CraTWeso0Dxz5NmyJxg=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=l/1XCNgd4EBfD4dn+sUdt/aPqqOiJ4J1Sfw8gXu+BTDhWau1LECU4DhjSRuSzyKNPg7Ycbj6E49lpQg7WydZv2JubAA29XIgZ6utsmbPpxFbDj++4wgr5O8ySles6YyB1uFpE2CBKZTbcR0gti91xBBYqm2iaiFZtLmTQ6h6KE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=NDoSpHHB; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com X-UUID: 115e1d46296811efa22eafcdcd04c131-20240613 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=vPX1AHD54ZweMud2CAGeNnwrJ7C9fon4sYTRXKnYsD8=; b=NDoSpHHBM/n23oYXmezy28QrTPQbox3OJBdQUFg7uYJqqb4IwBaU0wUd6KUXF49I+4OwaVNHKy28L3uZ1nJ9pfpLsB+I9+8SL/MBdBXnX3yvgF1SaT1sg7txWOL4cSvd+TX4DzMOQhk/qc6CBRhwMCRFVYVPlNv3yhBsADpOUmw=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.39,REQID:71b0c558-c9a9-4369-ad16-40f3507c8c0f,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:393d96e,CLOUDID:7ef28a88-8d4f-477b-89d2-1e3bdbef96d1,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 115e1d46296811efa22eafcdcd04c131-20240613 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1758424830; Thu, 13 Jun 2024 17:34:01 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 13 Jun 2024 17:34:00 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 13 Jun 2024 17:33:59 +0800 From: Yunfei Dong To: =?UTF-8?q?N=C3=ADcolas=20F=20=2E=20R=20=2E=20A=20=2E=20Prado?= , Sebastian Fricke , Nicolas Dufresne , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Nathan Hebert , Andrzej Pietrasiewicz CC: Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , Yunfei Dong , , , , , , Subject: [PATCH v2 0/3] media: mediatek: vcodec: fix vcodec smatch warning Date: Thu, 13 Jun 2024 17:33:54 +0800 Message-ID: <20240613093357.583-1-yunfei.dong@mediatek.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N Fix below smatch static checker warning from [bug report]: The patch 397edc703a10: "media: mediatek: vcodec: add h264 decoder driver for mt8186" from May 12, 2022 (linux-next), leads to the following (in development) Smatch static checker warning: drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_if.c:351 vdec_h264_slice_decode() potential NULL container_of 'fb' drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c:337 vdec_vp8_slice_decode() potential NULL container_of 'fb' drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c:728 vdec_h264_slice_single_decode() potential NULL container_of 'fb' --- Changed with v1: - Change the return value from -EBUSY to -ENOMEM when the driver can't get frame buffer. --- Yunfei Dong (3): media: mediatek: vcodec: fix h264 multi statless decoder smatch warning media: mediatek: vcodec: fix vp8 stateless decoder smatch warning media: mediatek: vcodec: fix h264 stateless decoder smatch warning .../mediatek/vcodec/decoder/vdec/vdec_h264_req_if.c | 9 +++++++-- .../vcodec/decoder/vdec/vdec_h264_req_multi_if.c | 9 +++++++-- .../mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c | 10 +++++++--- 3 files changed, 21 insertions(+), 7 deletions(-) -- 2.18.0