Received: by 2002:a89:413:0:b0:1fd:dba5:e537 with SMTP id m19csp22444lqs; Thu, 13 Jun 2024 02:34:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUkBjdVUgZx5ys4T5HApO7E6v92LR8Psx1/MMGEUYyIDyY7BOTquUw8T0YTiZe0779OmAOxHyaxFWiWGmMEO26INn7wHlNJBqulYOMtoQ== X-Google-Smtp-Source: AGHT+IHhv/UZn3QxjCuf5GHng2rjtHj7pttRWeLsCmPHVuGggpzIE9SOfv/QCK3jqCz+6aehe4MY X-Received: by 2002:a05:6102:401:b0:48c:42e9:1eeb with SMTP id ada2fe7eead31-48d91e51cdemr4544104137.17.1718271272760; Thu, 13 Jun 2024 02:34:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718271272; cv=pass; d=google.com; s=arc-20160816; b=hgMBm7NDNiH3FcOHW0a+nEWIhxkIuaLUU6XPcaW2m9ghvdjcuJ/SUszNrlLkzSghRd Pv7t2BoJcepQCPnki4mz8vYMjYRx6XvFueLaigDfuacM74T4kEta1+ZoJSUBG67n5DKi F4ngH1NJ7sfWRS6jw1o/UL0+bTm8gWN4gPeUC3YWL2hwz6P+cB2qe+yBDY6JT7kfefMz 0isRNTGqF89kRZNbgFJFk+zBtvMThK+zc4FgCmCBVyGuf9FuhM2BArBnvK7HcdGOzhV0 lX8AAsYNe2/SJyeIauc3c8E5RO66rFWBg0KnoHl47e+lghoxKb+Uik9g8o/6U2W5PckB fQIQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=1UKaAEi8SfdWcfTGfQXa3jKApmhHrlsIfivXZeA+g6U=; fh=DYM55VEvUWORD4VJJQN6QxjiSeM9LSCwC6a32NRjYLc=; b=s3F5UmaAhA65vgEFq6WAZMMLuqDUPLtk0stGOGwzrfgaGs47nD/6rB2JRiYp23wwzB lHTl/n8UT/xiyjR2pzJf13ijMnLcKOGSo5OzFvmuqstUr/1lF69P3VY6a2hIeZ01rvXT 3upzYhmwcUxXCoftEiEWyNOg4JjK628CUL9usKBMqU7yeRrtnOLge4C0MtqPyVLkkwlX uUfNRjQDPB8qQqNkc6spmh2X+mYST8io2U5MaVYg14V4X6jc4iGo8fFWUtBIYQisary2 uA5O5BhcFNHRtWY0JFoKQDgd3/B3Aa9DkbnTVXsnoAljJ9v1MfHa/Tzx2Ot9+PEg2joa QR2g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=vEzJt+4W; arc=pass (i=1 spf=pass spfdomain=mediatek.com dkim=pass dkdomain=mediatek.com dmarc=pass fromdomain=mediatek.com); spf=pass (google.com: domain of linux-kernel+bounces-212957-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212957-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-798b627823dsi85435885a.388.2024.06.13.02.34.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 02:34:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-212957-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=vEzJt+4W; arc=pass (i=1 spf=pass spfdomain=mediatek.com dkim=pass dkdomain=mediatek.com dmarc=pass fromdomain=mediatek.com); spf=pass (google.com: domain of linux-kernel+bounces-212957-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-212957-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7A5C91C23EA7 for ; Thu, 13 Jun 2024 09:34:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B91FC140E25; Thu, 13 Jun 2024 09:34:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="vEzJt+4W" Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 586CD13D529; Thu, 13 Jun 2024 09:34:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718271251; cv=none; b=mRhjWGrPT5OBKMMn1BRyqmbJh2QOqw59aOnQvFbh/dVga4IelZCY5tqhFCmokaqsD5+l7vEFiUe/Cev5MGlF1CI/3RhCPaeqHjOXGVDbxvoD2joqXgdLgBDbJzbG8NiaWNlOsOBWPerjMKg22uEmNFmR0IYjJRq/Gwe8vVDgZhI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718271251; c=relaxed/simple; bh=E8Dj8RTCeKVdFk78jUZNihxjqnFkD5PF8f/iewJazcI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YKRKC5TQindatkU3g0wnFbZuUJaoO/C6jfnY9igl7BZ7n+3+mXcWRJFwXpH3nlQrPolEF9kStfxMzrwqXISUcEmgyUS3mOaAyqhIAt/hhWNJ/KoPSko7dAiqv6oFMUqYh67oCnffkYSmP5iW70nbcO63VTAwvnikqaqhXbvptXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=vEzJt+4W; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com X-UUID: 11fbd522296811efa22eafcdcd04c131-20240613 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=1UKaAEi8SfdWcfTGfQXa3jKApmhHrlsIfivXZeA+g6U=; b=vEzJt+4W2E2EpPgEWATGlWzVwq1hGDTZdg5nX3uQ0ndWFHNPMqk2vXrDw+YX4uxehN+JNbiECoLTHzqBjhqr7zsuGZ+UpiXYqh7F24/d3t3AZtZ977LU3GZt1+I3DlfQWfJYJDozjZFAU4S8d0TW7X27ofBeJEeJk71H9FtbR3I=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.39,REQID:719b046b-ba86-4959-a47f-0d9c88e3957e,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:393d96e,CLOUDID:84d7f193-e2c0-40b0-a8fe-7c7e47299109,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 11fbd522296811efa22eafcdcd04c131-20240613 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1448756589; Thu, 13 Jun 2024 17:34:02 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 13 Jun 2024 17:34:01 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 13 Jun 2024 17:34:00 +0800 From: Yunfei Dong To: =?UTF-8?q?N=C3=ADcolas=20F=20=2E=20R=20=2E=20A=20=2E=20Prado?= , Sebastian Fricke , Nicolas Dufresne , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Nathan Hebert , Andrzej Pietrasiewicz CC: Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , Yunfei Dong , , , , , , Subject: [PATCH v2 1/3] media: mediatek: vcodec: fix h264 multi statless decoder smatch warning Date: Thu, 13 Jun 2024 17:33:55 +0800 Message-ID: <20240613093357.583-2-yunfei.dong@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240613093357.583-1-yunfei.dong@mediatek.com> References: <20240613093357.583-1-yunfei.dong@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N Fix smatch static checker warning for vdec_h264_req_multi_if.c. Leading to kernel crash when fb is NULL. Fixes: 397edc703a10 ("media: mediatek: vcodec: add h264 decoder") Signed-off-by: Yunfei Dong --- .../vcodec/decoder/vdec/vdec_h264_req_multi_if.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c index 2d4611e7fa0b..1ed0ccec5665 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c @@ -724,11 +724,16 @@ static int vdec_h264_slice_single_decode(void *h_vdec, struct mtk_vcodec_mem *bs return vpu_dec_reset(vpu); fb = inst->ctx->dev->vdec_pdata->get_cap_buffer(inst->ctx); + if (!fb) { + mtk_vdec_err(inst->ctx, "fb buffer is NULL"); + return -ENOMEM; + } + src_buf_info = container_of(bs, struct mtk_video_dec_buf, bs_buffer); dst_buf_info = container_of(fb, struct mtk_video_dec_buf, frame_buffer); - y_fb_dma = fb ? (u64)fb->base_y.dma_addr : 0; - c_fb_dma = fb ? (u64)fb->base_c.dma_addr : 0; + y_fb_dma = fb->base_y.dma_addr; + c_fb_dma = fb->base_c.dma_addr; mtk_vdec_debug(inst->ctx, "[h264-dec] [%d] y_dma=%llx c_dma=%llx", inst->ctx->decoded_frame_cnt, y_fb_dma, c_fb_dma); -- 2.18.0